LGTM with comment. Thanks!
https://codereview.chromium.org/1208013002/diff/80001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/1208013002/diff/80001/src/code-stubs-hydrogen.cc#newcode1794
src/code-stubs-hydrogen.cc:1794: HValue* literals =
Also LGTM, nice :).
https://codereview.chromium.org/1208013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm if comment addressed.
https://codereview.chromium.org/1209903003/diff/20001/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/1209903003/diff/20001/src/arm64/lithium-codegen-arm64.cc#newcode5501
Comment #23 on issue 4052 by yang...@chromium.org: v8 spends lots of time
iterating the heap in FindSharedFunctionInfoInScript
https://code.google.com/p/v8/issues/detail?id=4052
Fedor: sorry for having lost track on this. I had a solution in mind but
got side tracked for quite a while. I
I took a look yesterday and it looked fine to me, modulo the test failures
of
course. Am OoO today so if you want to land, please poke another reviewer.
Cheers :)
https://codereview.chromium.org/1212473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/05/05 14:28:00, fedor wrote:
Yang,
Any news? ;)
Doh. You sent this to my @google.com account where it got drowned out. It
didn't
show up on my @chromium.org account which I use daily... Sorry about this.
In
the meantime I found a better solution for issue 4052.
Updates:
Status: Fixed
Comment #24 on issue 4052 by yang...@chromium.org: v8 spends lots of time
iterating the heap in FindSharedFunctionInfoInScript
https://code.google.com/p/v8/issues/detail?id=4052
(No comment was entered for this change.)
--
You received this message because
Updates:
Status: Fixed
Comment #3 on issue 4050 by yang...@chromium.org: Canonicalize cleared weak
cells
https://code.google.com/p/v8/issues/detail?id=4050
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue
Updates:
Status: Fixed
Comment #12 on issue 3892 by yang...@chromium.org: TryCall does not
correctly propagate termination exception.
https://code.google.com/p/v8/issues/detail?id=3892
(No comment was entered for this change.)
--
You received this message because this project is
Thanks for the review :)
--Michael
https://codereview.chromium.org/1209903003/diff/20001/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/1209903003/diff/20001/src/arm64/lithium-codegen-arm64.cc#newcode5501
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1209903003/40001
https://codereview.chromium.org/1209903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1215623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1215623002/diff/1/src/compiler/common-operator-reducer.cc
File src/compiler/common-operator-reducer.cc (right):
https://codereview.chromium.org/1215623002/diff/1/src/compiler/common-operator-reducer.cc#newcode273
src/compiler/common-operator-reducer.cc:273:
Comment #25 on issue 4052 by bugdro...@chromium.org: v8 spends lots of time
iterating the heap in FindSharedFunctionInfoInScript
https://code.google.com/p/v8/issues/detail?id=4052#c25
The following revision refers to this bug:
https://codereview.chromium.org/1208013002/diff/80001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/1208013002/diff/80001/src/code-stubs-hydrogen.cc#newcode1794
src/code-stubs-hydrogen.cc:1794: HValue* literals =
Hello purchase manager,
How are you?
Nice to contact with you.
Here, i'd like to recommend our solar power desk lamp for your reference,Please
see the following details and the attached pictures. .
Specifications:
Material:ABS
Size:10*9.2*26cm
Solar panel: 22MaH/4.5V, lithium battery :
Reviewers: jarin,
Description:
[turbofan] Add support for pushing returns into merges.
This will enable tail call optimization even across inlining. Plus it
might enable some other interesting optimizations as well. In order to
avoid blowing up the generated code, we can still canonicalize the
Patchset 3 (id:??) landed as
https://crrev.com/8a3cf4ecef1fce76137270845604292bdbdadcd4
Cr-Commit-Position: refs/heads/master@{#29310}
https://codereview.chromium.org/1209903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1209903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
https://codereview.chromium.org/1215623002/diff/1/src/compiler/common-operator-reducer.cc
File src/compiler/common-operator-reducer.cc (right):
https://codereview.chromium.org/1215623002/diff/1/src/compiler/common-operator-reducer.cc#newcode273
src/compiler/common-operator-reducer.cc:273:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1215623002/20001
https://codereview.chromium.org/1215623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 2 (id:??) landed as
https://crrev.com/7337021e54d8a15183c2d4247b2ed83d9b5120ef
Cr-Commit-Position: refs/heads/master@{#29311}
https://codereview.chromium.org/1215623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1215623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/d350ab47f70a9810a28100bef7d98df84ff90755
Cr-Commit-Position: refs/heads/master@{#29312}
https://codereview.chromium.org/1210393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1210393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Comment #8 on issue 4132 by bugdro...@chromium.org: Improve performance
when break points are set.
https://code.google.com/p/v8/issues/detail?id=4132#c8
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/d350ab47f70a9810a28100bef7d98df84ff90755
On 2015/06/22 10:38:24, orion wrote:
PTAL - attempting to reland handle count patch. This change just increases
handle count limit from 16K to 30K. This is ample to compile natives and
run
the
check_handle_count unit tests on failing bots.
lgtm.
https://codereview.chromium.org/1192743005/
PTAL at patch 3.
https://codereview.chromium.org/1207693004/diff/1/Makefile.android
File Makefile.android (left):
https://codereview.chromium.org/1207693004/diff/1/Makefile.android#oldcode47
Makefile.android:47: DEFINES += android_target_arch=mips
mips_arch_variant=mips32r2
On 2015/06/24
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1208013002/120001
https://codereview.chromium.org/1208013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM! Ship it!
https://codereview.chromium.org/1215643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Reviewers: Yang,
Message:
Hi Yang,
Here is one more in the series, thanks for the help with lithium before.
This CL
has the necessary changes to IC classes to support [keyed]store ICs that
accept
a vector and slot. Thanks for the look!
--Michael
Description:
Vector ICs: Changes to the IC
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1207693004/60001
https://codereview.chromium.org/1207693004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Hey Jaro,
This is a CL for danno's code stubs. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1215623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1210393002/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] Breaks layout tests:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/682.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1210393002/1
https://codereview.chromium.org/1210393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Michael Starzinger, Yang,
Message:
Created Revert of Debugger: use list to find shared function info in a
script.
Description:
Revert of Debugger: use list to find shared function info in a script.
(patchset
#2 id:20001 of https://codereview.chromium.org/1206573004/)
Reason
Reviewers: danno,
Description:
[turbofan] Canonicalize return sequence for JSFunctions.
R=da...@chromium.org
Please review this at https://codereview.chromium.org/1211373002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+86, -43 lines):
M
Reviewers: Benedikt Meurer,
Description:
[turbofan] Enable sharing of context-independent code.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/1215643002/
Base URL: https://chromium.googlesource.com/v8/v8.git@local_opt-code-map-4
Affected files (+1, -1 lines):
Hey Danno,
This is the optimization we just talked about. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1211373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
lgtm
https://codereview.chromium.org/1220443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm (rubber-stamp mjsunit.status)
https://codereview.chromium.org/1220443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Very nice fix, LGTM.
nit: test-api/RequestInterruptTestWith*Accessor is still on the skip list
for
mips eb in cctest.status.
https://codereview.chromium.org/1220443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1220443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/240ea089053d694dd565668d6030a6f9bce4e627
Cr-Commit-Position: refs/heads/master@{#29329}
https://codereview.chromium.org/1209163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1209163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/06/26 15:15:35, adamk wrote:
Thinking about this a bit more, I'm not sure how useful this is.
Bounds-checking
here only solves the first-order problem. If the object pulled out of the
FixedArray isn't either a JS primitive or some kind of JSObject, all bets
are
off after this
On 2015/06/26 15:19:58, arv wrote:
On 2015/06/26 15:15:35, adamk wrote:
Thinking about this a bit more, I'm not sure how useful this is.
Bounds-checking
here only solves the first-order problem. If the object pulled out of
the
FixedArray isn't either a JS primitive or some kind of
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1210393003/20001
https://codereview.chromium.org/1210393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1208573002/20001
https://codereview.chromium.org/1208573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 1 (id:??) landed as
https://crrev.com/572cac67c929a5cf647f77f51f9f424f1644de71
Cr-Commit-Position: refs/heads/master@{#29321}
https://codereview.chromium.org/1215643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1192743005/20001
https://codereview.chromium.org/1192743005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 2 (id:??) landed as
https://crrev.com/7879474601991df9efddaccff821c4eda2b55f90
Cr-Commit-Position: refs/heads/master@{#29323}
https://codereview.chromium.org/1213803002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1213803002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1209383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jochen,
Message:
PTAL.
There are a few things left after this:
GYP: unused simulators + vtune
GN: the same + the things that didn't migrate to GN at all yet.
Description:
Fix missing source dependencies.
BUG=
Please review this at https://codereview.chromium.org/1217483002/
Base
On 2015/06/26 15:26:07, adamk wrote:
On 2015/06/26 15:19:58, arv wrote:
On 2015/06/26 15:15:35, adamk wrote:
Thinking about this a bit more, I'm not sure how useful this is.
Bounds-checking
here only solves the first-order problem. If the object pulled out
of the
FixedArray isn't
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1220443002/20001
https://codereview.chromium.org/1220443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: dstence, michael_dawson, mvstanton,
Description:
PPC: VectorICs: Lithium support for vector-based stores.
Port 8a3cf4ecef1fce76137270845604292bdbdadcd4
R=mvstan...@chromium.org, dste...@us.ibm.com, michael_daw...@ca.ibm.com
BUG=
Please review this at
Reviewers: Benedikt Meurer, dstence, michael_dawson,
Description:
PPC: [turbofan] Canonicalize return sequence for JSFunctions.
Port 2b9112a578f66fc976557aededf3e203f48c395e
Original commit message:
This optimization is already implemented in fullcodegen, and
basically makes sure that we do
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1206573004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/058deb27132c97c62a99826455abc2bc87fae1b7
Cr-Commit-Position: refs/heads/master@{#29327}
https://codereview.chromium.org/1206573004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1206573004/40001
https://codereview.chromium.org/1206573004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1209163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1209163002/1
https://codereview.chromium.org/1209163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 3 (id:??) landed as
https://crrev.com/6ba8455e63712e9463685f63b22ffe64058adc9a
Cr-Commit-Position: refs/heads/master@{#29330}
https://codereview.chromium.org/1213783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
LGTM
It would have been better if the methods ast-literal-reindexer.cc were in
alphabetical order but not a big deal.
https://codereview.chromium.org/1212473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
Comment #9 on issue 4132 by bugdro...@chromium.org: Improve performance
when break points are set.
https://code.google.com/p/v8/issues/detail?id=4132#c9
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/058deb27132c97c62a99826455abc2bc87fae1b7
Reviewers: danno, Jakob, Michael Achenbach, paul.l..., balazs.kilvady,
akos.palfi.imgtec, djordje.pesic_imgtec.com,
Message:
PTAL.
Description:
MIPS: Fix unpredictable random failures after direct api function call.
The use of jalr ra is unpredictable if instruction in branch delay slot
is
Comment #1 on issue 4248 by a...@chromium.org: Compound keyed lookup
evaluates key twice
https://code.google.com/p/v8/issues/detail?id=4248
Also see https://bugs.ecmascript.org/show_bug.cgi?id=4379 which might
result in a spec change.
--
You received this message because this project is
Comment #1 on issue 4249 by a...@chromium.org: Wrong evaluation order for
keyed lookup
https://code.google.com/p/v8/issues/detail?id=4249
Also see https://bugs.ecmascript.org/show_bug.cgi?id=4379 which might
result in a spec change.
--
You received this message because this project is
Ping?
https://codereview.chromium.org/1209163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/06/26 14:47:03, Dmitry S. Lomov wrote:
Erik/Adam, mind taking a look?
Looking
https://codereview.chromium.org/1212473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1213783002/40001
https://codereview.chromium.org/1213783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Thinking about this a bit more, I'm not sure how useful this is.
Bounds-checking
here only solves the first-order problem. If the object pulled out of the
FixedArray isn't either a JS primitive or some kind of JSObject, all bets
are
off after this point.
Comment #26 on issue 4052 by bugdro...@chromium.org: v8 spends lots of time
iterating the heap in FindSharedFunctionInfoInScript
https://code.google.com/p/v8/issues/detail?id=4052#c26
The following revision refers to this bug:
On 2015/06/26 12:09:51, commit-bot: I haz the power wrote:
Dry run: This issue passed the CQ dry run.
lgtm
https://codereview.chromium.org/1213783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Erik/Adam, mind taking a look?
https://codereview.chromium.org/1212473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1213783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: arv,
Description:
Add bounds-checking in runtime implementations of %FixedArray{Get,Set}
The runtime versions of these intrinsics are used by full-codegen;
hopefully this doesn't noticeably degrade performance (in optimized
code, there's no bounds-checking).
BUG=chromium:504786
https://codereview.chromium.org/1196193014/diff/40001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/1196193014/diff/40001/src/arm/full-codegen-arm.cc#newcode255
src/arm/full-codegen-arm.cc:255: __ cmp(r1,
Comment #55 on issue 1543 by ognjen.b...@gmail.com: Implement Proxy proposal
https://code.google.com/p/v8/issues/detail?id=1543
+1 for Proxy object support. Please :)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may
Committed patchset #2 (id:40001)
https://codereview.chromium.org/1217483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/3e38d644952e18238937052fb32b14a6a9c85774
Cr-Commit-Position: refs/heads/master@{#29328}
https://codereview.chromium.org/1217483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Some drive-by nits if you want to upload one more patch before landing,
otherwise I defer to arv's review.
https://codereview.chromium.org/1212473002/diff/40001/src/ast-literal-reindexer.h
File src/ast-literal-reindexer.h (right):
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1203813002/120001
https://codereview.chromium.org/1203813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1218493003/1
https://codereview.chromium.org/1218493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Exceeded global retry quota
https://codereview.chromium.org/1203813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1212613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1212613003/1
https://codereview.chromium.org/1212613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1218493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Achenbach, Jakob, kilvadyb, dusmil.imgtec,
Message:
PTAL. Should get our bots green, and unblock the rolls.
Description:
MIPS: skip embenchen/zlib test.
zlib is broken for mips after 35eb3a0260d349cb4201fed66ff62a438962bd47.
We're still working on a fix. Skip test for now,
Reviewers: danno, Jakob, paul.l..., akos.palfi.imgtec,
Message:
This patch allows to use the same version of clang (third_party/llvm/clang)
on
Mac and Linux. Works from Xcode and command line build also. And with v8
buildbots: https://codereview.chromium.org/1214753002/
Description:
Use
lgtm
https://codereview.chromium.org/1218473003/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1218473003/diff/1/src/flag-definitions.h#newcode207
src/flag-definitions.h:207: V(harmony_classes, harmony classes (implies
object literal
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1218493003/1
https://codereview.chromium.org/1218493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
Looks like mksnapshot might be failing?
https://codereview.chromium.org/1203813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1218473003/20001
https://codereview.chromium.org/1218473003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1212613003/1
https://codereview.chromium.org/1212613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
All done. PTAL
Paul, thank you so much for helping me sort out the bugs.
https://codereview.chromium.org/1203813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
1 - 100 of 203 matches
Mail list logo
