On 2015/07/01 at 20:18:45, verwaest wrote:
Awesome, thanks. Lgtm
lgtm
https://codereview.chromium.org/1217893012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
On 2015/07/01 at 20:18:45, verwaest wrote:
Awesome, thanks. Lgtm
lgtm
https://codereview.chromium.org/1217893012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
Patchset 3 (id:??) landed as
https://crrev.com/1fa4285e1ce16cfadf8c40a0993491ec4e2bbbe0
Cr-Commit-Position: refs/heads/master@{#29436}
https://codereview.chromium.org/1216933011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1216933011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1216933011/40001
https://codereview.chromium.org/1216933011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Committed patchset #1 (id:1)
https://codereview.chromium.org/1218103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/1297a51e3024352ddb16e976bf4401551fa16ad5
Cr-Commit-Position: refs/heads/master@{#29435}
https://codereview.chromium.org/1218103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Patchset 1 (id:??) landed as
https://crrev.com/70502d166f49950bf4db5e55a0afb2910713f090
Cr-Commit-Position: refs/heads/master@{#29434}
https://codereview.chromium.org/1210873007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1210873007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
The author martyn.capew...@arm.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.
https://codereview.chromium.org/1218103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
LGTM.
https://codereview.chromium.org/1218103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1218103005/1
https://codereview.chromium.org/1218103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 1 (id:??) landed as
https://crrev.com/70bb2372a223242440837e4d432548f7e40152e1
Cr-Commit-Position: refs/heads/master@{#29433}
https://codereview.chromium.org/1216543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1216543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
LGTM.
https://codereview.chromium.org/1216933011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1214573006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/a8eff645b4511bfaf1fe7e76830cb1451b78f1b6
Cr-Commit-Position: refs/heads/master@{#29432}
https://codereview.chromium.org/1214573006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
lgtm
https://codereview.chromium.org/1216543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1216543004/1
https://codereview.chromium.org/1216543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/1214573006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1214573006/1
https://codereview.chromium.org/1214573006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1210873007/1
https://codereview.chromium.org/1210873007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/1210873007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/ce2ee6f71a7100be443818fc1a7a44b140fdee76
Cr-Commit-Position: refs/heads/master@{#29431}
https://codereview.chromium.org/1225463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1225463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/third_party/icu to 7fe225d77f307fdbe24695179a84336ef95c1253
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1225463002/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected fi
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1225463002/1
https://codereview.chromium.org/1225463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Weiliang,
Message:
PTAL.
Description:
X87: [strong] Implement strong property access semantics.
port 7281f8015181736703d3663c9c570be537f008c1 (r29384)
Fix a bug in R29384.
original commit message:
Revert "Revert relanded strong property access CL"
Regression issues sh
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Make context register implicit for CallInterfaceDescriptors
port 7015fd20531ee8498352f82d626c78023a1f6857 (r29402)
original commit message:
Up until now the context register was listed explicitly in each stub's
CallInterfaceDescript
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [turbofan] Add CalleeSavedFPRegisters to CallDescriptor.
port b4275a70eb1e6b6dc0f3c77b9be6bcfca3f80c20 (r29378)
original commit message:
This change makes possible to save and restore the FP registers
in the Prologue and Return part
Updates:
Cc: rossb...@chromium.org
Comment #5 on issue 4259 by ad...@chromium.org: DCHECK failure:
scope_info_->StackSlotIndex(*name_handle) < 0 || is_block_scope()
https://code.google.com/p/v8/issues/detail?id=4259
Having poked more closely at this in gdb (thanks to jkummerow for the
Comment #9 on issue 4014 by gok...@google.com: ES6 Map performance issues
https://code.google.com/p/v8/issues/detail?id=4014
Any plans to improve 2x performance hit on iteration?
--
You received this message because this project is configured to send all
issue notifications to this address.
Reviewers: jochen,
Description:
Fix some clang warnings with -Wmissing-braces in v8.
Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
if the first field of STRUCT is itself a struct. This can
be more simply wri
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1215863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/a1dcac3df7a23a311dea12b8478e3c7517877496
Cr-Commit-Position: refs/heads/master@{#29430}
https://codereview.chromium.org/1215863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Sorry for the noise, closing.
https://codereview.chromium.org/1215423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and sto
Ignore this for now, I realize it's not yet correct.
https://codereview.chromium.org/1215423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
Reviewers: rossberg,
Description:
Fix ScopeInfo::StackSlotIndex to skip over non-locals
Block scoping can cause lexical variables in inner scopes to be allocated
stack slots in their outer declaration scope. Neither of the callers of this
method expected such variables to be returned, so it has
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1215863003/20001
https://codereview.chromium.org/1215863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
lgtm
https://codereview.chromium.org/1215863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/06/30 12:11:52, rossberg wrote:
On 2015/06/29 21:30:26, adamk wrote:
> I've confirmed locally that this fixes the performance test. So the only
> question is whether it's the right approach.
>
> I think there's not much point in leaving the flag in, given that there
are
so
> few refer
Updates:
Status: Fixed
Comment #7 on issue 3946 by caitpott...@gmail.com: All functions born of
non-legacy function syntactic forms do not have caller and arguments
properties
https://code.google.com/p/v8/issues/detail?id=3946
This appears to be fixed
--
You received this message b
Updates:
Status: WontFix
Comment #6 on issue 4108 by a...@chromium.org: Function bind issue with
caller and arguments
https://code.google.com/p/v8/issues/detail?id=4108
This test passes for me now
--
You received this message because this project is configured to send all
issue not
Comment #4 on issue 4259 by jkumme...@chromium.org: DCHECK failure:
scope_info_->StackSlotIndex(*name_handle) < 0 || is_block_scope()
https://code.google.com/p/v8/issues/detail?id=4259
#3: I included a .txt file in the .zip which should list Chrome and V8
versions. IIRC the V8 version in th
Awesome, thanks. Lgtm
https://codereview.chromium.org/1217893012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiv
Updates:
Owner: caitpott...@gmail.com
Cc: -caitpott...@gmail.com a...@chromium.org
Comment #5 on issue 3854 by a...@chromium.org: Symbol.toStringTag is added
even if disabled
https://code.google.com/p/v8/issues/detail?id=3854
(No comment was entered for this change.)
--
You r
https://codereview.chromium.org/1217893012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
lgtm
https://codereview.chromium.org/1217603005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Fixed
Comment #2 on issue 3321 by a...@chromium.org: CallSite should check for
HasLocalProperty
https://code.google.com/p/v8/issues/detail?id=3321
We changed to make all private symbols own properties so this has been
fixed.
--
You received this message because th
Updates:
Status: WontFix
Comment #2 on issue 4063 by a...@chromium.org: Class declaration in sloppy
harmony is not visible?
https://code.google.com/p/v8/issues/detail?id=4063
Works for me now
--
You received this message because this project is configured to send all
issue notifica
Updates:
Status: WontFix
Comment #2 on issue 4010 by a...@chromium.org: Harmony sloppy classes uses
wrong error on duplicate declarations
https://code.google.com/p/v8/issues/detail?id=4010
Works for me now
--
You received this message because this project is configured to send all
Status: Untriaged
Owner:
New issue 4265 by tsukumo@gmail.com: Inconsistent behavior in date parse
https://code.google.com/p/v8/issues/detail?id=4265
What steps will reproduce the problem?
1. Create date with 0s
2. Create date without 0s
3. Notice discrepancy
4. (Also fails with Date#par
https://codereview.chromium.org/1217603005/diff/1/src/runtime/runtime-function.cc
File src/runtime/runtime-function.cc (right):
https://codereview.chromium.org/1217603005/diff/1/src/runtime/runtime-function.cc#newcode448
src/runtime/runtime-function.cc:448: Handle bound_function_map =
Map::Copy(
Reviewers: Yang,
Description:
Add debug-stepnext test for for-let loops
Please review this at https://codereview.chromium.org/1215383002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -2 lines):
M test/mjsunit/es6/debug-stepnext-for.js
Index: test/mjsunit
Reviewers: Toon Verwaest,
Message:
Toon: PTAL
Jochen: FYI
Description:
Remove deprecated v8::Object::TurnOnAccessCheck() from the V8 API.
Please review this at https://codereview.chromium.org/1217893012/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+32, -221 li
https://codereview.chromium.org/1217603005/diff/1/src/runtime/runtime-function.cc
File src/runtime/runtime-function.cc (right):
https://codereview.chromium.org/1217603005/diff/1/src/runtime/runtime-function.cc#newcode448
src/runtime/runtime-function.cc:448: Handle bound_function_map =
Map::Copy(
Reviewers: adamk, Toon Verwaest,
Message:
PTAL
Description:
[es6] Function bind should preserve [[Prototype]]
The function returned from Function.prototype.bind should have the same
[[Prototype]] as the receiver.
BUG=v8:3889
LOG=N
R=ad...@chromium.org, verwa...@chromium.org
CQ_INCLUDE_TRYBOTS=
Updates:
Cc: yang...@chromium.org
Comment #3 on issue 4259 by ad...@chromium.org: DCHECK failure:
scope_info_->StackSlotIndex(*name_handle) < 0 || is_block_scope()
https://code.google.com/p/v8/issues/detail?id=4259
Do you know if your Chrome build included Yang's
https://chromium.go
Comment #3 on issue 4263 by m...@bocoup.com: Install Yaml python package
all the bots
https://code.google.com/p/v8/issues/detail?id=4263
I don't have a good reference for the motivation for monkeyYaml, which I
think is an important factor in deciding which of these two approaches is
best.
Updates:
Cc: m...@mikepennisi.com
Comment #2 on issue 4263 by a...@chromium.org: Install Yaml python package
all the bots
https://code.google.com/p/v8/issues/detail?id=4263
(No comment was entered for this change.)
--
You received this message because this project is configured to se
Comment #1 on issue 4263 by a...@chromium.org: Install Yaml python package
all the bots
https://code.google.com/p/v8/issues/detail?id=4263
Or the other way around: Always use monkeyYaml:
https://github.com/tc39/test262/pull/347
--
You received this message because this project is configur
Reviewers: jarin,
Description:
Fix bug when transferring SharedArrayBuffer to multiple Workers.
Previously, the serialization code would call Externalize for every
transferred
ArrayBuffer or SharedArrayBuffer, but that function can only be called
once. If
the buffer is already externalized,
On 2015/07/01 12:16:57, bradn wrote:
Some other type system questions:
* Should Function(R, S, T0, T1...) types be unionable with each other?
(I.e.
can
I use them to express the overloaded nature of Math.abs etc?) Some care
will
be
required at a VisitCall to disentangle which concrete ve
Patchset 3 (id:??) landed as
https://crrev.com/a5221d0779d0839055c764b88f412a0793d959b3
Cr-Commit-Position: refs/heads/master@{#29429}
https://codereview.chromium.org/1217813012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1217813012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
LGTM
https://codereview.chromium.org/1217813012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1217813012/40001
https://codereview.chromium.org/1217813012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Patchset 1 (id:??) landed as
https://crrev.com/e334410340e6ec1a7439b82705e1b65591d3062d
Cr-Commit-Position: refs/heads/master@{#29428}
https://codereview.chromium.org/1219993002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1219993002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1219993002/1
https://codereview.chromium.org/1219993002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
On 2015/07/01 17:16:49, rossberg wrote:
I'd have to check, this might have been a preparatory addition for yet
missing
class scoping checks in strong mode that Marja couldn't finish. I plan to
take
that up in a while. But I suppose we can always revert the removal later,
so
LGTM.
Sorry fo
I'd have to check, this might have been a preparatory addition for yet
missing
class scoping checks in strong mode that Marja couldn't finish. I plan to
take
that up in a while. But I suppose we can always revert the removal later, so
LGTM.
https://codereview.chromium.org/1219993002/
--
--
v
Comment #7 on issue 2589 by rom...@gmail.com: line and column property for
syntax errors
https://code.google.com/p/v8/issues/detail?id=2589
any progress on that feature?
--
You received this message because this project is configured to send all
issue notifications to this address.
You ma
Patchset 1 (id:??) landed as
https://crrev.com/c26e5144547c224db10f7b9e7cae9793ee2d87c2
Cr-Commit-Position: refs/heads/master@{#29427}
https://codereview.chromium.org/1220883006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1220883006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 3 (id:??) landed as
https://crrev.com/ffa6b5fe6c7a69915141e23dcbfb727e15611d2c
Cr-Commit-Position: refs/heads/master@{#29426}
https://codereview.chromium.org/1218553004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1218553004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1218553004/40001
https://codereview.chromium.org/1218553004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Enable TailCalls for %_CallRuntime
This involves:
- Enabling the tail call optimization reducer in all cases
- Adding an addition flag to CallFunctionParameters to mark call sites
that can be tail-called enabled.
- Only set the tail-call
Committed patchset #1 (id:1)
https://codereview.chromium.org/1221663006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/2604c75eeda875e3e95e957cd886b481c55e1d62
Cr-Commit-Position: refs/heads/master@{#29425}
https://codereview.chromium.org/1221663006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1220883006/1
https://codereview.chromium.org/1220883006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Hannes Payer,
Message:
Hannes: PTAL.
Yang: FYI.
Description:
Serializer forces flushing of optimized code map.
This makes sure that the GC fully flushes the optimized code map when
the serializer is preparing a snapshot. Otherwise closures and contexts
could end up in the startup sna
lgtm
https://codereview.chromium.org/1220883006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Message:
ptal
Description:
Remove outdated comment
BUG=
Please review this at https://codereview.chromium.org/1220883006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -1 lines):
M test/cctest/test-api-interceptors.cc
Index: test/cctes
https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker-sharedarraybuffer.js
File test/mjsunit/d8-worker-sharedarraybuffer.js (right):
https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker-sharedarraybuffer.js#newcode42
test/mjsunit/d8-worker-sharedarr
lgtm
https://codereview.chromium.org/1213683005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM with comment
https://codereview.chromium.org/1220053002/diff/1/test/cctest/test-api-interceptors.cc
File test/cctest/test-api-interceptors.cc (right):
https://codereview.chromium.org/1220053002/diff/1/test/cctest/test-api-interceptors.cc#newcode2604
test/cctest/test-api-interceptors.cc:260
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1221663006/1
https://codereview.chromium.org/1221663006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Jakob,
Message:
Committed patchset #1 (id:1) manually as
e32f9cfc10dc9b7591a12fe1621c35ff86ab9cc0.
Description:
Ensure we enable/disable the bootstrapping flag
TBR=jkumme...@chromium.org
Committed:
https://chromium.googlesource.com/v8/v8/+/e32f9cfc10dc9b7591a12fe1621c35ff86ab9cc0
P
https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc#newcode2641
src/heap/heap.cc:2641: bool hope_high_promotion_problem_will_fix_itself
=
On 2015/07/01 15:31:31, Hannes Payer
Patchset 2 (id:??) landed as
https://crrev.com/fdc5c1343cb5786fa0a21feefa34a472a64369f1
Cr-Commit-Position: refs/heads/master@{#29423}
https://codereview.chromium.org/1214903017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1214903017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Reviewers: Jakob,
Message:
Committed patchset #1 (id:1) manually as
b71fe9eed168b3fc39e860671345a5f4f6b354c5 (tree was closed).
Description:
Use is_bootstrapping everywhere
TBR=jkumme...@chromium.org
Committed:
https://chromium.googlesource.com/v8/v8/+/b71fe9eed168b3fc39e860671345a5f4f6b354c5
looking good, just naming nits
https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1217813012/diff/20001/src/heap/heap.cc#newcode2641
src/heap/heap.cc:2641: bool hope_high_promotion_problem_will_fix_itself
=
funny
PTAL - simpler approach that doesn't involve the compiler
https://codereview.chromium.org/1217813012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
Comment #26 on issue 457 by math...@qiwi.be: Implement tail call elimination
https://code.google.com/p/v8/issues/detail?id=457
http://ecma-international.org/ecma-262/6.0/#sec-tail-position-calls
--
You received this message because this project is configured to send all
issue notifications to
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1222543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/78ef2e5b29a79f87d8d1cbad692143c8fc9e6d91
Cr-Commit-Position: refs/heads/master@{#29419}
https://codereview.chromium.org/1222543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Updated comment
https://codereview.chromium.org/1214903017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving em
1 - 100 of 237 matches
Mail list logo
