Status: New
Owner:
Labels: Type-Bug Priority-Medium
New issue 4271 by rhodovan...@partner.samsung.com: Fatal error in
v8::Object::GetInternalField
https://code.google.com/p/v8/issues/detail?id=4271
Version: b0493ed
OS: Ubuntu 15.04
Architecture: x64
What steps will reproduce the problem
Comment #13 on issue 3566 by a...@chromium.org: Implement iterator close &
Generator.prototype.return
https://code.google.com/p/v8/issues/detail?id=3566
Issue 4270 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notificatio
Updates:
Status: Duplicate
Mergedinto: 3566
Comment #2 on issue 4270 by a...@chromium.org: new Map(iterable) should
close the argument iterator after a value is not Object error.
https://code.google.com/p/v8/issues/detail?id=4270
All these are using for-of loops so when for-of
Comment #1 on issue 4270 by m...@bocoup.com: new Map(iterable) should close
the argument iterator after a value is not Object error.
https://code.google.com/p/v8/issues/detail?id=4270
See Issue 3566
https://code.google.com/p/v8/issues/detail?id=3566
--
You received this message because this
Status: Untriaged
Owner:
New issue 4270 by leonardo...@gmail.com: new Map(iterable) should close the
argument iterator after a value is not Object error.
https://code.google.com/p/v8/issues/detail?id=4270
Version: V8 version 4.5.0 (candidate)
OS: Mac OS
Architecture: x64.debug
When crea
Comment #7 on issue 3953 by phistuck: Misleading error message for for-of
loop
https://code.google.com/p/v8/issues/detail?id=3953
Note that the same happens with any pure JavaScript (meaning, non DOM)
non-iterable object that a method returns.
for (var element of Date.now()) {}
Uncaught
lgtm
https://codereview.chromium.org/1213043005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Try jobs failed on following builders:
v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/7328)
v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7282)
v8_ma
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1218813012/11
https://codereview.chromium.org/1218813012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
lgtm
https://codereview.chromium.org/1218813012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Issue 4269: Debug break points should not be implemented by patching ICs
https://code.google.com/p/v8/issues/detail?id=4269
This issue is now blocking issue chromium:506876.
See https://code.google.com/p/chromium/issues/detail?id=506876
--
You received this message because you are listed in the
Reviewers: Benedikt Meurer,
Description:
[turbofan] Fix bogus materialization from frame with OSR.
The context constant cannot be materialized from the frame when we are
compiling for OSR, because the context spill slot contains the current
instead of the outermost context in full-codegen.
R=bm
lgtm with suggestions:
https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc#newcode1002
src/elements.cc:1002: if (obj->elements() != *store) {
It looks like you can do the same t
Comment #6 on issue 4184 by bugdro...@chromium.org: Significant portion of
Blink test runtime is spent in creating/configuring
ObjectTemplates/FunctionTemplates
https://code.google.com/p/v8/issues/detail?id=4184#c6
The following revision refers to this bug:
https://chromium.googlesource
Patchset 3 (id:??) landed as
https://crrev.com/b0493ed16c0b363a0e92bf4a790d4fd851c74e70
Cr-Commit-Position: refs/heads/master@{#29468}
https://codereview.chromium.org/1218403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1218403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1218403002/40001
https://codereview.chromium.org/1218403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Reviewers: jochen,
https://codereview.chromium.org/1209403005/diff/1/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/1209403005/diff/1/src/global-handles.cc#newcode525
src/global-handles.cc:525: };
On 2015/07/03 at 12:42:27, jochen wrote:
nit. DISALLOW
lgtm
https://codereview.chromium.org/1218403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1215233004/diff/40001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1215233004/diff/40001/src/d8.cc#newcode1542
src/d8.cc:1542: if (contents.Data()) {
how can data ever be null?
https://codereview.chromium.org/1215233004/
--
--
v8-dev mailing
Addressed comments
https://codereview.chromium.org/1218403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
lgtm with a nit and suggestion:
https://codereview.chromium.org/1218403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
lgtm with a nit and suggestion:
https://codereview.chromium.org/1218403002/diff/1/src/api-natives.cc
File src/api-natives.cc (right):
https://codereview.chromium.org/1218403002/diff/1/src/api-natives.cc#newcode150
src/api-natives.cc:150: PropertyKind kind = length == 3 ? kData :
kAccessor;
Inst
Reviewers: ulan,
Message:
Design doc here:
https://docs.google.com/document/d/1UfpzkLuLqVy6QfaYYbhXeR0_mT53Qg7UXf3E-TvNVEo/edit#heading=h.o3qhv46e0ele
Description:
Debugger: use debug break slots instead of ICs (except for calls).
BUG=v8:3147,v8:4269
LOG=N
Please review this at https://coderev
Committed patchset #1 (id:1) manually as
d30aacbd824b9a10afc352417c70e2ea3004cd68.
https://codereview.chromium.org/183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
lgtm
https://codereview.chromium.org/183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
Reviewers: Jakob,
Description:
Version 4.4.63.13 (cherry-pick)
Merged 448ec36491a33111642470ad8b78e99ce3cf1975
MIPS: Fix unpredictable random failures after direct api function call.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/183002/
Base URL: htt
Committed patchset #1 (id:1) manually as
27ae9dbcd35062ebe8ac6b8a3ad860f4964448d1.
https://codereview.chromium.org/1215143008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
lgtm
https://codereview.chromium.org/1215143008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
Version 4.3.61.34 (cherry-pick)
Merged 448ec36491a33111642470ad8b78e99ce3cf1975
MIPS: Fix unpredictable random failures after direct api function call.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1215143008/
Base URL: htt
https://codereview.chromium.org/1215143008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
I'll delete and reupload this CL (I've created the merge branch with a wrong
account and therefore I cannot land this..).
https://codereview.chromium.org/1223663003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
PTAL.
https://codereview.chromium.org/1223663003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1223663003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
Version 4.3.61.34 (cherry-pick)
Merged 448ec36491a33111642470ad8b78e99ce3cf1975
MIPS: Fix unpredictable random failures after direct api function call.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1223663003/
Base URL: htt
On 2015/07/03 13:00:13, Hannes Payer wrote:
lgtm
Thanks for the heads-up. Let's ship this after branching. The current
Canary is
to crashy ATM.
https://codereview.chromium.org/1217863006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You recei
Reviewers: titzer, Benedikt Meurer,
Message:
Ben: PTAL.
Benedikt: FYI.
Description:
[turbofan] Use OSR value for innermost context value.
This changes the OsrValue insertion in the AstGraphBuilder to emit a
proper OsrValue instead of a special Parameter for the inner context
value at the OSR en
lgtm
https://codereview.chromium.org/1217863006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Owner: yang...@chromium.org
Blockedon: v8:4269
Comment #2 on issue 3147 by yang...@chromium.org: Incorrect position
reporting for calls
https://code.google.com/p/v8/issues/detail?id=3147
(No comment was entered for this change.)
--
You received this message because t
Issue 4269: Debug break points should not be implemented by patching ICs
https://code.google.com/p/v8/issues/detail?id=4269
This issue is now blocking issue v8:3147.
See https://code.google.com/p/v8/issues/detail?id=3147
--
You received this message because you are listed in the owner
or CC fiel
Updates:
Labels: -Type-Bug Type-FeatureRequest
Comment #1 on issue 4269 by yang...@chromium.org: Debug break points should
not be implemented by patching ICs
https://code.google.com/p/v8/issues/detail?id=4269
(No comment was entered for this change.)
--
You received this message beca
Status: Assigned
Owner: yang...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 4269 by yang...@chromium.org: Debug break points should not be
implemented by patching ICs
https://code.google.com/p/v8/issues/detail?id=4269
In order to set a debug break point in a function, we have thre
https://codereview.chromium.org/1209403005/diff/1/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/1209403005/diff/1/src/global-handles.cc#newcode525
src/global-handles.cc:525: };
nit. DISALLOW_COPY_AND_ASSIGN(PendingPhantomCallbacksSecondPassTask)
https
Patchset 1 (id:??) landed as
https://crrev.com/e7d64b3f60a59f1e2dfef32a5ed245105fa3d3b9
Cr-Commit-Position: refs/heads/master@{#29467}
https://codereview.chromium.org/1224533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Comment #48 on issue 4137 by bugdro...@chromium.org: Support elements in
the LookupIterator
https://code.google.com/p/v8/issues/detail?id=4137#c48
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/e7d64b3f60a59f1e2dfef32a5ed245105fa3d3b9
commit e7d
Committed patchset #1 (id:1)
https://codereview.chromium.org/1224533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1225573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 4 (id:??) landed as
https://crrev.com/4621210cfed738b8171b075f816f0c7329489c9d
Cr-Commit-Position: refs/heads/master@{#29466}
https://codereview.chromium.org/1225573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1225573002/60001
https://codereview.chromium.org/1225573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Comment #5 on issue 4184 by verwa...@chromium.org: Significant portion of
Blink test runtime is spent in creating/configuring
ObjectTemplates/FunctionTemplates
https://code.google.com/p/v8/issues/detail?id=4184
Although no, it wasn't quadratic before due to overallocating. It'll reduce
th
Comment #4 on issue 4184 by verwa...@chromium.org: Significant portion of
Blink test runtime is spent in creating/configuring
ObjectTemplates/FunctionTemplates
https://code.google.com/p/v8/issues/detail?id=4184
Added a speedup to https://codereview.chromium.org/1218403002/
That now preallo
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1224533003/1
https://codereview.chromium.org/1224533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Try jobs failed on following builders:
v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7272)
(exceeded global retry quota)
https://codereview.chromium.org/1225573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://group
Committed patchset #1 (id:1)
https://codereview.chromium.org/1213803008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/5f288c201c37375ffe442f6e31ca6a4f36c3496f
Cr-Commit-Position: refs/heads/master@{#29465}
https://codereview.chromium.org/1213803008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Reviewers: Igor Sheludko,
Message:
ptal
Should probably first create the map and afterwards the instance in
api-natives.cc, but this will do for now.
Description:
Increment descriptor array slack for prototypes by a constant rather than
50%
Additionally speed up instantiation of ObjectTemplat
lgtm
https://codereview.chromium.org/1224533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1225573002/60001
https://codereview.chromium.org/1225573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc#newcode421
src/deoptimizer.cc:421: code->address() + Code::kHeaderSize,
code->address() + code->Size());
On 2015/07/0
LGTM. I like it.
https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1225573002/diff/40001/src/deoptimizer.cc#newcode421
src/deoptimizer.cc:421: code->address() + Code::kHeaderSize,
code->address() + code->Siz
Updates:
Owner: yang...@chromium.org
Comment #2 on issue 4268 by yang...@chromium.org: getEvalOrigin already
rendered in violation of spec
https://code.google.com/p/v8/issues/detail?id=4268
(No comment was entered for this change.)
--
You received this message because this project is
Updates:
Status: Fixed
Comment #3 on issue 4127 by yang...@chromium.org:
mjsunit/deserialize-script-id turned flaky on V8 Win32 - nosnap - shared
https://code.google.com/p/v8/issues/detail?id=4127
(No comment was entered for this change.)
--
You received this message because this pro
Comment #2 on issue 4127 by bugdro...@chromium.org:
mjsunit/deserialize-script-id turned flaky on V8 Win32 - nosnap - shared
https://code.google.com/p/v8/issues/detail?id=4127#c2
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/787de93f4cb5026cd4ebc
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1215123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/787de93f4cb5026cd4ebc120e70a15710164496d
Cr-Commit-Position: refs/heads/master@{#29464}
https://codereview.chromium.org/1215123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Updates:
Status: Available
Cc: yang...@chromium.org
Labels: Priority-Medium Area-API Type-Bug
Comment #1 on issue 4268 by habl...@chromium.org: getEvalOrigin already
rendered in violation of spec
https://code.google.com/p/v8/issues/detail?id=4268
(No comment was entere
After discussing offline, we should just remove slots after the code object
header. I will do that.
https://codereview.chromium.org/1225573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1213803008/1
https://codereview.chromium.org/1213803008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/1213803008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
https://codereview.chromium.org/1225573002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1225573002/diff/1/src/deoptimizer.cc#newcode422
src/deoptimizer.cc:422: // again that point to objects on evacuation
candidates.
O
Hey Jaro,
The fix for the simplified lowering bug that popped up today.
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1213803008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Reviewers: jarin,
Description:
[turbofan] Right hand side of shifts needs ToUint32.
Currently we lower shifts directly to machine operators, and add an
appropriate Word32And to implement the & 0x1F operation on the right
hand side required by the specification. However for Word32And we assume
In
LGTM.
https://codereview.chromium.org/1225573002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1225573002/diff/1/src/deoptimizer.cc#newcode422
src/deoptimizer.cc:422: // again that point to objects on evacuation
candidates.
nit: Let's add to the comm
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1215123002/20001
https://codereview.chromium.org/1215123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Patchset 2 (id:??) landed as
https://crrev.com/619570b3ddff5f538158f6dd542018f26b47c289
Cr-Commit-Position: refs/heads/master@{#29463}
https://codereview.chromium.org/1217673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1217673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Reviewers: Hannes Payer, Hablich,
Message:
Michael: This has the chance to bust a Canary because of bad interaction
with
the GC. We should time this CL so that it doesn't overlap with other risky
features being shipped (most likely after the branch point).
Hannes: PTAL.
Description:
Activate
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1217673003/20001
https://codereview.chromium.org/1217673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
lgtm, thanks!
https://codereview.chromium.org/1217673003/diff/20001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/1217673003/diff/20001/src/arm/assembler-arm.cc#newcode3801
src/arm/assembler-arm.cc:3801: entry.set_merged_index(j);
On 2015/07/03
https://codereview.chromium.org/1221103003/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1221103003/diff/20001/src/compiler/ast-graph-builder.cc#newcode4081
src/compiler/ast-graph-builder.cc:4081: // TODO(titzer): use
https://codereview.chromium.org/1217673003/diff/20001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/1217673003/diff/20001/src/arm/assembler-arm.cc#newcode3801
src/arm/assembler-arm.cc:3801: entry.set_merged_index(j);
On 2015/07/03 08:58:04, rmcil
I decided against sorting, since I have no idea what implications that
would
have wrt const pool entries that are marked as not sharing_ok.
Yes I would avoid this for now - I'm not sure how it would interact with ldr
range for entries which are reordered.
https://codereview.chromium.org/1217
I decided against sorting, since I have no idea what implications that
would
have wrt const pool entries that are marked as not sharing_ok.
Yes I would avoid this for now - I'm not sure how it would interact with ldr
range for entries which are reordered.
https://codereview.chromium.org/1217
Patchset 1 (id:??) landed as
https://crrev.com/84f0a33ce0020f16514b8c01ff2bbe8b027e027e
Cr-Commit-Position: refs/heads/master@{#29461}
https://codereview.chromium.org/1215063007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1215063007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1215063007/1
https://codereview.chromium.org/1215063007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
On 2015/07/02 17:04:59, Yang wrote:
On 2015/07/02 15:15:08, rmcilroy wrote:
> On 2015/07/02 14:29:02, Yang wrote:
> > On 2015/07/02 14:25:18, Yang wrote:
> > > On 2015/07/02 13:59:48, rmcilroy wrote:
> > > >
https://codereview.chromium.org/1217673003/diff/1/src/arm/assembler-arm.cc
> > > > File s
88 matches
Mail list logo
