[v8-dev] Re: Implement tracing interface for v8 (issue 988893003 by fmea...@chromium.org)

2015-07-05 Thread yurys
+caseq https://codereview.chromium.org/988893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Remove usage of to-be-deprecated APIs from tools (issue 1217123004 by joc...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217123004/1 https://codereview.chromium.org/1217123004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Remove usage of to-be-deprecated APIs from tools (issue 1217123004 by joc...@chromium.org)

2015-07-05 Thread bmeurer
LGTM (rubber-stamped) https://codereview.chromium.org/1217123004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiv

[v8-dev] Re: Make v8::Handle as "deprecated soon" (issue 1224623004 by joc...@chromium.org)

2015-07-05 Thread bmeurer
LGTM (rubber-stamped) https://codereview.chromium.org/1224623004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiv

[v8-dev] Re: Make v8::Handle as "deprecated soon" (issue 1224623004 by joc...@chromium.org)

2015-07-05 Thread jochen
mechanical replacement of v8::Handle with v8::Local https://codereview.chromium.org/1224623004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe f

[v8-dev] Make v8::Handle as "deprecated soon" (issue 1224623004 by joc...@chromium.org)

2015-07-05 Thread joc...@chromium.org via codereview.chromium.org
Reviewers: Benedikt Meurer, Description: Make v8::Handle as "deprecated soon" BUG=v8:4131 R=bmeu...@chromium.org LOG=n Please review this at https://codereview.chromium.org/1224623004/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+616, -669 lines): M include/

[v8-dev] Re: Fix bug when transferring SharedArrayBuffer to multiple Workers. (issue 1215233004 by bi...@chromium.org)

2015-07-05 Thread binji
if the current approach leaks memory, lsan bots will be unhappy, so we'll have to fix that soonish. Well, AFAIK it doesn't leak memory. It just doesn't free the SAB memory until the d8 shell is destroyed, rather than when there are no remaining references to the SAB. https://codereview.c

[v8-dev] Re: Fix bug when transferring SharedArrayBuffer to multiple Workers. (issue 1215233004 by bi...@chromium.org)

2015-07-05 Thread jochen
On 2015/07/06 at 06:23:27, binji wrote: https://codereview.chromium.org/1215233004/diff/40001/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/1215233004/diff/40001/src/d8.cc#newcode1542 src/d8.cc:1542: if (contents.Data()) { On 2015/07/06 at 05:04:19, jarin wrote: > On 2015/0

[v8-dev] Remove usage of to-be-deprecated APIs from tools (issue 1217123004 by joc...@chromium.org)

2015-07-05 Thread joc...@chromium.org via codereview.chromium.org
Reviewers: Benedikt Meurer, Description: Remove usage of to-be-deprecated APIs from tools BUG=v8:4134 R=bmeu...@chromium.org LOG=n Please review this at https://codereview.chromium.org/1217123004/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+15, -8 lines): M

[v8-dev] Re: Fix bug when transferring SharedArrayBuffer to multiple Workers. (issue 1215233004 by bi...@chromium.org)

2015-07-05 Thread binji
https://codereview.chromium.org/1215233004/diff/40001/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/1215233004/diff/40001/src/d8.cc#newcode1542 src/d8.cc:1542: if (contents.Data()) { On 2015/07/06 at 05:04:19, jarin wrote: On 2015/07/03 14:29:37, jochen wrote: > how can data

[v8-dev] Fix cluster-fuzz found regression with d8 Workers (issue 1220193004 by bi...@chromium.org)

2015-07-05 Thread binji
Reviewers: jarin, Description: Fix cluster-fuzz found regression with d8 Workers This one occurred when serializing an object. When the property getter threw an exception, that value was skipped, but the property count wasn't updated. The deserializer then tried to deserialize the wrong val

[v8-dev] Re: Fix bug when transferring SharedArrayBuffer to multiple Workers. (issue 1215233004 by bi...@chromium.org)

2015-07-05 Thread jarin
lgtm. (Even though at some point we might want to implement reference counting for shared array buffer contents because the current approach leaks memory.) https://codereview.chromium.org/1215233004/diff/40001/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/1215233004/diff/40

[v8-dev] Re: [turbofan] Fix bogus materialization from frame with OSR. (issue 1220013003 by mstarzin...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/b8ecd94c7212e1d2ff7b85e2d02d5c8c0aed4161 Cr-Commit-Position: refs/heads/master@{#29472} https://codereview.chromium.org/1220013003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [turbofan] Fix bogus materialization from frame with OSR. (issue 1220013003 by mstarzin...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1220013003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [turbofan] Use OSR value for innermost context value. (issue 1213043005 by mstarzin...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1213043005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [turbofan] Use OSR value for innermost context value. (issue 1213043005 by mstarzin...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/21d330c89610d1ecd1419566f5cfcce1d7eee5fa Cr-Commit-Position: refs/heads/master@{#29471} https://codereview.chromium.org/1213043005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: X87: [turbofan] Enable tail calls for %_CallRuntime. (issue 1228463003 by chunyang....@intel.com)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/7404) https://codereview.chromium.org/1228463003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -

[v8-dev] Re: [turbofan] Fix bogus materialization from frame with OSR. (issue 1220013003 by mstarzin...@chromium.org)

2015-07-05 Thread bmeurer
LGTM. Thanks for fixing. https://codereview.chromium.org/1220013003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop rec

[v8-dev] Re: [turbofan] Fix bogus materialization from frame with OSR. (issue 1220013003 by mstarzin...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220013003/20001 https://codereview.chromium.org/1220013003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: [turbofan] Use OSR value for innermost context value. (issue 1213043005 by mstarzin...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213043005/1 https://codereview.chromium.org/1213043005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: [turbofan] Use OSR value for innermost context value. (issue 1213043005 by mstarzin...@chromium.org)

2015-07-05 Thread bmeurer
lgtm https://codereview.chromium.org/1213043005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Enable tail calls for %_CallRuntime. (issue 1228463003 by chunyang....@intel.com)

2015-07-05 Thread weiliang . lin
lgtm https://codereview.chromium.org/1228463003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Enable tail calls for %_CallRuntime. (issue 1228463003 by chunyang....@intel.com)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228463003/1 https://codereview.chromium.org/1228463003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] X87: [turbofan] Enable tail calls for %_CallRuntime. (issue 1228463003 by chunyang....@intel.com)

2015-07-05 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: [turbofan] Enable tail calls for %_CallRuntime. port 1fa4285e1ce16cfadf8c40a0993491ec4e2bbbe0 (r29436). original commit message: This involves: - Enabling the tail call optimization reducer in all cases. - Adding an addition fl

[v8-dev] Re: Issue 4192 in v8: 'Hello World' sample segfaults on x64 linux

2015-07-05 Thread codesite-noreply via v8-dev
Comment #12 on issue 4192 by zareg...@gmail.com: 'Hello World' sample segfaults on x64 linux https://code.google.com/p/v8/issues/detail?id=4192 Building with snapshots=off is an acceptable workaround for me, for now. Thanks Daniel. -- You received this message because this project is conf

[v8-dev] Re: Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1226703002 by machenb...@chromium.org)

2015-07-05 Thread machenbach
On 2015/07/05 18:19:15, commit-bot: I haz the power wrote: Patchset 1 (id:??) landed as https://crrev.com/269918927a54cd1533ef4e3318dd76b3747762b5 Cr-Commit-Position: refs/heads/master@{#29470} The revert helped. The new roll goes through: https://codereview.chromium.org/1222743002/ Please run

[v8-dev] Re: Version 4.5.95.1 (cherry-pick) (issue 1214813004 by machenb...@chromium.org)

2015-07-05 Thread machenb...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) manually as 71ee0a55128ba504f9f5c582c60b1ae191fa88b0. https://codereview.chromium.org/1214813004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v

[v8-dev] Version 4.5.95.1 (cherry-pick) (issue 1214813004 by machenb...@chromium.org)

2015-07-05 Thread machenb...@chromium.org via codereview.chromium.org
Reviewers: ulan, Description: Version 4.5.95.1 (cherry-pick) Merged 435b3c873ac3b58fb56a1b7292951810c93ceda5 Merged 269918927a54cd1533ef4e3318dd76b3747762b5 Revert of Make ARM compiler happy after 0ecd9e1bd (patchset #1 id:1 of https://codereview.chromium.org/1219863003/) Revert of Replace red

[v8-dev] Re: Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1226703002 by machenb...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/269918927a54cd1533ef4e3318dd76b3747762b5 Cr-Commit-Position: refs/heads/master@{#29470} https://codereview.chromium.org/1226703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1226703002 by machenb...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1226703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Make ARM compiler happy after 0ecd9e1bd (issue 1221303002 by machenb...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/435b3c873ac3b58fb56a1b7292951810c93ceda5 Cr-Commit-Position: refs/heads/master@{#29469} https://codereview.chromium.org/1221303002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Revert of Make ARM compiler happy after 0ecd9e1bd (issue 1221303002 by machenb...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1221303002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Revert of Make ARM compiler happy after 0ecd9e1bd (issue 1221303002 by machenb...@chromium.org)

2015-07-05 Thread machenbach
Reviewers: ulan, Message: Created Revert of Make ARM compiler happy after 0ecd9e1bd Description: Revert of Make ARM compiler happy after 0ecd9e1bd (patchset #1 id:1 of https://codereview.chromium.org/1219863003/) Reason for revert: Revert in order to revert 0ecd9e1bd Original issue's descripti

[v8-dev] Re: Revert of Make ARM compiler happy after 0ecd9e1bd (issue 1221303002 by machenb...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221303002/1 https://codereview.chromium.org/1221303002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1226703002 by machenb...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226703002/1 https://codereview.chromium.org/1226703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Make ARM compiler happy after 0ecd9e1bd (issue 1219863003 by u...@chromium.org)

2015-07-05 Thread machenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1221303002/ by machenb...@chromium.org. The reason for reverting is: Revert in order to revert 0ecd9e1bd. https://codereview.chromium.org/1219863003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

2015-07-05 Thread machenbach
A revert of this CL (patchset #17 id:320001) has been created in https://codereview.chromium.org/1226703002/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Looks like it blocks the roll (bisected). Speculative revert. https://codereview.chromium.org/1210293003/. https://co

[v8-dev] Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1226703002 by machenb...@chromium.org)

2015-07-05 Thread machenbach
Reviewers: Hannes Payer, ulan, Message: Created Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. Description: Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. (patchset #17 id:320001 of https://codereview.chromium.org/12

[v8-dev] Re: Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1226703002 by machenb...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226703002/1 https://codereview.chromium.org/1226703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Revert of Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1226703002 by machenb...@chromium.org)

2015-07-05 Thread commit-...@chromium.org via codereview.chromium.org
Failed to apply patch for src/heap/heap.cc: While running git apply --index -3 -p1; error: patch failed: src/heap/heap.cc:926 error: repository lacks the necessary blob to fall back on 3-way merge. error: src/heap/heap.cc: patch does not apply Patch: src/heap/heap.cc Index: src/heap/h