Comment #5 on issue 3619 by mari...@medikoo.com: Incorrect string
representation of types introduced with ES6
https://code.google.com/p/v8/issues/detail?id=3619
Is it already in Chrome or Canary?
At this point in both Chrome and Canary we still have:
Object.prototype.toString.call(WeakMap.p
Status: Untriaged
Owner:
New issue 4290 by nagavelp...@gmail.com: Could not clear cache while using
c++ api
https://code.google.com/p/v8/issues/detail?id=4290
Version: 1.0
OS: Ubuntu 12.04
Architecture:
What steps will reproduce the problem?
1. Compile a script, use mulithread to execu
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1220283009/20001
https://codereview.chromium.org/1220283009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Comment #4 on issue 4289 by ad...@chromium.org: Array.prototype.concat's
[[Get]] of @@isConcatSpreadable fails when combined with cross-origin
security checks
https://code.google.com/p/v8/issues/detail?id=4289
Looks like we're going to need similar logic for @@hasInstance, otherwise
someOt
Updates:
Cc: verwa...@chromium.org joc...@chromium.org
Comment #3 on issue 4289 by ad...@chromium.org: Array.prototype.concat's
[[Get]] of @@isConcatSpreadable fails when combined with cross-origin
security checks
https://code.google.com/p/v8/issues/detail?id=4289
[ccing a couple fo
Comment #2 on issue 4289 by caitpott...@gmail.com: Array.prototype.concat's
[[Get]] of @@isConcatSpreadable fails when combined with cross-origin
security checks
https://code.google.com/p/v8/issues/detail?id=4289
do we have a way to perform the get without invoking the access check
callba
Comment #1 on issue 4289 by ad...@chromium.org: Array.prototype.concat's
[[Get]] of @@isConcatSpreadable fails when combined with cross-origin
security checks
https://code.google.com/p/v8/issues/detail?id=4289
The most straightforward fix would be to treat "needs access check" as a
bailou
Updates:
Cc: ad...@chromium.org verwa...@chromium.org
Comment #2 on issue 4177 by ad...@chromium.org: Arguments object property
descriptor errors
https://code.google.com/p/v8/issues/detail?id=4177
Strangely it looks like this should be properly handled in
SlowSloppyArgumentsElements
Status: Assigned
Owner: caitpott...@gmail.com
CC: little...@chromium.org, a...@chromium.org, rossb...@chromium.org
Labels: Type-Bug Priority-Medium Area-Language
New issue 4289 by ad...@chromium.org: Array.prototype.concat's [[Get]] of
@@isConcatSpreadable fails when combined with cross-origi
https://codereview.chromium.org/1219943002/diff/230001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1219943002/diff/230001/src/bootstrapper.cc#newcode1317
src/bootstrapper.cc:1317: {
On 2015/07/09 00:23:17, Dan Ehrenberg wrote:
Looks like this code runs
Reviewers: arv,
Description:
Fix uses of eval() with non-string arguments under nosnap/--use-strict
When running without a snapshot, the GlobalEval function gets lazy compiled.
By the time we compile it, its name is "eval", which causes the parser to
choke (functions named "eval" aren't allowed
Comment #11 on issue 4014 by gok...@google.com: ES6 Map performance issues
https://code.google.com/p/v8/issues/detail?id=4014
I found it from Google cache:
http://webcache.googleusercontent.com/search?q=cache:CRrAj8MOtxAJ:https://jsperf.com/gwt-es6-map-vs-object-properties/3+&cd=1&hl=en&ct=clnk
https://codereview.chromium.org/1219943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
https://codereview.chromium.org/1219943002/diff/230001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1219943002/diff/230001/src/bootstrapper.cc#newcode1317
src/bootstrapper.cc:1317: {
Looks like this code runs regardless of --harmony_simd
https://coderevi
Reviewers: jarin,
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc
File src/d8.cc (left):
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc#oldcode2146
src/d8.cc:2146: static char s_buffer[128];
I'm pretty ashamed of this one... :-|
Description:
d8: Fix some TSAN bugs
* F
https://codereview.chromium.org/1214733013/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (right):
https://codereview.chromium.org/1214733013/diff/1/src/runtime/runtime-scopes.cc#newcode1034
src/runtime/runtime-scopes.cc:1034: }
Looks like this is called by FullCodeGen.
Updates:
Status: Started
Owner: ad...@chromium.org
Cc: a...@chromium.org
Comment #1 on issue 4198 by ad...@chromium.org: eval is not working
correctly in strict mode with nosnap
https://code.google.com/p/v8/issues/detail?id=4198
Investigating. It looks like the issue i
lgtm
https://codereview.chromium.org/1226103002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1226103002/diff/40001/src/preparser.h#newcode3769
src/preparser.h:3769: if (is_strict(language_mode()) ||
allow_harmony_sloppy()) {
A tangent, but it looks
lgtm
lgtm
https://codereview.chromium.org/1227523003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Comment #10 on issue 4014 by ad...@chromium.org: ES6 Map performance issues
https://code.google.com/p/v8/issues/detail?id=4014
Unfortunately the jsperf links above are currently unavailable (jsperf.com
is down). Can you re-state on this bug what pattern you see a 2x perf hit
with?
--
You r
Patchset 6 (id:??) landed as
https://crrev.com/a415f594585cb16cd1b4067cab905ddab61c6e5b
Cr-Commit-Position: refs/heads/master@{#29545}
https://codereview.chromium.org/1226063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #6 (id:11)
https://codereview.chromium.org/1226063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
https://codereview.chromium.org/1219943002/diff/170001/test/mjsunit/harmony/simd.js
File test/mjsunit/harmony/simd.js (right):
https://codereview.chromium.org/1219943002/diff/170001/test/mjsunit/harmony/simd.js#newcode207
test/mjsunit/harmony/simd.js:207: assertFalse(SIMD.float32x4(1, 2, 3,
NaN)
Patchset 1 (id:??) landed as
https://crrev.com/54572281e9be581b1a4112a7db22b9b7730c18fc
Cr-Commit-Position: refs/heads/master@{#29544}
https://codereview.chromium.org/1224083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1224083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Michael Starzinger, jarin, Benedikt Meurer,
Message:
Created Revert of [turbofan] Optimize string "length" property access based
on
types.
Description:
Revert of [turbofan] Optimize string "length" property access based on
types.
(patchset #2 id:20001 of https://codereview.chrom
Reviewers: Dan Ehrenberg, rossberg,
Message:
PTAL
Description:
[es6] Handle conflicts for sloppy let
We have to call CheckConflictingVarDeclarations in case we have enabled
--harmony-sloppy
BUG=v8:4287
LOG=N
R=little...@chromium.org, rossb...@chromium.org
Please review this at https://coderev
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1224083002/1
https://codereview.chromium.org/1224083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1224083002/ by ad...@chromium.org.
The reason for reverting is: Causes crash when running
benchmarks/octane/regexp.js on ARM:
http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2492/steps/Be
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1226063002/11
https://codereview.chromium.org/1226063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
On 2015/07/08 21:15:48, adamk wrote:
One more thought (sorry for the extra back-and-forth): what if we leave
this
staged? That'll let us continue to pass any test262 tests that exercise
it.
Done
https://codereview.chromium.org/1226063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
h
One more thought (sorry for the extra back-and-forth): what if we leave this
staged? That'll let us continue to pass any test262 tests that exercise it.
https://codereview.chromium.org/1226063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You re
On 2015/07/08 21:09:56, caitp wrote:
On 2015/07/08 21:01:55, Dan Ehrenberg wrote:
What specifically breaks WRT isConcatSpreadable? Iirc we have confidence
there's
no missing AC security issue, and it should be pretty close to spec. I'll
take
a
look in a little bit
I have no idea. Unless
On 2015/07/08 21:09:56, caitp wrote:
On 2015/07/08 21:01:55, Dan Ehrenberg wrote:
What specifically breaks WRT isConcatSpreadable? Iirc we have confidence
there's
no missing AC security issue, and it should be pretty close to spec. I'll
take
a
look in a little bit
I have no idea. Unless
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1226063002/80001
https://codereview.chromium.org/1226063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
https://codereview.chromium.org/1226063002/diff/20001/src/harmony-concat-spreadable.js
File src/harmony-concat-spreadable.js (right):
https://codereview.chromium.org/1226063002/diff/20001/src/harmony-concat-spreadable.js#newcode12
src/harmony-concat-spreadable.js:12: // TODO(dslomov, caitp): Mov
On 2015/07/08 21:01:55, Dan Ehrenberg wrote:
What specifically breaks WRT isConcatSpreadable? Iirc we have confidence
there's
no missing AC security issue, and it should be pretty close to spec. I'll
take a
look in a little bit
https://codereview.chromium.org/1226063002/
--
--
v8-dev maili
Code lgtm, but you'll need to add the --harmony-concat-spreadable flag to
test/mjsunit/harmony/array-concat.js
https://codereview.chromium.org/1226063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
We'll miss you!
lgtm, but hold onto this as long as you'd like.
https://codereview.chromium.org/1208423016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Reviewers: adamk,
Description:
Guard @@isConcatSpreadable behind a flag
The breakage to Chrome seems to be based on @@isConcatSpreadable
and turning that part off with this patch fixes the Maps Tips & Tricks
test case.
BUG=chromium:507553
LOG=Y
R=adamk
Please review this at https://codereview.
I separated out the rebase. Sorry, I didn't realize there was so much churn.
I also uploaded a reworked simd.js value-type test file in response to some
comments dehrenberg made, that were unfortunately lost when I re-uploaded.
PTAL
https://codereview.chromium.org/1219943002/
--
--
v8-dev mail
Comment #2 on issue 4287 by a...@chromium.org: Variable conflicts not
correct for sloppy let/const
https://code.google.com/p/v8/issues/detail?id=4287
Simplified test:
function f() {
{
let x;
var x;
}
}
f();
Throws as expected with --use-strict but does not throw with
--harmon
Please take another look
https://codereview.chromium.org/1213203007/diff/220001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1213203007/diff/220001/src/bootstrapper.cc#newcode1106
src/bootstrapper.cc:1106:
On 2015/07/08 08:32:53, Yang wrote:
Do you real
Reviewers: Benedikt Meurer, jarin,
Description:
Unit tests for the live range conflict detection mechanism
(CoalescedLiveRanges)
in the Greedy Allocator.
Consolidated conflict detection and traversal logic in CoalescedLiveRanges
to
avoid duplication in both code and testing. In addition, th
Reviewers: adamk, rossberg,
Message:
One more. Same story here... I hope to get some more fixes in before the
time is
due.
Description:
Remove arv from owners
Goodbyes are not forever.
Goodbyes are not the end.
They simply mean I’ll miss you
Until we meet again!
~Author Unknown
BUG=N
LOG=N
Status: Assigned
Owner: little...@chromium.org
CC: a...@chromium.org, rossb...@chromium.org
Labels: Type-Bug Priority-Medium HW-All OS-All Area-Language Harmony
New issue 4288 by a...@chromium.org: Lexical bindings in eval should not
escape
https://code.google.com/p/v8/issues/detail?id=4288
Status: Assigned
Owner: little...@chromium.org
CC: a...@chromium.org, rossb...@chromium.org
Labels: Type-Bug Priority-Medium HW-All OS-All Area-Language Harmony
New issue 4287 by a...@chromium.org: Variable conflicts not correct for
sloppy let/const
https://code.google.com/p/v8/issues/detail?
Reviewers: Dan Ehrenberg, rossberg,
Message:
PTAL
Description:
[es6] Enforce TDZ checks for let/const in StoreLookupSlot
With --harmony-sloppy we can get to a runtime store in the presence of
an eval. We therefor need to check that the value is not the hole which
is used to enforce TDZ.
BUG=v8
LGTM. I love it!
https://codereview.chromium.org/1213623020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving e
Patchset 2 (id:??) landed as
https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40
Cr-Commit-Position: refs/heads/master@{#29543}
https://codereview.chromium.org/1216593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1216593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/0640e295770c4831cd79b197e26e78a1eb3840b3
Cr-Commit-Position: refs/heads/master@{#29542}
https://codereview.chromium.org/1207253003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
LGTM from my side.
https://codereview.chromium.org/1224793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Committed patchset #1 (id:1)
https://codereview.chromium.org/1207253003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1230473006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1216593003/20001
https://codereview.chromium.org/1216593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1207253003/1
https://codereview.chromium.org/1207253003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/1207253003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno, dstence, michael_dawson,
Description:
PPC: Add unoptimized/optimized variants of MathFloor TF code stub
Port 8f13b655b8a10dae2116dd18b32f09337bb2d410
Original commit message:
- Add a TurboFanIC class, derived from TurboFanCodeStub, that
automatically distinguishes be
Just a drive-by, I'll leave the rest to Jaro.
https://codereview.chromium.org/1208933006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from th
https://codereview.chromium.org/1208933006/diff/140001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1208933006/diff/140001/src/flag-definitions.h#newcode197
src/flag-definitions.h:197: V(harmony_futex, "harmony futex")
\
On 2015/07/
LGTM
https://codereview.chromium.org/1214503009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1220193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/54920cd2f08549130e363b5bc801424a8eecc7d2
Cr-Commit-Position: refs/heads/master@{#29541}
https://codereview.chromium.org/1220193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
https://codereview.chromium.org/1208933006/diff/140001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1208933006/diff/140001/src/flag-definitions.h#newcode197
src/flag-definitions.h:197: V(harmony_futex, "harmony futex")
\
This flag s
Reviewers: jarin,
Message:
PTAL, the bots are failing because this CL depends on
https://codereview.chromium.org/1223813008.
Description:
Atomics Futex API
BUG=chromium:497295
R=ja...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/1208933006/
Base URL: https://chromi
Reviewers: danno, Hannes Payer, mtbrandyberry, michael_dawson, Sven Panne,
Description:
PPC: perf enhancement: Use larger heap page size on PPC.
Revisit of https://codereview.chromium.org/910333004.
Use 4MB heap page size over the default of 1MB.
This change provides an improvement of 1.86% on
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1220193004/20001
https://codereview.chromium.org/1220193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Reviewers: arv,
Description:
Version 4.4.63.15 (cherry-pick)
Merge back fix for 490506/493566 to 4.4
R=a...@chromium.org
BUG=chromium:490506
LOG=n
Please review this at https://codereview.chromium.org/1214503009/
Base URL: https://chromium.googlesource.com/v8/v8.git@4.4
Affected files (+44,
Patchset 2 (id:??) landed as
https://crrev.com/4a4d83683dff9d2fc6bd17aa1f10d6104077467d
Cr-Commit-Position: refs/heads/master@{#29540}
https://codereview.chromium.org/1222713013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1222713013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 5 (id:??) landed as
https://crrev.com/737b8573f80deaa1cbaec98f42ecd3e3b56ba901
Cr-Commit-Position: refs/heads/master@{#29539}
https://codereview.chromium.org/1225943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #5 (id:80001)
https://codereview.chromium.org/1225943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
On 2015/07/08 09:53:04, caseq wrote:
+1 to getting this done (and willing to help if needed, as I had a
somewhat
similar CL before yurys@ kindly pointed me here).
We would like to start relying on trace events emitted by v8 in DevTools'
Timeline (in particular, crbug.com/508005 depends on th
lgtm from my side.
https://codereview.chromium.org/1216593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1222713013/20001
https://codereview.chromium.org/1222713013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
LGTM, thanks!
https://codereview.chromium.org/1222713013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emai
Thanks
https://codereview.chromium.org/1217603005/diff/40001/src/runtime/runtime-function.cc
File src/runtime/runtime-function.cc (right):
https://codereview.chromium.org/1217603005/diff/40001/src/runtime/runtime-function.cc#newcode449
src/runtime/runtime-function.cc:449: Handle bound_function_
lgtm
https://codereview.chromium.org/1223813008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm with comment
https://codereview.chromium.org/1217603005/diff/40001/src/runtime/runtime-function.cc
File src/runtime/runtime-function.cc (right):
https://codereview.chromium.org/1217603005/diff/40001/src/runtime/runtime-function.cc#newcode449
src/runtime/runtime-function.cc:449: Handle boun
Reviewers: Michael Achenbach,
Message:
PTAL, thanks.
Description:
Add use_goma option to Makefile build.
Please review this at https://codereview.chromium.org/1225683010/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -1 lines):
M Makefile
Index: Makefile
Comment #13 on issue 3088 by verwa...@chromium.org: PutValue and [[Put]] do
not throw for primitive base values in strict mode
https://code.google.com/p/v8/issues/detail?id=3088
Will be fixed by https://codereview.chromium.org/1221303019/
--
You received this message because this project is
lgtm
https://codereview.chromium.org/1220193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1225943002/80001
https://codereview.chromium.org/1225943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
On 2015/07/08 16:22:11, arv wrote:
LGTM
Please update the CL title and description.
done
https://codereview.chromium.org/1222713013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Goog
LGTM
Please update the CL title and description.
https://codereview.chromium.org/1222713013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fro
On 2015/07/08 16:02:30, rossberg wrote:
On 2015/07/08 15:52:04, caitp wrote:
> here it is :( I think it needs unstaging otherwise you could still see
problems
> when experimental JS features are enabled in chromium.
Issues with experimental are fine, that's why it is named that way. ;)
I'd p
Status: Untriaged
Owner:
New issue 4286 by alexand...@opera.com: Check failed: index >= 0 && index <
NumAllocatableRegisters()
https://code.google.com/p/v8/issues/detail?id=4286
Version: 4.5.66 (chromium 45.0.2438.3)
OS: Linux
Architecture: ARM (armv7l)
What steps will reproduce the pro
Patchset 1 (id:??) landed as
https://crrev.com/11a831f12bcbfaf35cf2c9b49e80a45d8efca1ee
Cr-Commit-Position: refs/heads/master@{#29538}
https://codereview.chromium.org/1214673007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1214673007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1214673007/1
https://codereview.chromium.org/1214673007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
On 2015/07/08 15:52:04, caitp wrote:
here it is :( I think it needs unstaging otherwise you could still see
problems
when experimental JS features are enabled in chromium.
Issues with experimental are fine, that's why it is named that way. ;)
I'd prefer to keep it staged, so that we continue
On 2015/07/08 16:00:44, arv wrote:
On 2015/07/08 15:52:04, caitp wrote:
> here it is :( I think it needs unstaging otherwise you could still see
problems
> when experimental JS features are enabled in chromium.
If you also unstage you need to update test262-es6.status
Blah :( How many rest-r
On 2015/07/08 15:52:04, caitp wrote:
here it is :( I think it needs unstaging otherwise you could still see
problems
when experimental JS features are enabled in chromium.
If you also unstage you need to update test262-es6.status
https://codereview.chromium.org/1222713013/
--
--
v8-dev mail
Updates:
Blockedon: -v8:507596 chromium:507596
Comment #44 on issue 811 by rossb...@chromium.org: Implement destructuring
https://code.google.com/p/v8/issues/detail?id=811
(No comment was entered for this change.)
--
You received this message because this project is configured to send a
Updates:
Blockedon: v8:507596
Comment #43 on issue 811 by rossb...@chromium.org: Implement destructuring
https://code.google.com/p/v8/issues/detail?id=811
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifi
Updates:
Cc: a...@chromium.org ad...@chromium.org caitpott...@gmail.com
Comment #12 on issue 3088 by verwa...@chromium.org: PutValue and [[Put]] do
not throw for primitive base values in strict mode
https://code.google.com/p/v8/issues/detail?id=3088
Issue 4042 has been merged into thi
Updates:
Status: Duplicate
Mergedinto: 3088
Comment #8 on issue 4042 by verwa...@chromium.org: Strict Set() should
throw when setting readonly properties of primitive values
https://code.google.com/p/v8/issues/detail?id=4042
(No comment was entered for this change.)
--
You re
Updates:
Owner: verwa...@chromium.org
Cc: mstarzin...@chromium.org
Comment #11 on issue 3088 by verwa...@chromium.org: PutValue and [[Put]] do
not throw for primitive base values in strict mode
https://code.google.com/p/v8/issues/detail?id=3088
Stealing since I'm fixing it.
-
Reviewers: rossberg,
Message:
here it is :( I think it needs unstaging otherwise you could still see
problems
when experimental JS features are enabled in chromium.
Description:
[es6] unship+unstage harmony_rest_parameters
Unstaging to prevent issues with arrow functions when --harmony is
en
1 - 100 of 199 matches
Mail list logo
