[v8-dev] Re: Issue 4332 in v8: JSON.parse() fails without helpful line number of line offset information when unexpected token is encountered

2015-07-29 Thread codesite-noreply via v8-dev
Updates: Status: Duplicate Mergedinto: chromium:515382 Comment #3 on issue 4332 by yang...@chromium.org: JSON.parse() fails without helpful line number of line offset information when unexpected token is encountered https://code.google.com/p/v8/issues/detail?id=4332 (No comm

[v8-dev] Re: Issue 4332 in v8: JSON.parse() fails without helpful line number of line offset information when unexpected token is encountered

2015-07-29 Thread codesite-noreply via v8-dev
Comment #2 on issue 4332 by yang...@chromium.org: JSON.parse() fails without helpful line number of line offset information when unexpected token is encountered https://code.google.com/p/v8/issues/detail?id=4332 This is a Chrome issue, not a V8 one. In d8, you would get this: undefined:3:

[v8-dev] Re: [turbofan]: Implement tail calls with differing stack parameter counts (issue 1259203002 by da...@chromium.org)

2015-07-29 Thread bmeurer
https://codereview.chromium.org/1259203002/diff/140001/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1259203002/diff/140001/src/compiler/ast-graph-builder.cc#newcode2606 src/compiler/ast-graph-builder.cc:2606: TailCallMode mode

[v8-dev] Re: MIPS: Tweak CEntryStub to free up callee-saved regs s0-s2. (issue 1263723002 by paul.l...@imgtec.com)

2015-07-29 Thread paul . lind
This was not needed for interpreter, as callee-saved regs turned out to be unnecessary there, so the urgency is removed. However, this does remove a couple instructions, and is probably a worthwhile cleanup. I will revisit this in next couple days, and add mips64, if I decide to land this. h

[v8-dev] Re: Factor C call descriptor building into compiler/c-linkage.cc with inline (issue 1266603002 by tit...@chromium.org)

2015-07-29 Thread bmeurer
This approach will not work because you add new static initializers until uniform initialization and constexpr is allowed. https://codereview.chromium.org/1266603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because yo

[v8-dev] Re: Issue 2397 in v8: Error.toString() throws illegal access

2015-07-29 Thread codesite-noreply via v8-dev
Comment #6 on issue 2397 by yang...@chromium.org: Error.toString() throws illegal access https://code.google.com/p/v8/issues/detail?id=2397 "type" and "arguments" were special properties used internally by V8. That was a bug that has been fixed. They are no longer used internally so it sh

[v8-dev] Re: Stop overallocating feedback vector slots. (issue 1262803002 by mvstan...@chromium.org)

2015-07-29 Thread bmeurer
Awesome! LGTM with nit. https://codereview.chromium.org/1262803002/diff/1/src/ast-numbering.cc File src/ast-numbering.cc (right): https://codereview.chromium.org/1262803002/diff/1/src/ast-numbering.cc#newcode326 src/ast-numbering.cc:326: if (expr->IsProperty()) Nit: if { ... } else { ... } htt

[v8-dev] Re: [turbofan] Merge dependent Word32Equal on ARM64 (issue 1260733003 by martyn.capew...@arm.com)

2015-07-29 Thread bmeurer
lgtm https://codereview.chromium.org/1260733003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [turbofan] Fix invalid access to Parameter index. (issue 1266743002 by bmeu...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266743002/1 https://codereview.chromium.org/1266743002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: MIPS: Tweak CEntryStub to free up callee-saved regs s0-s2. (issue 1263723002 by paul.l...@imgtec.com)

2015-07-29 Thread Ilija . Pavlovic
LGTM. https://codereview.chromium.org/1263723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Assign more bits to safepoint table offset. (issue 1265663002 by yang...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265663002/20001 https://codereview.chromium.org/1265663002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [turbofan] Fix invalid access to Parameter index. (issue 1266743002 by bmeu...@chromium.org)

2015-07-29 Thread yangguo
On 2015/07/30 06:01:35, Benedikt Meurer wrote: Hey Yang, Simple fix. Please take a look. Thanks, Benedikt lgtm https://codereview.chromium.org/1266743002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you a

[v8-dev] Re: [turbofan] Fix invalid access to Parameter index. (issue 1266743002 by bmeu...@chromium.org)

2015-07-29 Thread bmeurer
Hey Yang, Simple fix. Please take a look. Thanks, Benedikt https://codereview.chromium.org/1266743002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsu

[v8-dev] [turbofan] Fix invalid access to Parameter index. (issue 1266743002 by bmeu...@chromium.org)

2015-07-29 Thread bmeu...@chromium.org via codereview.chromium.org
Reviewers: Yang, Description: [turbofan] Fix invalid access to Parameter index. A Parameter operator contains a ParameterInfo payload, not an int payload, so the OpParameter cast is invalid (and only worked by coincidence currently). BUG=chromium:515215 LOG=n R=yang...@chromium.org Please revi

[v8-dev] Re: MIPS: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. (issue 1257953002 by paul.l...@imgtec.com)

2015-07-29 Thread paul . lind
OK, here is the updated mips32 port, and a mips64 version. I tried to get too clever and and rebase this on unlanded https://codereview.chromium.org/1254293006/ which is in the CQ. That didn't work, so there an extra patchset to clean that up. You will have to fixup linkage-mips[64].cc since this

[v8-dev] Re: Issue 4277 in v8: Problem with MOVW_MOVT_IMMEDIATE_LOADS feature

2015-07-29 Thread codesite-noreply via v8-dev
Comment #6 on issue 4277 by seju...@gmail.com: Problem with MOVW_MOVT_IMMEDIATE_LOADS feature https://code.google.com/p/v8/issues/detail?id=4277 Hi ulan. The movw, movt instructions still cause assert fail error. The expected size(28) and generated code size(24) are different each other at

[v8-dev] Issue 4335 in v8: large google maps performance regression in chrome canary (version 46)

2015-07-29 Thread codesite-noreply via v8-dev
Status: Untriaged Owner: New issue 4335 by rsturg...@google.com: large google maps performance regression in chrome canary (version 46) https://code.google.com/p/v8/issues/detail?id=4335 google maps in chrome 46 has some really bad framerate issues. To repro just go to maps.google.com (

[v8-dev] Re: Issue 2397 in v8: Error.toString() throws illegal access

2015-07-29 Thread codesite-noreply via v8-dev
Comment #5 on issue 2397 by a...@goodeggs.com: Error.toString() throws illegal access https://code.google.com/p/v8/issues/detail?id=2397 Thanks for fixing. Could you speak a little more to "'type' and 'arguments' properties should not be set for Error objects"? It doesn't seem to be wid

[v8-dev] Re: improve allocation accounting for incremental mark (issue 1252053003 by ofrob...@google.com)

2015-07-29 Thread ofrobots via v8-dev
On 2015/07/29 20:45:06, ofrobots wrote: On 2015/07/24 06:32:10, Hannes Payer wrote: > https://codereview.chromium.org/1252053003/diff/1/src/heap/spaces.cc > File src/heap/spaces.cc (right): > > https://codereview.chromium.org/1252053003/diff/1/src/heap/spaces.cc#newcode1478 > src/heap/spaces.c

[v8-dev] remove recursion from NewSpace::AllocateRaw* (issue 1265443003 by ofrob...@google.com)

2015-07-29 Thread ofrob...@google.com via codereview.chromium.org
Reviewers: Hannes Payer, Description: remove recursion from NewSpace::AllocateRaw* The recursion between AllocateRaw* and SlowAllocateRaw makes incremental stepping very complicated. This patch removes the recursion. Follow-on patches will improve accounting of allocations done by incremental ma

[v8-dev] Re: Issue 3915 in v8: Implement exponentiation operator

2015-07-29 Thread codesite-noreply via v8-dev
Comment #11 on issue 3915 by waldron@gmail.com: Implement exponentiation operator https://code.google.com/p/v8/issues/detail?id=3915 Here's the latest specification http://rwaldron.github.io/exponentiation-operator/ -- You received this message because this project is configured to se

[v8-dev] Re: Issue 3915 in v8: Implement exponentiation operator

2015-07-29 Thread codesite-noreply via v8-dev
Comment #10 on issue 3915 by waldron@gmail.com: Implement exponentiation operator https://code.google.com/p/v8/issues/detail?id=3915 Just another update, SpiderMonkey has landed this feature https://bugzilla.mozilla.org/show_bug.cgi?id=1135708 and the proposal has been advanced to Sta

[v8-dev] Re: Fix idle notification for background tab. (issue 1269583002 by u...@chromium.org)

2015-07-29 Thread hpayer
lgtm https://codereview.chromium.org/1269583002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: improve allocation accounting for incremental mark (issue 1252053003 by ofrob...@google.com)

2015-07-29 Thread ofrobots via v8-dev
On 2015/07/24 06:32:10, Hannes Payer wrote: https://codereview.chromium.org/1252053003/diff/1/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/1252053003/diff/1/src/heap/spaces.cc#newcode1478 src/heap/spaces.cc:1478: int aligned_size_in_bytes = size_in_bytes

[v8-dev] Re: MIPS: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. (issue 1257953002 by paul.l...@imgtec.com)

2015-07-29 Thread rmcilroy
On 2015/07/27 05:02:56, paul.l... wrote: Cool stuff, Ross! Here's a first-cut MIPS port for https://codereview.chromium.org/1245133002/ I still need to do the MIPS64, and take one more look at this before you include it in your CL. I'll do that in the morning my time. Any feedback welcome!

[v8-dev] Re: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. (issue 1245133002 by rmcil...@chromium.org)

2015-07-29 Thread rmcilroy
Updated with support for other architectures and a couple of fixes exposed by testing. PTAL. On 2015/07/29 04:37:51, paul.l... wrote: DBC: looks like your new use of r5 conflicts with r5 use in CEntryStub. More details in https://codereview.chromium.org/1253273002/. This shouldn't be an is

[v8-dev] Re: MIPS64: Fix the integer division in crankshaft. (issue 1265603002 by akos.pa...@imgtec.com)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265603002/1 https://codereview.chromium.org/1265603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: MIPS64: Fix the integer division in crankshaft. (issue 1265603002 by akos.pa...@imgtec.com)

2015-07-29 Thread paul . lind
LGTM, thanks. https://codereview.chromium.org/1265603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emai

[v8-dev] Re: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. (issue 1254293006 by rmcil...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254293006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254293006/40001 https://codereview.chromium.org/1254293006/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: MIPS64: Fix the integer division in crankshaft. (issue 1265603002 by akos.pa...@imgtec.com)

2015-07-29 Thread dusan . milosavljevic
lgtm. https://codereview.chromium.org/1265603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. (issue 1254293006 by rmcil...@chromium.org)

2015-07-29 Thread rmcilroy
https://codereview.chromium.org/1254293006/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1254293006/diff/1/src/flag-definitions.h#newcode283 src/flag-definitions.h:283: DEFINE_BOOL(ignition, true, "use ignition interpreter") On 2015/07/29 08:1

[v8-dev] Re: Issue 3659 in v8: Classes: Make sure function name inferrer works

2015-07-29 Thread codesite-noreply via v8-dev
Updates: Owner: ad...@chromium.org Cc: yang...@chromium.org Labels: Debugger Comment #6 on issue 3659 by ad...@chromium.org: Classes: Make sure function name inferrer works https://code.google.com/p/v8/issues/detail?id=3659 (No comment was entered for this change.) --

[v8-dev] Re: Issue 4333 in v8: Function name inferrer does not work for ES6 classes

2015-07-29 Thread codesite-noreply via v8-dev
Updates: Status: Duplicate Mergedinto: 3659 Comment #3 on issue 4333 by ad...@chromium.org: Function name inferrer does not work for ES6 classes https://code.google.com/p/v8/issues/detail?id=4333 (No comment was entered for this change.) -- You received this message because t

[v8-dev] Re: Issue 3659 in v8: Classes: Make sure function name inferrer works

2015-07-29 Thread codesite-noreply via v8-dev
Updates: Cc: rossb...@chromium.org little...@chromium.org Comment #5 on issue 3659 by ad...@chromium.org: Classes: Make sure function name inferrer works https://code.google.com/p/v8/issues/detail?id=3659 Issue 4333 has been merged into this issue. -- You received this message becaus

[v8-dev] Re: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. (issue 1254293006 by rmcil...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/3179) https://codereview.chromium.org/1254293006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups

[v8-dev] Re: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. (issue 1254293006 by rmcil...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254293006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254293006/20001 https://codereview.chromium.org/1254293006/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Fix idle notification for background tab. (issue 1269583002 by u...@chromium.org)

2015-07-29 Thread ulan
https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handler.cc#newcode205 src/heap/gc-idle-time-handler.cc:205: idle_times_which_made_no_progress_

[v8-dev] Re: PSA: [Action required] Please sign Google Contributor License Agreement

2015-07-29 Thread Sheng Yang
Hi all, For the last month CQ posts an informative warning message if the author has not signed CLA, and we're glad to see that this message greatly reduced the percentage of authors w/o CLA. So now we've fully enabled SignCLA verifier in CQ to make the check a real blocker. Please let us know if

[v8-dev] Re: Fix idle notification for background tab. (issue 1269583002 by u...@chromium.org)

2015-07-29 Thread rmcilroy
https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handler.cc#newcode205 src/heap/gc-idle-time-handler.cc:205: idle_times_which_made_no_progress_

[v8-dev] Fix idle notification for background tab. (issue 1269583002 by u...@chromium.org)

2015-07-29 Thread ulan
Reviewers: Hannes Payer, Message: ptal Description: Fix idle notification for background tab. The idle time handler should never return DONE or DO_SCAVENGE for background tabs. Upon receiving DONE chrome will stop sending idle notifications. BUG=chromium:515174 LOG=NO Please review this at ht

[v8-dev] Re: Issue 4334 in v8: API: Should CreateDataProperty overwrite accessors, or call them?

2015-07-29 Thread codesite-noreply via v8-dev
Comment #7 on issue 4334 by verwa...@chromium.org: API: Should CreateDataProperty overwrite accessors, or call them? https://code.google.com/p/v8/issues/detail?id=4334 So that matches what I described in #2. Sounds like a good plan. -- You received this message because this project is config

[v8-dev] Re: Issue 4334 in v8: API: Should CreateDataProperty overwrite accessors, or call them?

2015-07-29 Thread codesite-noreply via v8-dev
Comment #6 on issue 4334 by hara...@chromium.org: API: Should CreateDataProperty overwrite accessors, or call them? https://code.google.com/p/v8/issues/detail?id=4334 Chatted with Jakob offline. It seems that the problem is that window.innerWidth is still using a data-type property. Once w

[v8-dev] Re: Issue 4245 in v8: String.prototype.split should use ToLength

2015-07-29 Thread codesite-noreply via v8-dev
Comment #3 on issue 4245 by ad...@chromium.org: String.prototype.split should use ToLength https://code.google.com/p/v8/issues/detail?id=4245 This was discussed at the TC39 meeting yesterday, and Allen asked me to file a spec bug: https://bugs.ecmascript.org/show_bug.cgi?id=4432 I think I

[v8-dev] Re: Issue 4334 in v8: API: Should CreateDataProperty overwrite accessors, or call them?

2015-07-29 Thread codesite-noreply via v8-dev
Comment #5 on issue 4334 by verwa...@chromium.org: API: Should CreateDataProperty overwrite accessors, or call them? https://code.google.com/p/v8/issues/detail?id=4334 Yes, that's exactly what I want as well. In this particular case it's likely because the innerWidth native setter does the

[v8-dev] Re: Issue 4334 in v8: API: Should CreateDataProperty overwrite accessors, or call them?

2015-07-29 Thread codesite-noreply via v8-dev
Comment #4 on issue 4334 by hara...@chromium.org: API: Should CreateDataProperty overwrite accessors, or call them? https://code.google.com/p/v8/issues/detail?id=4334 The spec is here: https://heycam.github.io/webidl/#es-attributes 6. If the attribute is declared with a [Replaceable] extende

[v8-dev] Re: Issue 4334 in v8: API: Should CreateDataProperty overwrite accessors, or call them?

2015-07-29 Thread codesite-noreply via v8-dev
Comment #3 on issue 4334 by hara...@chromium.org: API: Should CreateDataProperty overwrite accessors, or call them? https://code.google.com/p/v8/issues/detail?id=4334 I wasn't expecting that I can get a reply from you :) We want to make the following change. (Current behavior) window.innerW

[v8-dev] Re: Issue 4334 in v8: API: Should CreateDataProperty overwrite accessors, or call them?

2015-07-29 Thread codesite-noreply via v8-dev
Comment #2 on issue 4334 by verwa...@chromium.org: API: Should CreateDataProperty overwrite accessors, or call them? https://code.google.com/p/v8/issues/detail?id=4334 API accessors entirely behave like data properties, with the data management handled by the accessor. If we don't call the

[v8-dev] [turbofan] Merge dependent Word32Equal on ARM64 (issue 1260733003 by martyn.capew...@arm.com)

2015-07-29 Thread martyn . capewell
Reviewers: ulan, Benedikt Meurer, Description: [turbofan] Merge dependent Word32Equal on ARM64 Improve code generated for flag materialization. BUG= Please review this at https://codereview.chromium.org/1260733003/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (

[v8-dev] Re: Assign more bits to safepoint table offset. (issue 1265663002 by yang...@chromium.org)

2015-07-29 Thread jkummerow
LGTM. Thankfully the STATIC_ASSERT on the next line says that this change is safe :-) https://codereview.chromium.org/1265663002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Gr

[v8-dev] Re: Issue 4332 in v8: JSON.parse() fails without helpful line number of line offset information when unexpected token is encountered

2015-07-29 Thread codesite-noreply via v8-dev
Updates: Status: Available Cc: jkumme...@chromium.org rossb...@chromium.org yang...@chromium.org Labels: Type-FeatureRequest Area-Runtime Priority-Medium Comment #1 on issue 4332 by habl...@chromium.org: JSON.parse() fails without helpful line number of line offset infor

[v8-dev] Re: Issue 4334 in v8: API: Should CreateDataProperty overwrite accessors, or call them?

2015-07-29 Thread codesite-noreply via v8-dev
Updates: Cc: yukishi...@chromium.org Comment #1 on issue 4334 by hara...@chromium.org: API: Should CreateDataProperty overwrite accessors, or call them? https://code.google.com/p/v8/issues/detail?id=4334 (No comment was entered for this change.) -- You received this message because t

[v8-dev] Issue 4334 in v8: API: Should CreateDataProperty overwrite accessors, or call them?

2015-07-29 Thread codesite-noreply via v8-dev
Status: Available Owner: CC: hara...@chromium.org, verwa...@chromium.org, joc...@chromium.org, jkumme...@chromium.org, rossb...@chromium.org Labels: Type-Bug Priority-Medium Area-API New issue 4334 by jkumme...@chromium.org: API: Should CreateDataProperty overwrite accessors, or cal

[v8-dev] Factor C call descriptor building into compiler/c-linkage.cc with inline (issue 1266603002 by tit...@chromium.org)

2015-07-29 Thread titzer
Reviewers: Benedikt Meurer, danno, Description: Factor C call descriptor building into compiler/c-linkage.cc with inline platform-specifics. This is the first step in cutting the Gordian linkage/linkage-impl knot. This basically changes the axis along which we organize call descriptor building

[v8-dev] Re: Reduce allowance in the first code page at start up. (issue 1262833002 by yang...@chromium.org)

2015-07-29 Thread hpayer
On 2015/07/29 14:51:46, commit-bot: I haz the power wrote: Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262833002/1 Lgtm https://codereview.chromium.

[v8-dev] Assign more bits to safepoint table offset. (issue 1265663002 by yang...@chromium.org)

2015-07-29 Thread yang...@chromium.org via codereview.chromium.org
Reviewers: Jakob, Description: Assign more bits to safepoint table offset. 1 << 24 is apparently not large enough for some optimized code. R=jkumme...@chromium.org BUG=v8:4272 LOG=N Please review this at https://codereview.chromium.org/1265663002/ Base URL: https://chromium.googlesource.com/v

[v8-dev] Reduce allowance in the first code page at start up. (issue 1262833002 by yang...@chromium.org)

2015-07-29 Thread yangguo
Reviewers: Hannes Payer, Description: Reduce allowance in the first code page at start up. This has become possible since we moved a few experimental Javascript features to default. R=hpa...@chromium.org BUG=chromium:506044 LOG=N Please review this at https://codereview.chromium.org/1262833002

[v8-dev] Re: Issue 4272 in v8: SIGILL when running Emscripten compiled script with --always_opt --nodead_code_elimination --always_osr

2015-07-29 Thread codesite-noreply via v8-dev
Comment #3 on issue 4272 by vladisla...@gmail.com: SIGILL when running Emscripten compiled script with --always_opt --nodead_code_elimination --always_osr https://code.google.com/p/v8/issues/detail?id=4272 The flags also make sense: the function is not hot enough to be optimized otherwis

[v8-dev] Re: SIMD.js Add the other SIMD Phase 1 types. (issue 1250733005 by bbu...@chromium.org)

2015-07-29 Thread rossberg
Mostly looking good, but I wonder about the cost of the IS_SIMD_VALUE predicate. https://codereview.chromium.org/1250733005/diff/210001/src/harmony-simd.js File src/harmony-simd.js (right): https://codereview.chromium.org/1250733005/diff/210001/src/harmony-simd.js#newcode35 src/harmony-simd.j

[v8-dev] Re: Issue 4272 in v8: SIGILL when running Emscripten compiled script with --always_opt --nodead_code_elimination --always_osr

2015-07-29 Thread codesite-noreply via v8-dev
Comment #2 on issue 4272 by vladisla...@gmail.com: SIGILL when running Emscripten compiled script with --always_opt --nodead_code_elimination --always_osr https://code.google.com/p/v8/issues/detail?id=4272 It seems, the generated code for the function is simply too large. This causes saf

[v8-dev] Move final parts of class literal setup into a single runtime call (issue 1266573003 by conr...@chromium.org)

2015-07-29 Thread conradw
Reviewers: Michael Starzinger, rossberg, Message: PTAL Description: Move final parts of class literal setup into a single runtime call This avoids multiple ToFastProperties runtime calls and additional stack pushes in strong mode. BUG= Please review this at https://codereview.chromium.org/126

[v8-dev] Re: Optimize ToString and NonStringToString. (issue 1256323004 by bbu...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256323004/20001 https://codereview.chromium.org/1256323004/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: PPC: Support for conditional return instruction. (issue 1259723002 by mbra...@us.ibm.com)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259723002/1 https://codereview.chromium.org/1259723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Stop overallocating feedback vector slots. (issue 1262803002 by mvstan...@chromium.org)

2015-07-29 Thread mvstanton
Hi Benedikt, Here is a fix for the bug we saw the other day, where an IC slot is foolishly allocated for a VariableProxy on the LHS of an assignment operation. (also Property). Thanks for the look, --Michael https://codereview.chromium.org/1262803002/ -- -- v8-dev mailing list v8-dev@googlegr

[v8-dev] Stop overallocating feedback vector slots. (issue 1262803002 by mvstan...@chromium.org)

2015-07-29 Thread mvstanton
Reviewers: , Message: Hi Benedikt, Here is a fix for the bug we saw the other day, where an IC slot is foolishly allocated for a VariableProxy on the LHS of an assignment operation. (also Property). Thanks for the look, --Michael Description: Stop overallocating feedback vector slots. When a

[v8-dev] Tail call from TurboFan into select runtime calls (issue 1254073003 by da...@chromium.org)

2015-07-29 Thread danno
Reviewers: Michael Starzinger, Message: PTAL Description: Tail call from TurboFan into select runtime calls Please review this at https://codereview.chromium.org/1254073003/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+33, -0 lines): M src/compiler/js-contex

[v8-dev] Re: MIPS: Fix disassembler test for J and JAL instructions. (issue 1258743004 by ilija.pavlo...@imgtec.com)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258743004/20001 https://codereview.chromium.org/1258743004/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Optimize ToString and NonStringToString. (issue 1256323004 by bbu...@chromium.org)

2015-07-29 Thread rossberg
lgtm https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js File src/runtime.js (left): https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js#oldcode769 src/runtime.js:769: if (IS_SYMBOL_WRAPPER(x)) throw MakeTypeError(kSymbolToPrimitive); On 2015/07/28 19:07:30,

[v8-dev] Re: Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1260423002 by jkumme...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/2c16d81b256ed664c376342313558a37bbce0131 Cr-Commit-Position: refs/heads/master@{#29905} https://codereview.chromium.org/1260423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1260423002 by jkumme...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1260423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1260423002 by jkumme...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260423002/1 https://codereview.chromium.org/1260423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1260423002 by jkumme...@chromium.org)

2015-07-29 Thread jkummerow
https://codereview.chromium.org/1268463002/ should fix those failures, let's try CQing again... https://codereview.chromium.org/1260423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the G

[v8-dev] Re: Debugger: skip function prologue when computing redirect PC. (issue 1268463002 by yang...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/485aca6df6065790c7454348eb3aac51b6e24616 Cr-Commit-Position: refs/heads/master@{#29904} https://codereview.chromium.org/1268463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Debugger: skip function prologue when computing redirect PC. (issue 1268463002 by yang...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1268463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Debugger: skip function prologue when computing redirect PC. (issue 1268463002 by yang...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268463002/1 https://codereview.chromium.org/1268463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] MIPS64: Fix the integer division in crankshaft. (issue 1265603002 by akos.pa...@imgtec.com)

2015-07-29 Thread akos . palfi
Reviewers: paul.l..., balazs.kilvady, gergely.kis.imgtec, Message: PTAL. Description: MIPS64: Fix the integer division in crankshaft. Replaces the 64-bit div instruction with 32-bit division in DivI. Also fixes the Ddiv implementation in the simulator. TEST=mjsunit/asm/int32div BUG= Please re

[v8-dev] Re: [test] Fix for keying variants. (issue 1262113002 by machenb...@chromium.org)

2015-07-29 Thread jkummerow
lgtm https://codereview.chromium.org/1262113002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Tweak CEntryStub to free up callee-saved regs s0-s2. (issue 1263723002 by paul.l...@imgtec.com)

2015-07-29 Thread balazs . kilvady
LGTM. https://codereview.chromium.org/1263723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Debugger: skip function prologue when computing redirect PC. (issue 1268463002 by yang...@chromium.org)

2015-07-29 Thread jkummerow
lgtm https://codereview.chromium.org/1268463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 4333 in v8: Function name inferrer does not work for ES6 classes

2015-07-29 Thread codesite-noreply via v8-dev
Updates: Owner: ad...@chromium.org Cc: -ad...@chromium.org rossb...@chromium.org Comment #2 on issue 4333 by rossb...@chromium.org: Function name inferrer does not work for ES6 classes https://code.google.com/p/v8/issues/detail?id=4333 (No comment was entered for this change.)

[v8-dev] Debugger: skip function prologue when computing redirect PC. (issue 1268463002 by yang...@chromium.org)

2015-07-29 Thread yang...@chromium.org via codereview.chromium.org
Reviewers: Jakob, Description: Debugger: skip function prologue when computing redirect PC. R=jkumme...@chromium.org Please review this at https://codereview.chromium.org/1268463002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+18, -5 lines): M src/debug.cc

[v8-dev] Re: Pretenuring decision of outermost literal is propagated to inner literals. (issue 1263773002 by hpa...@chromium.org)

2015-07-29 Thread hpa...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) manually as aa84551622799c6c44b8ee60ea6c40405465177a (tree was closed). https://codereview.chromium.org/1263773002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed t

[v8-dev] Re: Add test for referring function name for classes. (issue 1264603002 by yang...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264603002/20001 https://codereview.chromium.org/1264603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1260423002 by jkumme...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/8156) https://codereview.chromium.org/1260423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -

[v8-dev] Re: Add test for referring function name for classes. (issue 1264603002 by yang...@chromium.org)

2015-07-29 Thread mvstanton
lgtm https://codereview.chromium.org/1264603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Add test for referring function name for classes. (issue 1264603002 by yang...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264603002/1 https://codereview.chromium.org/1264603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Issue 4333 in v8: Function name inferrer does not work for ES6 classes

2015-07-29 Thread codesite-noreply via v8-dev
Comment #1 on issue 4333 by yang...@chromium.org: Function name inferrer does not work for ES6 classes https://code.google.com/p/v8/issues/detail?id=4333 Here's the test case: https://codereview.chromium.org/1264603002 -- You received this message because this project is configured to send a

[v8-dev] Add test for referring function name for classes. (issue 1264603002 by yang...@chromium.org)

2015-07-29 Thread yang...@chromium.org via codereview.chromium.org
Reviewers: mvstanton, Description: Add test for referring function name for classes. R=mvstan...@chromium.org BUG=v8:4333 LOG=N Please review this at https://codereview.chromium.org/1264603002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+44, -0 lines): M te

[v8-dev] Issue 4333 in v8: Function name inferrer does not work for ES6 classes

2015-07-29 Thread codesite-noreply via v8-dev
Status: Assigned Owner: rossb...@chromium.org CC: ad...@chromium.org, little...@chromium.org Labels: Type-Bug Priority-Medium Harmony Debugger New issue 4333 by yang...@chromium.org: Function name inferrer does not work for ES6 classes https://code.google.com/p/v8/issues/detail?id=4333 We us

[v8-dev] Re: Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par... (issue 1260423002 by jkumme...@chromium.org)

2015-07-29 Thread hablich
On 2015/07/29 09:26:49, Jakob wrote: Created Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par... lgtm https://codereview.chromium.org/1260423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-de

[v8-dev] Re: Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1260423002 by jkumme...@chromium.org)

2015-07-29 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260423002/1 https://codereview.chromium.org/1260423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Issue 1801 in v8: V8/Chrome for Windows Only does not respect United States DST rules prior to 2007

2015-07-29 Thread codesite-noreply via v8-dev
Comment #3 on issue 1801 by mariusz.pala: V8/Chrome for Windows Only does not respect United States DST rules prior to 2007 https://code.google.com/p/v8/issues/detail?id=1801 Note that it works as intended in IE10 and IE11 and in Chrome on OSX. But it doesn't work correctly in Chrome on Win

[v8-dev] Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par... (issue 1260423002 by jkumme...@chromium.org)

2015-07-29 Thread jkummerow
Reviewers: Igor Sheludko, v8-mips-ports_googlegroups.com, Paul Lind, Benedikt Meurer, Message: Created Revert of Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par... Description: Revert of Reland^2 "Enable loads and stores to global vars throug

[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeu...@chromium.org)

2015-07-29 Thread jkummerow
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1260423002/ by jkumme...@chromium.org. The reason for reverting is: Suspected to cause Canary crashes. https://codereview.chromium.org/1254723004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://

[v8-dev] Re: Issue 1801 in v8: V8/Chrome for Windows Only does not respect United States DST rules prior to 2007

2015-07-29 Thread codesite-noreply via v8-dev
Comment #2 on issue 1801 by mariusz.pala: V8/Chrome for Windows Only does not respect United States DST rules prior to 2007 https://code.google.com/p/v8/issues/detail?id=1801 Hi, this is a really old bug, can you finally fix it please? Thank you -- You received this message because this proj

[v8-dev] Re: Pretenuring decision of outermost literal is propagated to inner literals. (issue 1263773002 by hpa...@chromium.org)

2015-07-29 Thread mvstanton
Right on, LGTM. https://codereview.chromium.org/1263773002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving e

[v8-dev] Re: Pretenuring decision of outermost literal is propagated to inner literals. (issue 1263773002 by hpa...@chromium.org)

2015-07-29 Thread hpayer
Thanks Michael, that makes it simpler! Done. https://codereview.chromium.org/1263773002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from thi

[v8-dev] Re: Pretenuring decision of outermost literal is propagated to inner literals. (issue 1263773002 by hpa...@chromium.org)

2015-07-29 Thread mvstanton
Nice. Use site_context->top() and you won't have to pass the new parameter... https://codereview.chromium.org/1263773002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-d

[v8-dev] Pretenuring decision of outermost literal is propagated to inner literals. (issue 1263773002 by hpa...@chromium.org)

2015-07-29 Thread hpayer
Reviewers: mvstanton, jochen, Description: Pretenuring decision of outermost literal is propagated to inner literals. Literals should stay together to simplify allocation folding. This CL takes the pretenuring information from the outermost literal and applies it to the inner liberals. BUG

[v8-dev] [turbofan]: Implement tail calls with differing stack parameter counts (issue 1259203002 by da...@chromium.org)

2015-07-29 Thread danno
Reviewers: Benedikt Meurer, titzer, Message: Not for landing yet, but I'd appreciate feedback before doing the rest of the platform ports. Description: [turbofan]: Implement tail calls with differing stack parameter counts WORK IN PROGRESS, I'D APPRECIATE FEEDBACK BEFORE DOING THE OTHER PLAT

[v8-dev] Re: Bugfix: CCTest test-func-name-inference/InConstructor is broken (issue 1263763002 by mvstan...@chromium.org)

2015-07-29 Thread yangguo
On 2015/07/29 08:33:54, mvstanton wrote: Hi Yang, here is a fix for the function name inferrer. Recent changes in scoping caused functions that were lazily parsed to be eagerly parsed. It appears that the eager parse case didn't even have the possibility for the function name inferrer to w

  1   2   >