[v8-dev] Re: Update V8 DEPS. (issue 1276023003 by v8-autor...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1276023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Update V8 DEPS. (issue 1276023003 by v8-autor...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/82100c1507342c40acaf6773b53f1e98ce2e6008 Cr-Commit-Position: refs/heads/master@{#30077} https://codereview.chromium.org/1276023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Update V8 DEPS. (issue 1276023003 by v8-autor...@chromium.org)

2015-08-07 Thread v8-autor...@chromium.org via codereview.chromium.org
Reviewers: Michael Achenbach (OOO), Description: Update V8 DEPS. Rolling v8/tools/clang to c956d7970bf6637cb34f17ff64c375b6591d5940 TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/1276023003/ Base URL: https://chromium.googlesource.com/v8/v8@master Affected

[v8-dev] Re: Update V8 DEPS. (issue 1276023003 by v8-autor...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276023003/1 https://codereview.chromium.org/1276023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Remove spammy "Network distribution disabled" message from default config (issue 1279613005 by ad...@chromium.org)

2015-08-07 Thread ad...@chromium.org via codereview.chromium.org
Reviewers: Michael Achenbach (OOO), Description: Remove spammy "Network distribution disabled" message from default config R=machenb...@chromium.org Please review this at https://codereview.chromium.org/1279613005/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+

[v8-dev] Make run-tests.py warn when it's not testing anything (issue 1283513003 by ad...@chromium.org)

2015-08-07 Thread ad...@chromium.org via codereview.chromium.org
Reviewers: Michael Achenbach (OOO), Description: Make run-tests.py warn when it's not testing anything I've often been confused by an "all passed" run of the test script when it turned out that either all the tests I cared about were skipped or, more likely, I mistyped the name(s) of the tests I

[v8-dev] Re: Function declarations scope normally with --harmony_sloppy (issue 1282093002 by little...@chromium.org)

2015-08-07 Thread adamk
I like the idea of further-splitting the scoping options, putting the ES2015 semantics for function scoping behind their own flag (at least for the purposes of facilitating development). I don't think we're ready to give up on implementing the Appendix B behavior, though. https://codereview.ch

[v8-dev] Re: Delete outdated comment about a bug which was fixed three years ago (issue 1279203002 by little...@chromium.org)

2015-08-07 Thread adamk
lgtm https://codereview.chromium.org/1279203002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Function declarations scope normally with --harmony_sloppy (issue 1282093002 by little...@chromium.org)

2015-08-07 Thread littledan
On 2015/08/08 00:00:12, commit-bot: I haz the power wrote: Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8499) I should've waited for the tests to finish before mailing... I guess we

[v8-dev] Re: Function declarations scope normally with --harmony_sloppy (issue 1282093002 by little...@chromium.org)

2015-08-07 Thread littledan
Reviewers: adamk, Description: Function declarations scope normally with --harmony_sloppy In an initial attempt to implement sloppy mode lexical bindings, functions were made lexically scoped in sloppy mode. However, the ES2015 spec says that they need an additional hoisted var binding, and furt

[v8-dev] Delete outdated comment about a bug which was fixed three years ago (issue 1279203002 by little...@chromium.org)

2015-08-07 Thread littledan
Reviewers: adamk, Description: Delete outdated comment about a bug which was fixed three years ago R=adamk BUG=chromium:135066 LOG=N Please review this at https://codereview.chromium.org/1279203002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+1, -4 lines):

[v8-dev] Re: Issue 4335 in v8: large google maps performance regression in chrome canary (version 46)

2015-08-07 Thread codesite-noreply via v8-dev
Comment #9 on issue 4335 by bugdro...@chromium.org: large google maps performance regression in chrome canary (version 46) https://code.google.com/p/v8/issues/detail?id=4335#c9 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/df9822f45aec113e1f557de

[v8-dev] Re: [IC] Make SeededNumberDictionary::UpdateMaxNumberKey prototype aware (issue 1275363002 by jkumme...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1275363002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [IC] Make SeededNumberDictionary::UpdateMaxNumberKey prototype aware (issue 1275363002 by jkumme...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/df9822f45aec113e1f557de27c3b0f9e44a57cc4 Cr-Commit-Position: refs/heads/master@{#30076} https://codereview.chromium.org/1275363002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Group lexical context variables for faster look up. (issue 1281883002 by yang...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/a45ed17bb6aca02e940f13bbf456d66086ae Cr-Commit-Position: refs/heads/master@{#30075} https://codereview.chromium.org/1281883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Group lexical context variables for faster look up. (issue 1281883002 by yang...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1281883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [IC] Make SeededNumberDictionary::UpdateMaxNumberKey prototype aware (issue 1275363002 by jkumme...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275363002/1 https://codereview.chromium.org/1275363002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Issue 811 in v8: Implement destructuring

2015-08-07 Thread codesite-noreply via v8-dev
Comment #51 on issue 811 by bugdro...@chromium.org: Implement destructuring https://code.google.com/p/v8/issues/detail?id=811#c51 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/73ae23b5dc9bd816474688e74b9b768a09b9711f commit 73ae23b5dc9bd816474688e

[v8-dev] Re: [es6] Fix parsing of expressions in parameter lists (issue 1276273002 by rossb...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/73ae23b5dc9bd816474688e74b9b768a09b9711f Cr-Commit-Position: refs/heads/master@{#30074} https://codereview.chromium.org/1276273002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [es6] Fix parsing of expressions in parameter lists (issue 1276273002 by rossb...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1276273002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Group lexical context variables for faster look up. (issue 1281883002 by yang...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281883002/20001 https://codereview.chromium.org/1281883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Group lexical context variables for faster look up. (issue 1281883002 by yang...@chromium.org)

2015-08-07 Thread yangguo
On 2015/08/07 13:37:08, rossberg wrote: LGTM, I'm fine with landing this as a temporary hack, but can we have a couple of comments (and perhaps TODOs) clarifying why it was introduced? CC'ing Benedikt. https://codereview.chromium.org/1281883002/diff/1/src/scopeinfo.cc File src/scopeinfo.c

[v8-dev] Re: Fasterify JSObject::UnregisterPrototypeUser (issue 1276353004 by jkumme...@chromium.org)

2015-08-07 Thread yangguo
lgtm with comments. https://codereview.chromium.org/1276353004/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1276353004/diff/1/src/objects.cc#newcode7971 src/objects.cc:7971: if (WeakCell::cast(element)->cleared()) continue; Can we assert that we don't find

[v8-dev] Re: [IC] Make SeededNumberDictionary::UpdateMaxNumberKey prototype aware (issue 1275363002 by jkumme...@chromium.org)

2015-08-07 Thread yangguo
LGTM https://codereview.chromium.org/1275363002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1275363002/diff/1/src/objects.cc#newcode14647 src/objects.cc:14647: // TODO(verwaest): Remove this hack. Indeed! https://codereview.chromium.org/1275363002/ -- --

[v8-dev] Re: [es6] Fix parsing of expressions in parameter lists (issue 1276273002 by rossb...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276273002/20001 https://codereview.chromium.org/1276273002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Fasterify JSObject::UnregisterPrototypeUser (issue 1276353004 by jkumme...@chromium.org)

2015-08-07 Thread jkummerow
Reviewers: Yang, Description: Fasterify JSObject::UnregisterPrototypeUser When a (prototype) map registers as a user of its own prototype, it now remembers the index in that prototype's registry where it is listed. This remembered index is used on un-registration to find the right slot to clea

[v8-dev] Re: MIPS: mina_maxa, min_max and class_fmt tests fixup (issue 1276813004 by djordje.pe...@imgtec.com)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/46fafcd706c0c161013c4904b69af0061d983d6f Cr-Commit-Position: refs/heads/master@{#30073} https://codereview.chromium.org/1276813004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: MIPS: mina_maxa, min_max and class_fmt tests fixup (issue 1276813004 by djordje.pe...@imgtec.com)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1276813004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] [api] Delete non-maybe version of CompileModule (issue 1276353003 by ad...@chromium.org)

2015-08-07 Thread ad...@chromium.org via codereview.chromium.org
Reviewers: jochen (traveling - slow), Description: [api] Delete non-maybe version of CompileModule Also add a bigger warning to the header comment for the Maybe version. R=joc...@chromium.org Please review this at https://codereview.chromium.org/1276353003/ Base URL: https://chromium.googleso

[v8-dev] [es6] Add appropriate ToString call to String.prototype.normalize (issue 1282013002 by ad...@chromium.org)

2015-08-07 Thread ad...@chromium.org via codereview.chromium.org
Reviewers: Dan Ehrenberg, Description: [es6] Add appropriate ToString call to String.prototype.normalize R=little...@chromium.org BUG=v8:4304 LOG=n Please review this at https://codereview.chromium.org/1282013002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+4

[v8-dev] Re: Issue 4304 in v8: String.prototype.normalize should return abrupt completion from ToString(this) (object or Symbol)

2015-08-07 Thread codesite-noreply via v8-dev
Updates: Status: Started Owner: ad...@chromium.org Comment #3 on issue 4304 by ad...@chromium.org: String.prototype.normalize should return abrupt completion from ToString(this) (object or Symbol) https://code.google.com/p/v8/issues/detail?id=4304 (No comment was entered for t

[v8-dev] Re: MIPS: mina_maxa, min_max and class_fmt tests fixup (issue 1276813004 by djordje.pe...@imgtec.com)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276813004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276813004/20001 https://codereview.chromium.org/1276813004/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Reland "Test262 roll" (issue 1273883005 by little...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/62e07112fffd2b41ee93b456ede44c882b85cc1f Cr-Commit-Position: refs/heads/master@{#30072} https://codereview.chromium.org/1273883005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Reland "Test262 roll" (issue 1273883005 by little...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1273883005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Reland "Test262 roll" (issue 1273883005 by little...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273883005/1 https://codereview.chromium.org/1273883005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Reland "Test262 roll" (issue 1273883005 by little...@chromium.org)

2015-08-07 Thread adamk
lgtm https://codereview.chromium.org/1273883005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Reland "Test262 roll" (issue 1273883005 by little...@chromium.org)

2015-08-07 Thread littledan
Reviewers: adamk, Description: Reland "Test262 roll" Reland patch originally reviewed at https://codereview.chromium.org/1268553003/ This new patch marks a test [PASS, FAIL] since it passes on some platforms. Please review this at https://codereview.chromium.org/1273883005/ Base URL: https

[v8-dev] Re: Issue 1569 in v8: Implement Harmony Modules

2015-08-07 Thread codesite-noreply via v8-dev
Comment #29 on issue 1569 by ad...@chromium.org: Implement Harmony Modules https://code.google.com/p/v8/issues/detail?id=1569 This work is currently blocked on the completion of a specification for the Module Loader, which is being worked on in the WHATWG: https://github.com/whatwg/loader

[v8-dev] Re: [es6] Fix parsing of expressions in parameter lists (issue 1276273002 by rossb...@chromium.org)

2015-08-07 Thread adamk
lgtm https://codereview.chromium.org/1276273002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: mina_maxa, min_max and class_fmt tests fixup (issue 1276813004 by djordje.pe...@imgtec.com)

2015-08-07 Thread paul . lind
LGTM, thanks! https://codereview.chromium.org/1276813004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emai

[v8-dev] Re: Issue 4137 in v8: Support elements in the LookupIterator

2015-08-07 Thread codesite-noreply via v8-dev
Comment #59 on issue 4137 by raphael.kubo.da.co...@intel.com: Support elements in the LookupIterator https://code.google.com/p/v8/issues/detail?id=4137 I do: see the attached patch to cctest's test-accessors. It crashes on M45 and works elsewhere (basically with all commits outside that ran

[v8-dev] Re: test262 roll (issue 1268553003 by little...@chromium.org)

2015-08-07 Thread adamk
On 2015/08/07 06:41:15, Michael Achenbach (OOO) wrote: A revert of this CL (patchset #9 id:160001) has been created in https://codereview.chromium.org/1280903002/ by mailto:machenb...@chromium.org. The reason for reverting is: [Sheriff] Lacks one test expectation for http://build.chromium.or

[v8-dev] Re: Issue 2159 in v8: Add support for rest parameters

2015-08-07 Thread codesite-noreply via v8-dev
Comment #30 on issue 2159 by caitpott...@gmail.com: Add support for rest parameters https://code.google.com/p/v8/issues/detail?id=2159 This was unshipped temporarily, I'm hoping to land a change in the next week or 2 which will bring them back, though. -- You received this message because

[v8-dev] Re: Issue 4137 in v8: Support elements in the LookupIterator

2015-08-07 Thread codesite-noreply via v8-dev
Comment #58 on issue 4137 by jkumme...@chromium.org: Support elements in the LookupIterator https://code.google.com/p/v8/issues/detail?id=4137 #57: Do you have a repro for that? -- You received this message because this project is configured to send all issue notifications to this address.

[v8-dev] [GC] Remove FLAG_incremental_marking_steps (issue 1281923002 by mlippa...@chromium.org)

2015-08-07 Thread mlippautz
Reviewers: Hannes Payer, Message: As discussed this week, let's get rid of the flag. Description: [GC] Remove FLAG_incremental_marking_steps BUG= Please review this at https://codereview.chromium.org/1281923002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+3,

[v8-dev] Re: Issue 4137 in v8: Support elements in the LookupIterator

2015-08-07 Thread codesite-noreply via v8-dev
Comment #57 on issue 4137 by raphael.kubo.da.co...@intel.com: Support elements in the LookupIterator https://code.google.com/p/v8/issues/detail?id=4137 Hi Toon, Can at least 103675d68b77c125580f74b2dd12951127f4bc99 ("Replace Set*Callback with TransitionToAccessorPair") be cherry-picked int

[v8-dev] Re: [heap] Remove unused support for heap iterator size function. (issue 1281903002 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/eabb514278eef838aa8007558067194bd281b7fe Cr-Commit-Position: refs/heads/master@{#30071} https://codereview.chromium.org/1281903002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [heap] Remove unused support for heap iterator size function. (issue 1281903002 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1281903002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] [IC] Make SeededNumberDictionary::UpdateMaxNumberKey prototype aware (issue 1275363002 by jkumme...@chromium.org)

2015-08-07 Thread jkummerow
Reviewers: Yang, Description: [IC] Make SeededNumberDictionary::UpdateMaxNumberKey prototype aware Only walk the heap clearing KeyedStoreICs when the dictionary in question belongs to an object that's used as a prototype. This is a temporary mitigation until we have a way to clear such ICs witho

[v8-dev] Re: [heap] Remove unused support for heap iterator size function. (issue 1281903002 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281903002/1 https://codereview.chromium.org/1281903002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Issue 4363 in v8: OptimizedCodeSharing2 and OptimizedCodeSharing3 failing on ARM64 nosnap

2015-08-07 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Comment #2 on issue 4363 by mstarzin...@chromium.org: OptimizedCodeSharing2 and OptimizedCodeSharing3 failing on ARM64 nosnap https://code.google.com/p/v8/issues/detail?id=4363 Fixed by above change. -- You received this message because this project is configur

[v8-dev] Re: Issue 4363 in v8: OptimizedCodeSharing2 and OptimizedCodeSharing3 failing on ARM64 nosnap

2015-08-07 Thread codesite-noreply via v8-dev
Comment #1 on issue 4363 by bugdro...@chromium.org: OptimizedCodeSharing2 and OptimizedCodeSharing3 failing on ARM64 nosnap https://code.google.com/p/v8/issues/detail?id=4363#c1 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/e8a399c0a09b344b1f7d18

[v8-dev] Re: Speed up tests for optimized code sharing. (issue 1280973002 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/e8a399c0a09b344b1f7d18fc340ee2228f6efeec Cr-Commit-Position: refs/heads/master@{#30070} https://codereview.chromium.org/1280973002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Speed up tests for optimized code sharing. (issue 1280973002 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1280973002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Group lexical context variables for faster look up. (issue 1281883002 by yang...@chromium.org)

2015-08-07 Thread rossberg
LGTM, I'm fine with landing this as a temporary hack, but can we have a couple of comments (and perhaps TODOs) clarifying why it was introduced? CC'ing Benedikt. https://codereview.chromium.org/1281883002/diff/1/src/scopeinfo.cc File src/scopeinfo.cc (right): https://codereview.chromium.org/

[v8-dev] Re: Regression test for crbug 517455 (issue 1280953002 by rossb...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/651f55c573fec1734276cd5b69c0d1c9c5dc43d5 Cr-Commit-Position: refs/heads/master@{#30069} https://codereview.chromium.org/1280953002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Regression test for crbug 517455 (issue 1280953002 by rossb...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1280953002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Speed up tests for optimized code sharing. (issue 1280973002 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280973002/1 https://codereview.chromium.org/1280973002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: [heap] Remove unused IntrusiveMarking class. (issue 1278113004 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/56b32678d37b7b862a6e62c213a7859256325fda Cr-Commit-Position: refs/heads/master@{#30068} https://codereview.chromium.org/1278113004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [heap] Remove unused IntrusiveMarking class. (issue 1278113004 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1278113004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Speed up tests for optimized code sharing. (issue 1280973002 by mstarzin...@chromium.org)

2015-08-07 Thread yangguo
On 2015/08/07 13:17:17, Michael Starzinger wrote: lgtm. https://codereview.chromium.org/1280973002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscr

[v8-dev] Re: [heap] Remove unused IntrusiveMarking class. (issue 1278113004 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278113004/1 https://codereview.chromium.org/1278113004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Speed up tests for optimized code sharing. (issue 1280973002 by mstarzin...@chromium.org)

2015-08-07 Thread mstarzinger
Reviewers: Yang, Description: Speed up tests for optimized code sharing. Note that this tests performed unnecessary many iterations which led to long runtimes in debug mode and also caused flaky GCs during that would cause the optimized code map to be flushed and violated assumptions. R=yang...

[v8-dev] Re: [heap] Remove unused support for heap iterator size function. (issue 1281903002 by mstarzin...@chromium.org)

2015-08-07 Thread hpayer
On 2015/08/07 13:02:01, titzer wrote: On 2015/08/07 13:00:08, Michael Starzinger wrote: > Dead code is being dead. lgtm Lgtm https://codereview.chromium.org/1281903002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message be

[v8-dev] Re: [heap] Remove unused support for heap iterator size function. (issue 1281903002 by mstarzin...@chromium.org)

2015-08-07 Thread hpayer
On 2015/08/07 13:02:01, titzer wrote: On 2015/08/07 13:00:08, Michael Starzinger wrote: > Dead code is being dead. lgtm Lgtm https://codereview.chromium.org/1281903002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message be

[v8-dev] Re: [heap] Remove unused IntrusiveMarking class. (issue 1278113004 by mstarzin...@chromium.org)

2015-08-07 Thread hpayer
On 2015/08/07 12:56:14, Michael Starzinger wrote: Dead code is being dead. Lgtm lol https://codereview.chromium.org/1278113004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Group

[v8-dev] Re: Regression test for crbug 517455 (issue 1280953002 by rossb...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280953002/1 https://codereview.chromium.org/1280953002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Issue 4363 in v8: OptimizedCodeSharing2 and OptimizedCodeSharing3 failing on ARM64 nosnap

2015-08-07 Thread codesite-noreply via v8-dev
Status: Assigned Owner: mstarzin...@chromium.org Labels: Type-Bug Priority-Medium Hotlist-CD New issue 4363 by yang...@chromium.org: OptimizedCodeSharing2 and OptimizedCodeSharing3 failing on ARM64 nosnap https://code.google.com/p/v8/issues/detail?id=4363 http://build.chromium.org/p/client.v8

[v8-dev] Re: [heap] Remove unused IntrusiveMarking class. (issue 1278113004 by mstarzin...@chromium.org)

2015-08-07 Thread titzer
On 2015/08/07 12:56:14, Michael Starzinger wrote: Dead code is being dead. lgtm https://codereview.chromium.org/1278113004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v

[v8-dev] Re: [heap] Remove unused support for heap iterator size function. (issue 1281903002 by mstarzin...@chromium.org)

2015-08-07 Thread titzer
On 2015/08/07 13:00:08, Michael Starzinger wrote: Dead code is being dead. lgtm https://codereview.chromium.org/1281903002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v

[v8-dev] [heap] Remove unused support for heap iterator size function. (issue 1281903002 by mstarzin...@chromium.org)

2015-08-07 Thread mstarzinger
Reviewers: Hannes Payer, Message: Dead code is being dead. Description: [heap] Remove unused support for heap iterator size function. R=hpa...@chromium.org Please review this at https://codereview.chromium.org/1281903002/ Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-m

[v8-dev] Re: Version 4.4.63.30 (cherry-pick) (issue 1277943003 by u...@chromium.org)

2015-08-07 Thread hablich
On 2015/08/07 12:42:49, ulan wrote: Looks fine according to chromecrash for 2473. lgtm from this perspective. https://codereview.chromium.org/1277943003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subsc

[v8-dev] Re: Issue 4359 in v8: Crash in v8::internal::MemoryChunk::IsEvacuationCandidate on arm64 in mjsunit/strong/load-proxy.js

2015-08-07 Thread codesite-noreply via v8-dev
Comment #3 on issue 4359 by bugdro...@chromium.org: Crash in v8::internal::MemoryChunk::IsEvacuationCandidate on arm64 in mjsunit/strong/load-proxy.js https://code.google.com/p/v8/issues/detail?id=4359#c3 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8

[v8-dev] [heap] Remove unused IntrusiveMarking class. (issue 1278113004 by mstarzin...@chromium.org)

2015-08-07 Thread mstarzinger
Reviewers: Hannes Payer, Message: Dead code is being dead. Description: [heap] Remove unused IntrusiveMarking class. R=hpa...@chromium.org Please review this at https://codereview.chromium.org/1278113004/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+2, -70 li

[v8-dev] Re: [GC] Align behavior of JSProxy with JSObject when embedded in optimized code (issue 1270393003 by mlippa...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1270393003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [GC] Align behavior of JSProxy with JSObject when embedded in optimized code (issue 1270393003 by mlippa...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/a039ff2930cbe6881360925e4debc959c7db392a Cr-Commit-Position: refs/heads/master@{#30067} https://codereview.chromium.org/1270393003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Version 4.4.63.30 (cherry-pick) (issue 1277943003 by u...@chromium.org)

2015-08-07 Thread ulan
https://codereview.chromium.org/1277943003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, sen

[v8-dev] Version 4.4.63.30 (cherry-pick) (issue 1277943003 by u...@chromium.org)

2015-08-07 Thread u...@chromium.org via codereview.chromium.org
Reviewers: Hannes Payer, Description: Version 4.4.63.30 (cherry-pick) Merged d8ad147944bf761f322482f68b804454321ac245 Grow heap slowly after running memory reducer. R=hpa...@chromium.org BUG=515174 LOG=NO Please review this at https://codereview.chromium.org/1277943003/ Base URL: https://chr

[v8-dev] Re: Regression test for crbug 517455 (issue 1280953002 by rossb...@chromium.org)

2015-08-07 Thread mstarzinger
LGTM (rubber-stamped). https://codereview.chromium.org/1280953002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop recei

[v8-dev] Re: [GC] Align behavior of JSProxy with JSObject when embedded in optimized code (issue 1270393003 by mlippa...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270393003/1 https://codereview.chromium.org/1270393003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: [GC] Align behavior of JSProxy with JSObject when embedded in optimized code (issue 1270393003 by mlippa...@chromium.org)

2015-08-07 Thread hpayer
On 2015/08/07 12:22:42, ulan wrote: LGTM, good catch! Lgtm https://codereview.chromium.org/1270393003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To uns

[v8-dev] Regression test for crbug 517455 (issue 1280953002 by rossb...@chromium.org)

2015-08-07 Thread rossb...@chromium.org via codereview.chromium.org
Reviewers: Michael Starzinger, Description: Regression test for crbug 517455 Was fixed by https://chromium.googlesource.com/v8/v8/+/826f8da55fb868a365d047a4a653eb8ff2bfc14e R=mstarzin...@chromium.org BUG=517455 LOG=N Please review this at https://codereview.chromium.org/1280953002/ Base URL:

[v8-dev] Re: [GC] Align behavior of JSProxy with JSObject when embedded in optimized code (issue 1270393003 by mlippa...@chromium.org)

2015-08-07 Thread ulan
LGTM, good catch! https://codereview.chromium.org/1270393003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] [GC] Align behavior of JSProxy with JSObject when embedded in optimized code (issue 1270393003 by mlippa...@chromium.org)

2015-08-07 Thread mlippautz
Reviewers: ulan, Hannes Payer, Message: Fixes the issue Yang was seeing in v8:4359. Description: [GC] Align behavior of JSProxy with JSObject when embedded in optimized code With --harmony-proxies enabled, embedded pointers in optimized code can point to a JSProxy (via a cell). Since JSProxy

[v8-dev] [es6] Fix parsing of expressions in parameter lists (issue 1276273002 by rossb...@chromium.org)

2015-08-07 Thread rossb...@chromium.org via codereview.chromium.org
Reviewers: adamk, Description: [es6] Fix parsing of expressions in parameter lists Fixes the use of eval calls in strict parameter lists in particular. R=ad...@chromium.org BUG=v8:811 LOG=N Please review this at https://codereview.chromium.org/1276273002/ Base URL: https://chromium.googlesour

[v8-dev] Re: [heap] Make the Marking class all static. (issue 1269313003 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1269313003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Issue 2159 in v8: Add support for rest parameters

2015-08-07 Thread codesite-noreply via v8-dev
Comment #29 on issue 2159 by eor...@gmail.com: Add support for rest parameters https://code.google.com/p/v8/issues/detail?id=2159 That's what chromestatus.com's for: https://www.chromestatus.com/feature/5937087912083456 It says chrome 46. -- You received this message because this project

[v8-dev] Re: [heap] Make the Marking class all static. (issue 1269313003 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/07c3e41680b872fb842276d3c384bd4256a5d8d4 Cr-Commit-Position: refs/heads/master@{#30066} https://codereview.chromium.org/1269313003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Issue 2159 in v8: Add support for rest parameters

2015-08-07 Thread codesite-noreply via v8-dev
Comment #28 on issue 2159 by aneesiqb...@gmail.com: Add support for rest parameters https://code.google.com/p/v8/issues/detail?id=2159 I am on chrome 44.0.2403.125 and can't see this feature, any ideas when will this be implemented? -- You received this message because this project is con

[v8-dev] Re: [heap] Make the Marking class all static. (issue 1269313003 by mstarzin...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269313003/1 https://codereview.chromium.org/1269313003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: [heap] Make the Marking class all static. (issue 1269313003 by mstarzin...@chromium.org)

2015-08-07 Thread hpayer
On 2015/08/07 11:40:20, Michael Starzinger wrote: Lgtm :) https://codereview.chromium.org/1269313003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubs

[v8-dev] Re: [turbofan] Remove kInterpreterDispatch CallDescriptor kind in favor of flag. (issue 1268273003 by tit...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/8b56ec9ccc66496d631ca32d372480f0964cbb7d Cr-Commit-Position: refs/heads/master@{#30065} https://codereview.chromium.org/1268273003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [turbofan] Remove kInterpreterDispatch CallDescriptor kind in favor of flag. (issue 1268273003 by tit...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1268273003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Group lexical context variables for faster look up. (issue 1281883002 by yang...@chromium.org)

2015-08-07 Thread yang...@chromium.org via codereview.chromium.org
Reviewers: rossberg, Description: Group lexical context variables for faster look up. Currently, looking up a lexical context variable requires looking up the variable name and then checking its mode. This can be a bottleneck in Runtime_DeclareGlobals, even when no lexical context variables are

[v8-dev] Re: Issue 811 in v8: Implement destructuring

2015-08-07 Thread codesite-noreply via v8-dev
Comment #50 on issue 811 by bugdro...@chromium.org: Implement destructuring https://code.google.com/p/v8/issues/detail?id=811#c50 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/826f8da55fb868a365d047a4a653eb8ff2bfc14e commit 826f8da55fb868a365d047a

[v8-dev] [heap] Make the Marking class all static. (issue 1269313003 by mstarzin...@chromium.org)

2015-08-07 Thread mstarzinger
Reviewers: Hannes Payer, Description: [heap] Make the Marking class all static. R=hpa...@chromium.org Please review this at https://codereview.chromium.org/1269313003/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+8, -15 lines): M src/heap/heap.h M src/heap

[v8-dev] Re: [es6] Use strict arguments objects for destructured parameters (issue 1278783002 by rossb...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/826f8da55fb868a365d047a4a653eb8ff2bfc14e Cr-Commit-Position: refs/heads/master@{#30064} https://codereview.chromium.org/1278783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [es6] Use strict arguments objects for destructured parameters (issue 1278783002 by rossb...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1278783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [turbofan] Remove kInterpreterDispatch CallDescriptor kind in favor of flag. (issue 1268273003 by tit...@chromium.org)

2015-08-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268273003/1 https://codereview.chromium.org/1268273003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: [turbofan] Remove kInterpreterDispatch CallDescriptor kind in favor of flag. (issue 1268273003 by tit...@chromium.org)

2015-08-07 Thread mstarzinger
LGTM. I like it. https://codereview.chromium.org/1268273003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving e

  1   2   >