Reviewers: titzer,
Message:
Ben, please take a look, thanks.
Description:
[turbofan] Add control and effect inputs to RawMachineAssembler calls.
Calls should have control and effect inputs, which were previously missing
for RawMachineAssembler call operations. Add control and effect edges to
gr
Patchset 1 (id:??) landed as
https://crrev.com/7fc7957be57d1cdfb0b7e1d76bdee78f4699774f
Cr-Commit-Position: refs/heads/master@{#30243}
https://codereview.chromium.org/1289373004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1289373004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1302533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1289373004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1289373004/1
https://codereview.chromium.org/1289373004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
lgtm
https://codereview.chromium.org/1289373004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm with a question.
https://codereview.chromium.org/1230303005/diff/120001/src/execution.cc
File src/execution.cc (right):
https://codereview.chromium.org/1230303005/diff/120001/src/execution.cc#newcode418
src/execution.cc:418: if (isolate_->futex_wait_list_node()->waiting()) {
Could we perha
On 2015/08/19 02:55:32, Srikumar wrote:
mailto:sbo...@nvidia.com changed reviewers:
+ mailto:ar...@nvidia.com
LGTM
https://codereview.chromium.org/1287173004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 1 (id:??) landed as
https://crrev.com/9fc29357f601c4ded610fee59797cb75968c80a4
Cr-Commit-Position: refs/heads/master@{#30242}
https://codereview.chromium.org/1303573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1303573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/1286313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/b46f0e9f468dd69b79807790070290a55c49b29e
Cr-Commit-Position: refs/heads/master@{#30241}
https://codereview.chromium.org/1286313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1303573003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1303573003/1
https://codereview.chromium.org/1303573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Reviewers: Michael Achenbach (OOO),
Description:
Update V8 DEPS.
Rolling v8/third_party/android_tools to
9e9b6169a098bc19986e44fbbf65e4c29031e4bd
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1303573003/
Base URL: https://chromium.googlesource.com/v8/v8@
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1286313003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1286313003/1
https://codereview.chromium.org/1286313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
lgtm
https://codereview.chromium.org/1286313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1294513004/diff/160001/test/simdjs/testcfg.py
File test/simdjs/testcfg.py (right):
https://codereview.chromium.org/1294513004/diff/160001/test/simdjs/testcfg.py#newcode47
test/simdjs/testcfg.py:47: "--harmony --harmony-simd",
Note: we have only been testing the po
Comment #3 on issue 4218 by bugdro...@chromium.org: ToLength called
multiple times in %TypedArray%.prototype.set
https://code.google.com/p/v8/issues/detail?id=4218#c3
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/df999c9790e96a72a6c56e67182a144b0
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1237583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/df999c9790e96a72a6c56e67182a144b0e718591
Cr-Commit-Position: refs/heads/master@{#30240}
https://codereview.chromium.org/1237583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
On 2015/08/19 00:40:33, adamk wrote:
Haven't dug in yet, but to your issue with 'let []': I suspect you're just
testing in sloppy mode. Here are my results with this patched in:
$ d8 --harmony-destructuring -e 'let [x] = [42]; print(x)'
unnamed:1: ReferenceError: let is not defined
let [x] = [
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1237583005/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1237583005/40001
https://codereview.chromium.org/1237583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
lgtm!
https://codereview.chromium.org/1237583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
Wow, very well-tested.
https://codereview.chromium.org/1237583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Dan Ehrenberg, adamk,
Message:
PTAL, thanks.
Description:
Only evaluate length once in %TypedArray%.prototype.set
The ES6 spec for this function declares that ToLength
should only be called once. We were evaluating it multiple
times, so if length was an object with a valueOf method,
Haven't dug in yet, but to your issue with 'let []': I suspect you're just
testing in sloppy mode. Here are my results with this patched in:
$ d8 --harmony-destructuring -e 'let [x] = [42]; print(x)'
unnamed:1: ReferenceError: let is not defined
let [x] = [1]; print(x)
^
ReferenceError: let is no
lgtm
https://codereview.chromium.org/1287203006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Fixed
Comment #11 on issue 4118 by ad...@chromium.org: Object.getOwnPropertyNames
returns names in wrong order
https://code.google.com/p/v8/issues/detail?id=4118
Closing this in preference to issue 3056 (as this issue was originally
about indexed properties, which a
Updates:
Status: Available
Owner: ---
Cc: ad...@chromium.org
Labels: Area-Language Harmony
Comment #1 on issue 3056 by ad...@chromium.org: getOwnPropertyNames does
not return names in the insertion order
https://code.google.com/p/v8/issues/detail?id=3056
This i
Updated to HEAD, PTAL
https://codereview.chromium.org/1230303005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiv
On 2015/08/18 17:49:29, bbudge wrote:
I've split some of this patch into a separate issue:
https://codereview.chromium.org/1302513004/
This CL depends on that, which affects objects-inl.h and
objects-printer.cc.
That CL landed, and I rebased. PTAL
https://codereview.chromium.org/1294513004
Comment #10 on issue 4118 by mridg...@yahoo-inc.com:
Object.getOwnPropertyNames returns names in wrong order
https://code.google.com/p/v8/issues/detail?id=4118
I found another issue that mentions the same thing as what I found:
https://code.google.com/p/v8/issues/detail?id=3056&can=1&q=getO
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1302513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/f33d5717eb49cdc23a1780af69554fd9c7f3ecc8
Cr-Commit-Position: refs/heads/master@{#30239}
https://codereview.chromium.org/1302513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Comment #34 on issue 4124 by bugdro...@chromium.org: Implement SIMD.js
https://code.google.com/p/v8/issues/detail?id=4124#c34
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/f33d5717eb49cdc23a1780af69554fd9c7f3ecc8
commit f33d5717eb49cdc23a1780af695
Status: Untriaged
Owner:
New issue 4379 by je...@edagames.com: gcc5 defaults to
-Werror=strict-overflow and chokes on src/bignum.cc
https://code.google.com/p/v8/issues/detail?id=4379
I suggest as a simple fix, to change `int pos` to `uint pos` at
https://github.com/v8/v8-git-mirror/blob/
Comment #14 on issue by ad...@chromium.org: Drop the "escaped reserved
words as identifiers" compatibility measure
https://code.google.com/p/v8/issues/detail?id=
Firefox seems to have become overly-relaxed, as it now allows unicode
escapes to result in keywords where they are allow
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1302513004/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1302513004/40001
https://codereview.chromium.org/1302513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
lgtm
https://codereview.chromium.org/1302513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: WontFix
Comment #5 on issue 1723 by tit...@chromium.org: Deadlock when closing
debugger connection
https://code.google.com/p/v8/issues/detail?id=1723
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 (id:1) manually as
f644b71e75c565d0b4609e4ce01c512b85aa9ac5.
Description:
Disable regress-crbug-518748 on ARM
BUG=chromium:518748
TBR=mstarzin...@chromium.org
LOG=n
Committed:
https://chromium.googlesource.com/v8/v8/+/f644b71e75c565
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 (id:1) manually as
86439b3ae31c3a21ad7f7f7b3ac1fc99378c5b45 (tree was closed).
Description:
[test] Silence array bounds warning. GCC, I think you are wrong in this
case.
TBR=mstarzin...@chromium.org
BUG=
Committed:
https://chromi
LGTM (rubber-stamped).
https://codereview.chromium.org/1294163003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop recei
Patchset 1 (id:??) landed as
https://crrev.com/dacb3d76a7cb651f986bb08a590e001e3bf23fbb
Cr-Commit-Position: refs/heads/master@{#30236}
https://codereview.chromium.org/1293073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1293073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1299023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/d0bacc61e6930d97888bf747a76bcfa329995847
Cr-Commit-Position: refs/heads/master@{#30235}
https://codereview.chromium.org/1299023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Patchset 1 (id:??) landed as
https://crrev.com/e1ad02375a238e09de0bff1cf1554a7370d77ee8
Cr-Commit-Position: refs/heads/master@{#30234}
https://codereview.chromium.org/1295333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1295333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 (id:1) manually as
49d1004bfb94684f87b5523a42f85f2e22c6d31d (tree was closed).
Description:
Disable regress-crbug-518748 on debug
Seems to fail only on V8 Linux - debug - code serializer
(See
http://build.chromium.org/p/client.v8/bui
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1293073004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1293073004/1
https://codereview.chromium.org/1293073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
lgtm
https://codereview.chromium.org/1293073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Nick Bray (chromium), titzer,
Description:
Add a makefile option for wasm prototype.
BUG=None
TEST=manual
R=tit...@chromium.org,ncb...@chromium.org
LOG=N
Please review this at https://codereview.chromium.org/1293073004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
A
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1295333002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1295333002/1
https://codereview.chromium.org/1295333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
On 2015/08/18 17:53:25, Michael Starzinger wrote:
Empty string-search.cc is being empty.
lgtm
all red is all good
https://codereview.chromium.org/1295333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 1 (id:??) landed as
https://crrev.com/d2168c2de6ed7bab577b889ab413b03a2ca4a274
Cr-Commit-Position: refs/heads/master@{#30232}
https://codereview.chromium.org/1293053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1293053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1293053004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1293053004/1
https://codereview.chromium.org/1293053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Reviewers: titzer,
Message:
Empty string-search.cc is being empty.
Description:
Remove empty string-search.cc file.
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/1295333002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -22 lin
Reviewers: ,
Message:
This is still a work in progress. It was an attempt to put the logic for
this
into a more singular place. It didn't entirely work out that way.
My findings:
- The tracking of valid assignment targets from the original CL works a lot
better than this (but is much more sp
I've split some of this patch into a separate issue:
https://codereview.chromium.org/1302513004/
This CL depends on that, which affects objects-inl.h and objects-printer.cc.
https://codereview.chromium.org/1294513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gr
Comment #12 on issue 3491 by yang...@chromium.org: Debugger cannot evaluate
stack-allocated local variables from outer scopes.
https://code.google.com/p/v8/issues/detail?id=3491
hypothetical solution in #6 is not even enough. all existing context
objects would have to be replaced when we ch
Committed patchset #1 (id:1) manually as
10073c78578b04cc0abda4022b366ef0187576b1 (tree was closed).
https://codereview.chromium.org/1302593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to th
Reviewers: adamk,
Description:
[d8] Fix compile failure due to kMaxWorkers
R=ad...@chromium.org
Please review this at https://codereview.chromium.org/1302593002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -0 lines):
M src/d8.cc
Index: src/d8.cc
diff -
Updates:
Cc: durga.be...@chromium.org
Comment #11 on issue 3491 by kozyatins...@chromium.org: Debugger cannot
evaluate stack-allocated local variables from outer scopes.
https://code.google.com/p/v8/issues/detail?id=3491
Issue chromium:520364 has been merged into this issue.
--
You r
Reviewers: Jarin, Benedikt Meurer,
Message:
I split this off of https://codereview.chromium.org/1294513004/ to simplify
that
review. That CL will depend on this one.
PTAL
Description:
[simd.js] Macro-ize more SIMD code.
Use macros for SIMD get/set_lane, and print fns.
LOG=N
BUG=v8:4124
Ple
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1299023002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1299023002/20001
https://codereview.chromium.org/1299023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
LGTM.
https://codereview.chromium.org/1299023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1293053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: titzer,
Description:
Remove grab-bag includes of v8.h from runtime entries.
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/1293053004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+67, -68 lines):
M src/json-parser.h
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1284683004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/29e441422e288eac16d8ffd8caf7e56e8ed77638
Cr-Commit-Position: refs/heads/master@{#30230}
https://codereview.chromium.org/1284683004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Reviewers: Michael Starzinger,
Description:
[turbofan] Fix stack->stack double moves for pushing on ia32 and x64.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1299023002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+65,
Comment #16 on issue 3926 by rossb...@chromium.org: Let/const in CaseBlock
https://code.google.com/p/v8/issues/detail?id=3926
Ah, you are right. I managed to miss the part that this was no longer a
syntax error.
--
You received this message because this project is configured to send all
is
Updates:
Labels: -Priority-Low Priority-High
Comment #15 on issue 3926 by little...@chromium.org: Let/const in CaseBlock
https://code.google.com/p/v8/issues/detail?id=3926
I'd say this bug is high priority, since we are exposing the TDZ hole
value, which shouldn't be exposed to JS. I h
Comment #6 on issue 4378 by bi...@chromium.org:
mjsunit/regress/regress-crbug-501711 fails flakily with concurrent isolates
in v8::Shell::QuitOnce.
https://code.google.com/p/v8/issues/detail?id=4378
I saw the same flaky failure. It happens because one thread is running
while the other thr
Comment #15 on issue 4279 by bugdro...@chromium.org: Check failed: 0 ==
result in v8::base::DestroyNativeHandle
https://code.google.com/p/v8/issues/detail?id=4279#c15
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/41fa3573d53d0d1b45a3c08ef1cb53535
Reviewers: cbruni,
Message:
Please take a look, and CQ it if you like it.
Description:
[API] Check for NULL external data pointer in ArrayBuffer::New()
Embedders must not provide invalid pointers for external backing stores.
BUG=chromium:522128
LOG=n
R=cbr...@chromium.org
Please review this a
Committed patchset #1 (id:1)
https://codereview.chromium.org/1294913005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/41fa3573d53d0d1b45a3c08ef1cb53535dec4bf2
Cr-Commit-Position: refs/heads/master@{#30229}
https://codereview.chromium.org/1294913005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1284683004/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1284683004/20001
https://codereview.chromium.org/1284683004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1294913005/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1294913005/1
https://codereview.chromium.org/1294913005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Patchset 2 (id:??) landed as
https://crrev.com/ee4a639681931a3b90ebd08371be26d7f749e78d
Cr-Commit-Position: refs/heads/master@{#30228}
https://codereview.chromium.org/1293273005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1293273005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/f2796382d7c1a27fec53c1f7dc445181ee701c98
Cr-Commit-Position: refs/heads/master@{#30227}
https://codereview.chromium.org/1301583003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1301583003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1293273005/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1293273005/20001
https://codereview.chromium.org/1293273005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1301583003/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1301583003/40001
https://codereview.chromium.org/1301583003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
still lgtm
https://codereview.chromium.org/1301583003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Hannes Payer,
Description:
[heap] Fix comment in tracer.
BUG=
Please review this at https://codereview.chromium.org/1292583004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -4 lines):
M src/heap/gc-tracer.h
Index: src/heap/gc-tracer.h
diff --
Addressed. Thanks! Landing.
https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):
https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py#newcode145
PRESUBMIT.py:145: """Attempts to prevent inclusion in inline headers
into normal header
On 2015/08/18 1
lgtm
https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):
https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py#newcode145
PRESUBMIT.py:145: """Attempts to prevent inclusion in inline headers
into normal header
s/ in / of /?
https://codereview.ch
Committed patchset #3 (id:11)
https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Comment #27 on issue 4280 by bugdro...@chromium.org: Ignition interpreter
tracking bug
https://code.google.com/p/v8/issues/detail?id=4280#c27
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/f36cc258ffc89b15cd5f145e230bb2e36b45edf7
commit f36cc258
Patchset 3 (id:??) landed as
https://crrev.com/f36cc258ffc89b15cd5f145e230bb2e36b45edf7
Cr-Commit-Position: refs/heads/master@{#30226}
https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1294793002/11
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1294793002/11
https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 4 (id:??) landed as
https://crrev.com/a2462683b704e943862bbe90ddc26c2c24a74e97
Cr-Commit-Position: refs/heads/master@{#30225}
https://codereview.chromium.org/1294543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #4 (id:150001)
https://codereview.chromium.org/1294543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1294543006/150001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1294543006/150001
https://codereview.chromium.org/1294543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1294543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
1 - 100 of 222 matches
Mail list logo
