LGTM.
https://codereview.chromium.org/1316583003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1316633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/09b54808b1bdfac9c4dea93796ed8c2a7ffe2f9b
Cr-Commit-Position: refs/heads/master@{#30360}
https://codereview.chromium.org/1316633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Status: Fixed
Comment #7 on issue 4275 by hpa...@chromium.org: mjsunit/readonly crashes
flakily
https://code.google.com/p/v8/issues/detail?id=4275
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1316633002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1316633002/20001
https://codereview.chromium.org/1316633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #3 on issue 4203 by bugdro...@chromium.org: Validate asm.js code
and use type information
https://code.google.com/p/v8/issues/detail?id=4203#c3
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/09b54808b1bdfac9c4dea93796ed8c2a7ffe2f9b
lgtm
https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h#newcode1349
src/heap/heap.h:1349: inline void AddExternalString(String* string);
On 2015/08/25 14:18:30, Michael Starzinger
Patchset 2 (id:??) landed as
https://crrev.com/5d954d650688a2f069f0ff7693be57f5995bdf03
Cr-Commit-Position: refs/heads/master@{#30357}
https://codereview.chromium.org/1305393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Michael Lippautz, Yang,
Message:
Mike: Thanks for review!
Yang: PTAL at deserializer.
https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):
Reviewers: Hannes Payer,
Message:
More invasive than planned. The idea is that as soon as you call the GC with
non-default parameters you better have a reason why you do so.
The rest of the change is properly typing GC flags and making sure that the
both, the GCFlags and GCCallbackFlags, are
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1304873006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/d6f224f48aa5af63ba4bec8a079b512ca18957a0
Cr-Commit-Position: refs/heads/master@{#30358}
https://codereview.chromium.org/1304873006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Status: Assigned
Owner: mvstan...@chromium.org
Labels: Area-Runtime Type-Bug Priority-Medium
Comment #1 on issue 4391 by habl...@chromium.org: Fatal error in
HashMap::Initialize with --novector_ics
https://code.google.com/p/v8/issues/detail?id=4391
(No
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1305393003/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1305393003/60001
https://codereview.chromium.org/1305393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm w/ nits
https://codereview.chromium.org/988893003/diff/240001/include/v8-tracing.h
File include/v8-tracing.h (right):
https://codereview.chromium.org/988893003/diff/240001/include/v8-tracing.h#newcode32
include/v8-tracing.h:32: // These values must be in sync with macro
values in
Reviewers: Benedikt Meurer, Michael Starzinger,
Message:
I'd like some comments on the ia32 port.
Description:
Call JS functions via native context instead of js builtins object.
For this, we introduce a new runtime function intrinsic type, which
represent native context slots.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1315823002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1315823002/40001
https://codereview.chromium.org/1315823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #2 (id:60001)
https://codereview.chromium.org/1305393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1314903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):
https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc#newcode956
src/snapshot/serialize.cc:956: int id = source_.GetInt();
Reviewers: Michael Lippautz,
https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h#newcode1349
src/heap/heap.h:1349: inline void AddExternalString(String* string);
Wasn't sure whether
Reviewers: Michael Lippautz,
Description:
Add basic support for parallel compaction and flag.
BUG=524425
LOG=n
Please review this at https://codereview.chromium.org/1314903002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+44, -1 lines):
M
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1314903002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1314903002/20001
https://codereview.chromium.org/1314903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 2 (id:??) landed as
https://crrev.com/9fc0a77b856cc6b50bd3a492a98d230e3ba0b2e5
Cr-Commit-Position: refs/heads/master@{#30359}
https://codereview.chromium.org/1314903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1314903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Comment #15 on issue 4387 by m.go...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
Re #14: Ah, ok then, nothing to backport for the Node sake then; maybe
they'll patch it on their side if the fix is a one-liner.
For
Try jobs failed on following builders:
v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5202)
https://codereview.chromium.org/1315823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
lgtm
https://codereview.chromium.org/1304873006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1304873006/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1304873006/20001
https://codereview.chromium.org/1304873006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1314863003/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1314863003/diff/40001/src/heap/heap.cc#newcode825
src/heap/heap.cc:825: Heap::kMakeHeapIterableMask |
Heap::kReduceMemoryFootprintMask,
Let's rename this
Michael would you mind a look, this is a reland
https://codereview.chromium.org/1315823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
+yang for debug/*
https://codereview.chromium.org/1314863003/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1314863003/diff/40001/src/heap/heap.cc#newcode825
src/heap/heap.cc:825: Heap::kMakeHeapIterableMask |
Heap::kReduceMemoryFootprintMask,
On
Committed patchset #1 (id:1)
https://codereview.chromium.org/1311613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/268420af847e5edb5c8114ad7d8c20770cb16461
Cr-Commit-Position: refs/heads/master@{#30369}
https://codereview.chromium.org/1311613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Addressed feedback.
https://codereview.chromium.org/1311983002/diff/80001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
https://codereview.chromium.org/1311983002/diff/80001/src/compiler/register-allocator.cc#newcode2027
LGTM with comments.
On a related note: Please make sure that your CL description lines fit
within 80
characters.
https://codereview.chromium.org/1311983002/diff/80001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
Reviewers: Weiliang,
Message:
PTAL.
Description:
X87: Correctify instanceof and make it optimizable.
port 5d875a57fa2e65c1a4a6b50aeb23c38299c3cfbc (r30342).
original commit message:
The previous hack with HInstanceOfKnownGlobal was not only slower,
but also very brittle and required
Reviewers: Michael Achenbach (OOO),
Description:
Update V8 DEPS.
Rolling v8/third_party/icu to 6b3ce817f8e828c3b7a577d2395f0882eb56ef18
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1311613003/
Base URL: https://chromium.googlesource.com/v8/v8@master
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1311613003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1311613003/1
https://codereview.chromium.org/1311613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1311983002/11
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1311983002/11
https://codereview.chromium.org/1311983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 2 (id:??) landed as
https://crrev.com/0ee4b473681f3059a3da303ceb6fe23eef37aed3
Cr-Commit-Position: refs/heads/master@{#30370}
https://codereview.chromium.org/1311983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:11)
https://codereview.chromium.org/1311983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: rossberg, titzer,
Description:
Visit AST Property nodes as expressions in AstExpressionVisitor.
Left out by mistake, correcting.
BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-ast-expression-visitor, test-typing-reset
R=rossb...@chromium.org,tit...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1300813005/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1300813005/40001
https://codereview.chromium.org/1300813005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
PTAL
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc#newcode116
src/ast-expression-visitor.cc:116: VisitExpression(label);
On 2015/08/25
Friendly ping.
https://codereview.chromium.org/1303013007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Patchset 3 (id:??) landed as
https://crrev.com/e4d6f1dec101b6a148420c4e3e9330536de6ae9e
Cr-Commit-Position: refs/heads/master@{#30344}
https://codereview.chromium.org/1313513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1313513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h#newcode1399
src/heap/heap.h:1399: void StartIncrementalMarking(int gc_flags,
Can we make change the int gc_flags to an enum, you can
Hannes, pretty please
https://codereview.chromium.org/1313023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1313513003/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1313513003/40001
https://codereview.chromium.org/1313513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Hablich,
Description:
Reship arrow functions
...in canary.
This reverts commit c75af23299ec948cf2d809e8aa86b2c43184cde3.
R=habl...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1319443002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
lgtm
https://codereview.chromium.org/1313513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1316633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1311163002/diff/1/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1311163002/diff/1/src/scopes.h#newcode133
src/scopes.h:133: bool is_optional, bool is_rest, bool* is_duplicate);
On 2015/08/24 17:51:00, adamk wrote:
Two bools in a row
Reviewers: Yang,
Message:
PTAL
Description:
Array.prototype.unshift builtin improvements
Moving unshift to ElementAccessor and increasing the range of arguments
handled directly in C++, namely directly supporting FastDoubleElementsKind.
This should yield a factor 19 speedup for unshift on fast
On 2015/08/25 08:40:03, Michael Lippautz wrote:
Is the blink counterpart ready?
Yes, the blink side CL has been landed.
https://codereview.chromium.org/1313023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1319443002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1319443002/1
https://codereview.chromium.org/1319443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: haraken,
Message:
Is the blink counterpart ready?
Description:
[heap] Report proper GC type in prologue/eplilogue callbacks.
Followup to https://codereview.chromium.org/1288683005
BUG=chromium:521946
Please review this at https://codereview.chromium.org/1313023002/
Base URL:
On 2015/08/25 08:37:46, rossberg wrote:
lgtm
https://codereview.chromium.org/1319443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
lgtm
https://codereview.chromium.org/1313023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Message:
PTAL
https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h#newcode1399
src/heap/heap.h:1399: void StartIncrementalMarking(int gc_flags,
On 2015/08/25
Reviewers: Hannes Payer,
Message:
Hannes: PTAL
Andreas, Bill: FYI
Description:
[crankshaft] DCE must not eliminate (observable) math operations.
The HUnaryMathOperation cannot be eliminated in general, because the
spec requires a ToNumber conversion on the input, which is observable
of course.
On 2015/08/25 08:29:53, cbruni wrote:
PTAL
lgtm.
https://codereview.chromium.org/1311343002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
An ingenious solution!
LGTM.
https://codereview.chromium.org/1314623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: Michael Starzinger, Weiliang, rmcilroy,
Message:
PTAL.
Description:
X87: [Interpreter] Pass context to interpreter bytecode handlers and add
LoadConstextSlot
For X87 platform, it has the same general register as ia32 and it will
spill
the
context to the stack too.
port
Try jobs failed on following builders:
v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/7956)
https://codereview.chromium.org/1300813005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Reviewers: rossberg,
Message:
A reapplication of https://codereview.chromium.org/1286383005, now that the
rebaseline patch landed on the Blink side.
Description:
Parse arrow functions at proper precedence level
BUG=v8:4211
LOG=Y
R=rossb...@chromium.org
Please review this at
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1313023002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1313023002/1
https://codereview.chromium.org/1313023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc#newcode116
src/ast-expression-visitor.cc:116: VisitExpression(label);
Why is the label
Patchset 1 (id:??) landed as
https://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39
Cr-Commit-Position: refs/heads/master@{#30343}
https://codereview.chromium.org/1307413003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1307413003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Comment #1 on issue 4389 by bugdro...@chromium.org: Crankshaft optimization
of inlined Math operators generates wrong code
https://code.google.com/p/v8/issues/detail?id=4389#c1
The following revision refers to this bug:
Updates:
Status: Fixed
Cc: habl...@chromium.org
Comment #2 on issue 4389 by bmeu...@chromium.org: Crankshaft optimization
of inlined Math operators generates wrong code
https://code.google.com/p/v8/issues/detail?id=4389
This might cause performance regressions, so we might
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24 16:55:47, Michael Starzinger wrote:
On 2015/08/25 18:12:09, Michael Starzinger wrote:
Essentially one high-level comment/suggestion. Happy to discuss in person
and/or
be convinced otherwise. Would also be interested in what Benedikt thinks
about
this.
https://codereview.chromium.org/1306993003/diff/1/src/ast.h
File
ptal
https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc#newcode235
src/ast-expression-visitor.cc:235: void
Essentially one high-level comment/suggestion. Happy to discuss in person
and/or
be convinced otherwise. Would also be interested in what Benedikt thinks
about
this.
https://codereview.chromium.org/1306993003/diff/1/src/ast.h
File src/ast.h (right):
Committed patchset #2 (id:40001)
https://codereview.chromium.org/1311163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Comment #14 on issue 2160 by bugdro...@chromium.org: Add support for
default parameters
https://code.google.com/p/v8/issues/detail?id=2160#c14
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/0b3b72671e62234dffd75c909fcb77c8bd60c7fc
commit
Patchset 2 (id:??) landed as
https://crrev.com/0b3b72671e62234dffd75c909fcb77c8bd60c7fc
Cr-Commit-Position: refs/heads/master@{#30361}
https://codereview.chromium.org/1311163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: adamk,
Description:
Unship TypedArray.map method
The TypedArray.map method breaks a particular Chrome app, which
conditionally
monkey-patches in an unrelated function with the same name, but only if that
property does not exist. The developer already has a fix, but it is not
PTAL, added load functions for unsigned types. Verified the behavior on my
local
machine by turning off the polyfill. CL in progress to add store functions
as
well - the polyfill tests can then be turned off.
https://codereview.chromium.org/1302133002/diff/60001/src/runtime/runtime-simd.cc
+littledan
https://codereview.chromium.org/1307943007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm % nits
https://codereview.chromium.org/1312613003/diff/40001/src/full-codegen/full-codegen.cc
File src/full-codegen/full-codegen.cc (right):
https://codereview.chromium.org/1312613003/diff/40001/src/full-codegen/full-codegen.cc#newcode1601
src/full-codegen/full-codegen.cc:1601:
lgtm
https://codereview.chromium.org/1311163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1311163002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1311163002/40001
https://codereview.chromium.org/1311163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
LGTM (rubber-stamp on compiler).
https://codereview.chromium.org/1315823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
LGTM
https://codereview.chromium.org/1312953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/98b56f0da6ad66ecc70de45e843636fd13083bf3
Cr-Commit-Position: refs/heads/master@{#30346}
https://codereview.chromium.org/1319443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1319443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/08/24 19:51:52, titzer wrote:
LGTM.
I wonder whether we can know the code kind upfront, even if the code object
does
not exist yet. And where do we need the code kind when calling into a code
object that does not yet exist?
https://codereview.chromium.org/1308393003/
--
--
v8-dev
Failed to apply patch for src/builtins.cc:
While running git apply --index -3 -p1;
error: patch failed: src/builtins.cc:176
error: repository lacks the necessary blob to fall back on 3-way merge.
error: src/builtins.cc: patch does not apply
Patch: src/builtins.cc
Index:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1315823004/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1315823004/1
https://codereview.chromium.org/1315823004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h#newcode1681
src/heap/heap.h:1681:
On 2015/08/25 09:21:20, Hannes Payer wrote:
The local variable is just used within heap.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1314853002/11
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1314853002/11
https://codereview.chromium.org/1314853002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Michael Lippautz,
Description:
[heap] Prevent direct access to StoreBuffer.
R=mlippa...@chromium.org
Please review this at https://codereview.chromium.org/1317553002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+34, -39 lines):
M src/assembler.cc
lgtm, one nit
https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h#newcode1681
src/heap/heap.h:1681:
The local variable is just used within heap. The getter/setter are not
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1311343002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
1 - 100 of 255 matches
Mail list logo
