[v8-dev] Re: [es6] parse destructuring assignment (issue 1309813007 by caitpotte...@gmail.com)

On 2015/11/25 01:41:13, Yang wrote: On 2015/11/25 00:04:51, caitp wrote: > On 2015/11/24 21:37:29, caitp wrote: > > +yang, do you have an idea what would cause the DCHECK failure in > > VerifyRecompiledCode()? It doesn't seem to break the code when DCHECKS are > > disabled. > > More context,

[v8-dev] Re: [es6] parse destructuring assignment (issue 1309813007 by caitpotte...@gmail.com)

On 2015/11/25 00:04:51, caitp wrote: On 2015/11/24 21:37:29, caitp wrote: > +yang, do you have an idea what would cause the DCHECK failure in > VerifyRecompiledCode()? It doesn't seem to break the code when DCHECKS are > disabled. More context, old_target->kind() == BUILTIN, while

[v8-dev] Re: [es6] parse destructuring assignment (issue 1309813007 by caitpotte...@gmail.com)

+yang, do you have an idea what would cause the DCHECK failure in VerifyRecompiledCode()? It doesn't seem to break the code when DCHECKS are disabled. https://codereview.chromium.org/1309813007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: [es6] parse destructuring assignment (issue 1309813007 by caitpotte...@gmail.com)

Thanks for the comments --- I think the various AST visitor questions I asked are probably responsible for the failing test case, so I'm going to see if I can get that fixed. https://codereview.chromium.org/1309813007/diff/410001/src/expression-classifier.h File src/expression-classifier.h

[v8-dev] Re: [es6] parse destructuring assignment (issue 1309813007 by caitpotte...@gmail.com)

Overall I really do prefer putting this stuff in Assignment. A few questions about other additions, but I think this is on the right track. https://codereview.chromium.org/1309813007/diff/410001/src/expression-classifier.h File src/expression-classifier.h (right):

[v8-dev] Re: [es6] parse destructuring assignment (issue 1309813007 by caitpotte...@gmail.com)

Got the test262 run passing most of the destructuring assignment tests (remaining ones that are still bad are all related to SetFunctionName, which isn't done yet in V8) https://codereview.chromium.org/1309813007/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [es6] parse destructuring assignment (issue 1309813007 by caitpotte...@gmail.com)

Got the test262 run passing most of the destructuring assignment tests (remaining ones that are still bad are all related to SetFunctionName, which isn't done yet in V8) https://codereview.chromium.org/1309813007/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Exposing more heap information in the HeapStatistics API

Hello v8-dev I'm interested in assessing how close to the maximum heap size the old generation has expanded. Neither the HeapStatistics nor the newer HeapSpaceStatistics structures include this information (although HeapStatistics does provide heap_size_limit(), it provides a total

[v8-dev] Exposing more heap information in the HeapStatistics API

Hello v8-dev I'm interested in assessing how close to the maximum heap size the old generation has expanded. Neither the HeapStatistics nor the newer HeapSpaceStatistics structures include this information (although HeapStatistics does provide heap_size_limit(), it provides a total

[v8-dev] Re: [es6] parse destructuring assignment (issue 1309813007 by caitpotte...@gmail.com)

So, there are still some mixups in the AST visitors, and it would probably be a good idea to get feedback on the design just to make sure I actually understood what you were asking for. https://codereview.chromium.org/1309813007/diff/410001/src/ast-expression-visitor.cc File

Re: [v8-dev] CpuFeature

I'm porting V8 to SPARC El martes, 24 de noviembre de 2015, 10:26:07 (UTC+1), Yang Guo escribió: > > What's the motivation to this? Three unused bits seems fine, when we need > none. > > Yang > > On Tue, Nov 24, 2015 at 10:18 AM > wrote: > >> The CpuFeature enum in

[v8-dev] CpuFeature

The CpuFeature enum in src/globals.h is almost full, NUMBER_OF_CPU_FEATURES is now 29 (of 32) There is almost no room for another port (to another CPU) Is it possible to make more room there? Maybe changing the size of the supported_ memember variable at the CpuFeatures class in assembler.h.

Re: [v8-dev] CpuFeature

What's the motivation to this? Three unused bits seems fine, when we need none. Yang On Tue, Nov 24, 2015 at 10:18 AM wrote: > The CpuFeature enum in src/globals.h is almost > full, NUMBER_OF_CPU_FEATURES is now 29 (of 32) > There is almost no room for another port (to