Re: [v8-dev] optimise Math.floor(x/y) to use integer divisiion for specific divisor.... (issue 9638018)

https://chromiumcodereview.appspot.com/9638018/diff/13001/src/utils.h File src/utils.h (right): https://chromiumcodereview.appspot.com/9638018/diff/13001/src/utils.h#newcode112 src/utils.h:112: const DivMagicNumbers DivMagicNumberFor625 = {0x68db8bad, 8}; Fair question! I actually noticed a non-

Re: [v8-dev] optimise Math.floor(x/y) to use integer divisiion for specific divisor.... (issue 9638018)

https://chromiumcodereview.appspot.com/9638018/diff/13001/src/utils.h File src/utils.h (right): https://chromiumcodereview.appspot.com/9638018/diff/13001/src/utils.h#newcode112 src/utils.h:112: const DivMagicNumbers DivMagicNumberFor625 = {0x68db8bad, 8}; We can generate optimized code for numbe

Re: [v8-dev] optimise Math.floor(x/y) to use integer divisiion for specific divisor.... (issue 9638018)

I agree with your comments. It is great if you can fix them and land. Thanks, Alexandre http://codereview.chromium.org/9638018/diff/13001/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/9638018/diff/13001/src/arm/lithium-arm.cc#newcode1358 src/arm/li

Re: [v8-dev] optimise Math.floor(x/y) to use integer divisiion for specific divisor.... (issue 9638018)

Hello, Any news on this? Thanks, Alexandre https://chromiumcodereview.appspot.com/9638018/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

Re: [v8-dev] Adding missing SetCC before conditional branch. (issue 9950015)

No sorry. I can try to create one if you want. Alexandre On Mon, Apr 2, 2012 at 4:26 PM, wrote: > Do you have a unit test that demonstrates a problem with the old code? > > > https://chromiumcodereview.appspot.com/9950015/ > > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.g

Re: [v8-dev] optimise Math.floor(x/y) to use integer divisiion for specific divisor.... (issue 9638018)

Thanks for the review. I addressed your comments and created an issue (2038) for the implementation for other archs. http://code.google.com/p/v8/issues/detail?id=2038 The updated patch should be uploaded soon. Alexandre http://codereview.chromium.org/9638018/diff/1/src/arm/lithium-codegen-a

Re: [v8-dev] optimise Math.floor(x/y) to use integer divisiion for specific divisor.... (issue 9638018)

ok! On Tue, Mar 20, 2012 at 10:27 AM, wrote: > On 2012/03/09 11:39:09, danno wrote: >> >> Adding Florian, who should review this > > > I did not forget about this, but currently have a large backlog of code > reviews > and open issues. Will have a look soon. > > https://chromiumcodereview.appspo

Re: [v8-dev] optimise Math.floor(x/y) to use integer divisiion for specific divisor.... (issue 9638018)

Here is the extracted patch. I micro-benchmarked the different cases handled by the previous patch. It turns out that the integer division routine is generally slower than transitioning to VFP, so I removed that. I wished we had a SDIV... So on ARM we only handles division by a some constant diviso

Re: [v8-dev] Optimise code for bitwise usage... (issue 9301041)

arate CL to extend the well known '| 0' trick to the division operation. > > Thanks, > Florian > Thanks, Alexandre > > Den 28. feb. 2012 12.10 skrev Alexandre Rames : > > Any comments or ideas about this? >> >> Alexandre >> >> >>

Re: [v8-dev] Optimise code for bitwise usage... (issue 9301041)

Any comments or ideas about this? Alexandre On Fri, Feb 3, 2012 at 1:08 PM, Alexandre Rames wrote: > Hello, > > Sorry for the late answer. > > Although the patch locally improves a few code segments, there are no > observable performance gain on the usual benchmarks. > The

Re: [v8-dev] Optimise code for bitwise usage... (issue 9301041)

> qualified to review what you've done. Can you please remind me which of the > benchmarks you found this to help on? > > Thanks, > Danno > > > On Tue, Jan 31, 2012 at 4:42 PM, Alexandre Rames < > alexandre.ra...@gmail.com> wrote: > >> Hello, >

Re: [v8-dev] Optimise code for bitwise usage... (issue 9301041)

Hello, A few details to help the reviewers. - The hydrogen level optimization to optimize HBitwise instructions away when canonicalizing has been moved down to Lithium level. Removing the HBitwise instruction loses information on how the inputs are used and prevents from recognizing patterns li

[v8-dev] Re: Improve register allocation for Lithium representation changes on ARM... (issue 9207006)

Thanks for the review. The updated patch should be uploaded soon. http://codereview.chromium.org/9207006/diff/1/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/9207006/diff/1/src/arm/lithium-arm.cc#newcode1628 src/arm/lithium-arm.cc:1628: LOperand* va

[v8-dev] Re: r10210 committed - Port Math.pow inlining to ARM....

Hello, This commit breaks the v8 raytrace benchmark on ARM. Could you have a look? I'll have a look as well. Thanks, Alexandre On Wed, Dec 7, 2011 at 5:09 PM, wrote: > Revision: 10210 > Author:   yang...@chromium.org > Date:     Wed Dec  7 08:55:00 2011 > Log:      Port Math.pow inlining to A

Re: [v8-dev] Re: Issue 1840 in v8: High num of deopts for attached production code from game engine

Hello, Concerning your comment: "What we really should do is to recognize that the result is always used as an integer, avoiding deopts when the modulus is non-zero or some kind of overflow happens [...]" I have a patch doing this optimization in hydrogen when the result is used in bitwise operat

[v8-dev] Re: Propagate and combine constants in Hydrogen (issue 8473002)

Hello, If things are ok with the CLA now, can we push this? Thanks, Alexandre On Mon, Nov 7, 2011 at 11:10 PM, wrote: > Adding Kevin. Please don't commit until we clarify signing of the CLA. > > http://codereview.chromium.org/8473002/ > -- v8-dev mailing list v8-dev@googlegroups.com http://

[v8-dev] Re: Propagate and combine constants in Hydrogen (issue 8473002)

http://codereview.chromium.org/8473002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): http://codereview.chromium.org/8473002/diff/1/src/flag-definitions.h#newcode124 src/flag-definitions.h:124: DEFINE_bool(use_constant_propagation, true, "use hydrogen constant propagation") R

Re: [v8-dev] Propagate and combine constants in Hydrogen (issue 8473002)

It works with a fixed version of NewNumberFromInt. The updated patch should be uploaded on Monday. On Fri, Nov 4, 2011 at 3:24 PM, Alexandre Rames wrote: > Ok I think I just found the error... > FACTORY->NewNumberFromInt(val) > can allocate HeapNumbers if the val does not fit a S

Re: [v8-dev] Propagate and combine constants in Hydrogen (issue 8473002)

is the place that allocates the number which later > fails the assertion? > > -- > Vyacheslav Egorov > > > On Fri, Nov 4, 2011 at 4:17 PM, Alexandre Rames > wrote: > >> I am passing the TENURED flag to allocate in the old space: >> HConstant(FACTORY->NewNumber(v

Re: [v8-dev] Propagate and combine constants in Hydrogen (issue 8473002)

I am passing the TENURED flag to allocate in the old space: HConstant(FACTORY->NewNumber(val, TENURED), \ + Representation::Double())Down the call chain Heap::AllocateHeapNumber(double, PretenureFlag) uses the OLD_DATA_SPACE. Isn't that the correct? Alexandre On Fri, Nov 4, 2011 at 3:03 PM, Vyach

[v8-dev] Re: ARM: Fast path for compare against constant. (issue 7489045)

For your information, just a comment about cmp vs tst on ARM. Alexandre http://codereview.chromium.org/7489045/diff/27001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/7489045/diff/27001/src/ia32/lithium-codegen-ia32.cc#newcode15

[v8-dev] Re: ARM: Fast path for compare against constant. (issue 7489045)

Thanks!! On Thu, Oct 20, 2011 at 11:28 AM, wrote: > LGTM. > > Committed as r9718, using code review http://codereview.chromium.** > org/8352040/ . > > Sorry it took so long. > > > http://codereview.chromium.**org/7489045/diff/27001/src/** > ia32/lithium-c

[v8-dev] Re: ARM: Fast path for compare against constant. (issue 7489045)

Thanks for the comments. The new patch will be uploaded on Monday. I tested it on ia32 and it works fine. There might be a better way to handle the double case, but I don't how how to handle that for ia32/x64. Again I could not test the x64 code. If minor changes are needed, could you please

[v8-dev] Re: ARM: Fast path for compare against constant. (issue7489045)

Yes please review it! Please have a look at the previous comments concerning the test I could perform. Thanks! Alexandre On Thu, Aug 11, 2011 at 10:56 AM, wrote: > Is this issue still live? Shall I review it? > > http://codereview.chromium.**org/7489045/

[v8-dev] Re: r8774 - Check for phi-uses of arguments object before eliminating dead phi's....

Hello, This commit triggered an important regression in v8/EarleyBoyer on both ARM and Intel. Are you aware of the issue? Is someone looking at it? Thanks! Alexandre On Tue, Aug 2, 2011 at 10:34 AM, wrote: > Revision: 8774 > Author: vego...@chromium.org > Date: Tue Aug 2 02:32:28 2011

[v8-dev] Re: ARM: Fast path for compare against constant. (issue7489045)

I ported the code to ia32 and x64. Note that I could not perform any tests for x64 as I do not have a 64-bit machine handy. Can you have a look at the use of LCodeGen::TokenToCondition in LCodeGen::DoCmpIDAndBranch? I fixed the use of 'instr->is_double()' for the 'is_unsigned' parameter on ARM.

[v8-dev] Re: Crankshaft support for FixedDoubleArrays (issue7350021)

Three possible minor possible optimizations on ARM. Alexandre http://codereview.chromium.org/7350021/diff/16001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/7350021/diff/16001/src/arm/lithium-codegen-arm.cc#newcode2458 src/arm/lithi

Re: [v8-dev] [v8] r8535 committed - Add support for lazy deoptimization from deferred stack checks...

Hello, This commit breaks compilation on ARM in release mode. Adding USE(code_generated); will fix the unused variable error. Compilation output: cc1plus: warnings being treated as errors src/arm/lithium-codegen-arm.cc: In member function 'bool v8::internal::LCodeGen::GenerateDeferredCode()': sr

Re: [v8-dev] Re: Temporarily add more test output to help locate test failure (issue7250002)

Hello, I recently spotted that the disassembler can fail when trying to disassemble the deoptimization jump table. Would that be the cause of a bug you are looking at? This is because some data is interleaved within the code (via Assembler::dd) in LCodeGen::GenerateDeoptJumpTable. Currently there

[v8-dev] Re: ARM: Improve register allocation and constraints.... (issue7148018)

Thanks for the comments. A separate patch for preserving the callee-saved double registers will be uploaded. Alexandre http://codereview.chromium.org/7148018/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/7148018/diff/1/src/arm/assembler-ar

[v8-dev] Re: [Arguments] Port fast arguments creation stubs to X64 and ARM. (issue7024047)

A few small comments. I haven't tested the patch yet. How does it behave on ARM? Regards, Alexandre http://codereview.chromium.org/7024047/diff/8001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7024047/diff/8001/src/arm/code-stubs-arm.cc#ne

[v8-dev] Re: Optimise the deoptimisation check to improve performance on modern ARM cores.... (issue7021007)

I addressed these new comments. The updated patch should be uploaded soon. Alexandre http://codereview.chromium.org/7021007/diff/11004/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/7021007/diff/11004/src/arm/assembler-arm.h#newcode1223 src/arm/ass

[v8-dev] Re: Optimise the deoptimisation check to improve performance on modern ARM cores.... (issue7021007)

I could actually reproduce failures on Mozilla Date tests, and the updated patch does fix them. As assumed, this happened because we forgot to block the constant pool emission during the jump table emission. Alexandre On Tue, May 17, 2011 at 3:41 PM, wrote: > We couldn't reproduce the failure,

[v8-dev] Re: Optimise the deoptimisation check to improve performance on modern ARM cores.... (issue7021007)

Thanks for the comments. The updated patch should be uploaded soon. Alexandre http://codereview.chromium.org/7021007/diff/6002/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/7021007/diff/6002/src/arm/lithium-codegen-arm.cc#newcode263

[v8-dev] Re: Optimise the deoptimisation check to improve performance on modern ARM cores.... (issue7021007)

Thanks for the review Søren. I did not know about the x64 jump table. I refactored the code to use the same mechanism, generating the table at the end of the code as you suggested. This is indeed simpler. The updated patch should be uploaded soon. Alexandre On 2011/05/16 07:26:39, Søren G

Re: [v8-dev] [v8] r7675 committed - Support Float64Arrays...

Thanks for fixing it! Alexandre On Thu, Apr 21, 2011 at 10:54 AM, Jakob Kummerow wrote: > > On Thu, Apr 21, 2011 at 11:50 AM, Alexandre Rames < > alexandre.ra...@gmail.com> wrote: > >> Hello, >> >> This commit breaks compilation on ARM in debug mode: >

Re: [v8-dev] Re: ARM: Optimisations for call, jump and untag.... (issue6874010)

Yes it is faster. This unconditional load is actually the main cause of the performance gain. I benchmarked it with and without to check (on both A8 and A9). Alexandre On Mon, Apr 18, 2011 at 11:57 AM, wrote: > LGTM. Is the unconditional mov in the jump/call code really faster then the > condit

Re: [v8-dev] Porting v8 to a new architecture

Hello Rémi, I originally started the MIPS port of v8 while working for Sigma Design, so I thought I would give you a few pointers. I think the easiest way to start a port would be to go through the initial commits for other architectures - MIPS especially. I would say that the two main first step

Re: [v8-dev] Re: ARM: Add optimization for constant RHS in DoMulI (issue6708025)

Ok thanks! Alexandre On Mon, Mar 21, 2011 at 1:40 PM, wrote: > I will do the changes and land the patch. > > > http://codereview.chromium.org/6708025/ > > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > -- v8-dev mailing list v8-dev@googlegroups.co

[v8-dev] Re: Improved modulo operation in lithium as well as bailout on -0.... (issue6676060)

Thanks for the review. The updated patch should be uploaded soon. Alexandre http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc#newcode900 src/arm/

[v8-dev] Re: ARM: Improved double to integer truncation.... (issue6625084)

Thanks for the review. The code changed significatively from the previous patch. Mainly, the truncation routine uses core registers instead of the VFP (1 fast case with the VFP still). The new code being smaller than the previous VFP code, I did not add a stub. I can however add one if y

[v8-dev] Re: ARM: Implement inline conversion of heap numbers to int32 values for bitoperations. (issue6658034)

A suggestion to rename a function and move it to the MacroAssembler. I implemented the same ecma truncation for bitwise operations using the vfp, but seeing (and as you suggested) this code manual handling will probably be faster for non trivial cases. I'll make a few tests and use this cod

Re: [v8-dev] [v8] r6894 committed - Add more generic version of reloc info padding to ensure enough space ...

This breaks the --code_comments option on ARM... # # Fatal error in src/assembler.cc, line 255 # CHECK(begin_pos - pos_ == RelocInfo::kRelocCommentSize) failed # Alexandre On Tue, Feb 22, 2011 at 12:35 PM, wrote: > Revision: 6894 > Author: ri...@chromium.org > Date: Tue Feb 22 04:28:33 2011 >

[v8-dev] Re: ARM: Add type-feedback recording for compare... (issue6461017)

Just a few comments. The v8 benchmarks performance improvement are impressive! Alexandre http://codereview.chromium.org/6461017/diff/1/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/6461017/diff/1/src/arm/assembler-arm.cc#newcode355 src/arm/asse

[v8-dev] Re: ARM: Add support for DoMathAbs with double inputs.... (issue6366016)

Thanks for the review! Alexandre http://codereview.chromium.org/6366016/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6366016/diff/1/src/arm/lithium-codegen-arm.cc#newcode2536 src/arm/lithium-codegen-arm.cc:2536: Register tmp1

[v8-dev] Re: ARM: Merging constants in simulator and assembler header files and other clea... (issue6274009)

http://codereview.chromium.org/6274009/diff/21001/src/arm/constants-arm.h File src/arm/constants-arm.h (right): http://codereview.chromium.org/6274009/diff/21001/src/arm/constants-arm.h#newcode364 src/arm/constants-arm.h:364: call_rt_redirected = 0x10, Fixed. I missed this one as I nearly missed

[v8-dev] Re: ARM: Merging constants in simulator and assembler header files and other clea... (issue6274009)

Just saw a last comment on a few words' case. I will fix it. http://codereview.chromium.org/6274009/diff/21001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/6274009/diff/21001/src/arm/assembler-arm.cc#newcode432 src/arm/assembler-arm.cc:432: retu

[v8-dev] Re: ARM: Add subtract to the type recording binary operation stub. (issue6324013)

http://codereview.chromium.org/6324013/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6324013/diff/1/src/arm/code-stubs-arm.cc#newcode2452 src/arm/code-stubs-arm.cc:2452: __ sub(right, left, Operand(right)); // Revert optimistic subtract.

[v8-dev] Re: ARM: Add subtract to the type recording binary operation stub. (issue6324013)

http://codereview.chromium.org/6324013/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6324013/diff/1/src/arm/code-stubs-arm.cc#newcode2452 src/arm/code-stubs-arm.cc:2452: __ sub(right, left, Operand(right)); // Revert optimistic subtract.

[v8-dev] Re: ARM: Merging constants in simulator and assembler header files and other clea... (issue6274009)

Thanks for the review! Alexandre http://codereview.chromium.org/6274009/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/6274009/diff/1/src/arm/assembler-arm.h#newcode43 src/arm/assembler-arm.h:43: #include "constants-arm.h" On 2011/01/20 12:4

[v8-dev] Re: ARM: Implement Math.abs in lithium code generator for the integer and (issue6347007)

http://codereview.chromium.org/6347007/diff/2002/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6347007/diff/2002/src/arm/lithium-codegen-arm.cc#newcode2476 src/arm/lithium-codegen-arm.cc:2476: __ jmp(&done); b(eq, &done); would be enou

[v8-dev] Re: ARM: Implement Math.abs in lithium code generator for the integer and (issue6347007)

Here are a few comments. I'll add full support for vabs when this lands. Regards, Alexandre http://codereview.chromium.org/6347007/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6347007/diff/1/src/arm/lithium-codegen-arm.cc#ne

Re: [v8-dev] ARM: Implement Math.abs in lithium code generator for the integer and (issue6347007)

Hi, I implemented this also and we were going to push it... My patch includes the vabs support (including disasm and simulator), as well as a cctest for vabs. Do you want me to upload it? (I can do it now). Otherwise I have a few comments / suggestions on this patch. Regards Alexandre On Wed,

[v8-dev] Re: ARM: Implement DoInstanceOfKnownGlobal stub (issue6248004)

Thanks! The patch is uploaded with MarkAsSaveDoubles. Alexandre On Tue, Jan 18, 2011 at 1:23 PM, wrote: > You are right that the InstanceofStub does not directly touch the floating > point > registers, however it can do a tail call to the builtin INSTANCE_OF and > from > there we have no idea

[v8-dev] Re: ARM: Implement DoInstanceOfKnownGlobal stub (issue6248004)

Thanks for the review Søren. Could you have a look at my comment on the PushSafepointRegisters before we upload the patch? The InstanceofStub does not touch the floating point registers, so do we actually need to save them? Alexandre http://codereview.chromium.org/6248004/diff/15001/src/arm/

[v8-dev] Re: ARM: Implement DoInstanceOfKnownGlobal stub (issue6248004)

http://codereview.chromium.org/6248004/diff/6001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6248004/diff/6001/src/arm/code-stubs-arm.cc#newcode2893 src/arm/code-stubs-arm.cc:2893: // Uses registers r0 to r4. Expected input is On 2011/01/13 15

[v8-dev] Re: Implementing a few more missing stubs on ARM:... (issue6124005)

Thanks for the review. Rodolph will address the last comments and upload the patch. Alexandre http://codereview.chromium.org/6124005/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6124005/diff/1/src/arm/lithium-codegen-arm.cc#n

[v8-dev] Re: ARM: Fix comparison of NaN values.... (issue6142004)

Thanks for the review. The patch should be uploaded soon. Alexandre http://codereview.chromium.org/6142004/diff/1/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/6142004/diff/1/src/arm/assembler-arm.cc#newcode2338 src/arm/assembler-arm.cc:2338: vo

Re: [v8-dev] Re: Issue 1023 in v8: NaN is interpreted as true in conditionals on ARM with crankshaft

http://codereview.chromium.org/6142004/ Patch uploaded. On Thu, Jan 6, 2011 at 10:42 AM, wrote: > > Comment #3 on issue 1023 by alexandre.rames: NaN is interpreted as true in > conditionals on ARM with crankshaft > > http://code.google.com/p/v8/issues/de

[v8-dev] Re: ARM implementations of LoadElements, LoadKeyedFastElement, StoreNamedField, S... (issue5967008)

Thanks for the review. The patch should be uploaded soon. Alexandre http://codereview.chromium.org/5967008/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/5967008/diff/1/src/arm/lithium-codegen-arm.cc#newcode1591 src/arm/lithium

Re: [v8-dev] Issue 1019 in v8: Missing vmrs after vcmp instructions on ARM in LCodeGen::DoBranch

The patch has been uploaded: http://codereview.chromium.org/6020014/ On Wed, Jan 5, 2011 at 11:54 AM, wrote: > Status: New > Owner: > > New issue 1019 by alexandre.rames: Missing vmrs after vcmp instructions on > ARM in LCodeGen::DoBranch > http://code.google.com/p/v8/issues/detail?id=1019

Re: [v8-dev] current work on lithium stubs

and Martyn just uploaded the patch. http://codereview.chromium.org/6020014/ On Wed, Jan 5, 2011 at 11:48 AM, Alexandre Rames wrote: > Here it is: > > http://code.google.com/p/v8/issues/detail?id=1019&sort=-id&colspec=ID%20Type%20Status%20Priority%20Owner%20Summary%20HW%20

Re: [v8-dev] current work on lithium stubs

ou have available? > > > Regards, > Karl > > On Wed, Jan 5, 2011 at 12:21 PM, Alexandre Rames < > alexandre.ra...@gmail.com> wrote: > >> Yes it is ready. I'll ask Martyn if he can upload it now. >> But another segfault still remains :( r6166 breaks the

Re: [v8-dev] current work on lithium stubs

t;> crankshaft on ARM. If you notice a bug, put the failing tests on the >>> test list and file a bug report that you assign to yourself. We will >>> keep on trucking and things will pick up quickly. If you do not upload >>> small changes it will drown and we will dupl

[v8-dev] current work on lithium stubs

Hell everyone, I saw a patch by Karl this morning, where implemented a few ARM Lithium stubs http://codereview.chromium.org/6069010/ I had been working on a few of these too, but I was fixing other bugs discovered and I did not upload them. So that we don't overlap, here is a list of the ARM LCod

[v8-dev] Re: First part of lithium ARM port. (issue6069010)

I guess I know why you removed the StoreNamedField code. I implemented the same stubs and had raytrace fail. The bug does not come from StoreNamedfield; I identified it and I'll have a fix ready soon (tomorrow probably). Cheers, Alexandre On 2011/01/04 09:17:19, Kevin Millikin wrote: http:/

[v8-dev] Re: Generate inline code for contextual loads on ARM.... (issue5140002)

The updated patch should be uploaded soon. http://codereview.chromium.org/5140002/diff/12001/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/5140002/diff/12001/src/arm/assembler-arm.h#newcode1186 src/arm/assembler-arm.h:1186: static bool IsNop(Instr

[v8-dev] Re: Generate inline code for contextual loads on ARM.... (issue5140002)

Thanks for the review. Martyn should have uploaded the updated patch. Alexandre http://codereview.chromium.org/5140002/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/5140002/diff/1/src/arm/assembler-arm.h#newcode1085 src/arm/assembler-arm.h

[v8-dev] Re: The Simulator will now handle different VFP rounding modes. RZ and RM... (issue4295003)

Thanks for the review. The new patch should be uploaded soon. Alexandre http://codereview.chromium.org/4295003/diff/1/3 File src/arm/assembler-arm.h (right): http://codereview.chromium.org/4295003/diff/1/3#newcode1017 src/arm/assembler-arm.h:1017: ConversionMode mode = RoundToZero); Done. On

[v8-dev] Re: Fix the ARM simulator, the ARM disassmebler and extend the stop feature.... (issue3606009)

I just spotted a bug while writing a little documentation. The fix will come in the next update of the patch. Alexandre http://codereview.chromium.org/3606009/diff/10001/11006 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/3606009/diff/10001/11006#newcode392 src/arm/si

[v8-dev] Re: Fix the ARM simulator, the ARM disassmebler and extend the stop feature.... (issue3606009)

Hi, I answered your comments. I also fixed a little issue with the Disassembler concerning the message address of stops inlined in the code. The new patch will be uploaded when somebody who has commit rights comes back. Thanks, Alexandre http://codereview.chromium.org/3606009/diff/21001/6

[v8-dev] Re: Fix the ARM simulator, the ARM disassmebler and extend the stop feature.... (issue3606009)

Fixed a bug in the updated patch. Alexandre http://codereview.chromium.org/3606009/diff/10001/11003 File src/arm/constants-arm.h (right): http://codereview.chromium.org/3606009/diff/10001/11003#newcode199 src/arm/constants-arm.h:199: static const int32_t kStopCodeMask = ~stop; This is wrong. C

Re: [v8-dev] Re: This patch adds support for "manual breakpoints" in the ARM Simulator. These... (issue3440028)

Hi, Thanks for your comments. Sorry for this useless patch. considering the stop instruction it does not add much; I was not aware of this feature and needed something similar. The manual breakpoints did not have a string description feature, but added an enable / disable feature and some simple

[v8-dev] Re: Updates and fixes for MIPS support. (issue1320006)

Hi Søren, I finally took some time to update the MIPS support. This update contains some fixes, more support for MIPS instructions, and support for floating point with or without FPU. If this looks ok I'll rebase it on bleeding edge. Regards, Alexandre On 2010/04/08 10:39:44, Søren Gjesse

[v8-dev] Re: Updates and fixes for MIPS support. (issue1320006)

Hi, I just updated test-mips.cc with a cleaner test. Thanks, Alexandre http://codereview.chromium.org/1320006/diff/15001/16002 File test/cctest/test-mips.cc (right): http://codereview.chromium.org/1320006/diff/15001/16002#newcode58 test/cctest/test-mips.cc:58: CHECK_EQ(0x80, script->Run()->I

[v8-dev] Re: Updates and fixes for MIPS support. (issue1320006)

Hi Søren, I just fixed the code. I'll rebase it on bleeding edge once it is accepted. I also have a question: is it possible to share the right to modify an issue with somebody else? In our case I'd like Paul to be able to also answer and upload some code for an issue I have created. Thanks, A

[v8-dev] Updates and fixes for MIPS support. (issue1320006)

Reviewers: , Message: Hi, Here is an update for MIPS code, done by Paul Lind from MIPS. It contains fixes and support for floating point in the simulator as well as new tests, and a few other fixes. Regards, Alexandre Description: Updates and fixes for MIPS support. Please review this at

[v8-dev] Re: MIPS simple function calls (issue1018001)

Hi, I corrected test-mips.cc and changed SetupAlignedCall code. I think your problem running tools/test.py --simulator=mips is that your src/flag-definitions.h is not good for MIPS. You need these diffs to have it work: Index: src/flag-definitions.h =

[v8-dev] Re: MIPS simple function calls (issue1018001)

Hi, I corrected the bugs and added a new test for function calls in test/cctest/test-mips.cc . We can use this file to implement all further high level MIPS tests. Regards, Alexandre http://codereview.chromium.org/1018001 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.

[v8-dev] Re: MIPS simple function calls (issue1018001)

Hi, I actually added some bugs while correcting the code. I'm checking it right now. Alexandre On 2010/03/22 12:35:58, Alexandre wrote: Hi, I just uploaded the changes. I still need to add a test. Alexandre http://codereview.chromium.org/1018001/diff/16001/17002 File src/mips/built

[v8-dev] Re: MIPS simple function calls (issue1018001)

Hi, I just uploaded the changes. I still need to add a test. Alexandre http://codereview.chromium.org/1018001/diff/16001/17002 File src/mips/builtins-mips.cc (right): http://codereview.chromium.org/1018001/diff/16001/17002#newcode117 src/mips/builtins-mips.cc:117: __ b(&entry); On 2010/03/17

[v8-dev] Re: MIPS simple function calls (issue1018001)

Thanks for the review, I'll be working on branch delay slots. I think I will make the MacroAssembler generate nop instructions. Using the branch delay slot would then need to use directly the Assembler instead. I will also add some tests for function calls. Rather than adding tests in test-a

[v8-dev] Re: MIPS simple function calls (issue1018001)

I'm correcting the forgotten lint errors... On 2010/03/15 22:03:31, Alexandre wrote: Hi, Here is some update for MIPS to do a simple global function call. It has been tested to execute some code like: function foo() { return 0x1234; } foo(); The code was tested with a customized shel

[v8-dev] MIPS simple function calls (issue1018001)

Reviewers: Søren Gjesse, Message: Hi, Here is some update for MIPS to do a simple global function call. It has been tested to execute some code like: function foo() { return 0x1234; } foo(); The code was tested with a customized shell: in shell.cc use v8::Handle context = v8::Context::New();

[v8-dev] Re: Added support for MIPS in architecture independent files.... (issue543161)

Hi, I have addressed your comments. Regards, Alexandre http://codereview.chromium.org/543161/diff/9055/9072 File src/mips/assembler-mips-inl.h (right): http://codereview.chromium.org/543161/diff/9055/9072#newcode76 src/mips/assembler-mips-inl.h:76: Operand::Operand(Object** opp) { Removed. O

[v8-dev] Re: Added support for MIPS in architecture independent files.... (issue543161)

Hi, Just a little fix as I found a bug in debug mode. Alexandre http://codereview.chromium.org/543161/diff/9055/9091 File src/mips/constants-mips.h (right): http://codereview.chromium.org/543161/diff/9055/9091#newcode462 src/mips/constants-mips.h:462: ASSERT(instrType() == kRegisterType || in

[v8-dev] Re: Added support for MIPS in architecture independent files.... (issue543161)

Hi, I worked on your comments. I also updated to revision 3749. I removed fast-codegen.* and added full-codegen files as I understood v8 was moving to this one. Everything compiles and cctest work for me. I did not add code generation yet. Regards, Alexandre http://codereview.chromium.

[v8-dev] Re: Added support for MIPS in architecture independent files.... (issue543161)

Hi, I have done some fixes. I also removed the MIPS code in jump-target.* as you suggested. Alexandre http://codereview.chromium.org/543161/diff/8002/9052 File SConstruct (right): http://codereview.chromium.org/543161/diff/8002/9052#newcode849 SConstruct:849: options['profilingsupport'] = 'on

[v8-dev] Re: Added support for MIPS in architecture independent files.... (issue543161)

Removed a line forgotten. http://codereview.chromium.org/543161/diff/8002/9044 File src/mips/constants-mips.h (right): http://codereview.chromium.org/543161/diff/8002/9044#newcode456 src/mips/constants-mips.h:456: ASSERT(instrType() == kRegisterType || instrType() == kImmediateType); Accidental

[v8-dev] Re: Added support for MIPS in architecture independent files.... (issue543161)

Hi, I've worked on your comments. The big work in this change. was to move the code from the Assembler to the MacroAssembler. There is also a new test for the assembler. However I actually use a MacroAssembler to use the Branch instructions. Otherwise only Assembler instructions are used. I'll k

[v8-dev] Re: Added support for MIPS in architecture independent files.... (issue543161)

Hi, Sorry I had a mistake in my script reseting default values in flag-definitions.h . I'll correct it and lint errors right now. Alexandre http://codereview.chromium.org/543161/diff/4001/5006 File src/flag-definitions.h (left): http://codereview.chromium.org/543161/diff/4001/5006#oldcod

[v8-dev] Re: Added support for MIPS in architecture independent files.... (issue543161)

Reviewers: Søren Gjesse, Message: Hi, I have worked on your previous comments. Thanks again to the reviewers. This should be much cleaner now. I fear I might have left a few style errors undetected by tools/presubmit.py. Now I know better Google style guidelines I'll remove them whenever I s

[v8-dev] Re: Support for MIPS in architecture independent files.... (issue549079)

Reviewers: Søren Gjesse, Kevin Millikin, antonm, Message: Hi, I have answered and corrected these issues. They should be fixed for my next upload. Thanks to the reviewers. Alexandre http://codereview.chromium.org/549079/diff/1/67 File SConstruct (right): http://codereview.chromium.org/549079

<    1   2   3