Per popular demand, we renamed this to "DevTools Language Components" to
avoid the confusion with Language Servers for IDEs.
cheers,
Benedikt
On Friday, October 11, 2019 at 8:51:06 AM UTC+2, Benedikt Meurer wrote:
>
> Hey folks,
>
> Following up on the prototyping work around Wasm Debugging
https://codereview.chromium.org/1179393008/diff/21/test/cctest/wasm/wasm-run-utils.h
File test/cctest/wasm/wasm-run-utils.h (right):
https://codereview.chromium.org/1179393008/diff/21/test/cctest/wasm/wasm-run-utils.h#newcode489
test/cctest/wasm/wasm-run-utils.h:489:
LGTM on compiler, crankshaft, full-codegen and interpreter.
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Well I guess no one actually cared about this CL. So feel free to take over
responsibility for this.
https://codereview.chromium.org/790723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
As discussed offline earlier, I'm fine with the patch overall; it'll
simplify
things long-term and I think it's important that we tackle such issues. I'm
not
sure about some of the details, but I feel like I have to see this "in the
wild"
to come up with useful suggestions (read: I might
LGTM on compiler and fullcodegen changes; only briefly checked the rest.
https://codereview.chromium.org/1332873003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
LGTM (rubber-stamped)
https://codereview.chromium.org/1323463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
And general approach looks good to me too.
https://codereview.chromium.org/1323463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this
Builtin looks good modulo comment.
https://codereview.chromium.org/1323463005/diff/60001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/1323463005/diff/60001/src/x64/builtins-x64.cc#newcode1795
src/x64/builtins-x64.cc:1795: __
A revert of this CL (patchset #10 id:260001) has been created in
https://codereview.chromium.org/1328963004/ by bmeu...@chromium.org.
The reason for reverting is: Breaks nosnap, needs investigation.
https://codereview.chromium.org/1311013008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: rmcilroy, Jarin, Michael Starzinger, mvstanton,
Message:
Created Revert of [builtins] Unify the various versions of [[Call]] with a
Call
builtin.
Description:
Revert of [builtins] Unify the various versions of [[Call]] with a Call
builtin.
(patchset #10 id:260001 of
Reviewers: Jarin,
Message:
Hey Jaro, Camillo,
This is the initial part of the %_CallFunction fixification.
Please take a look.
Thanks,
Benedikt
Description:
[runtime] Replace many buggy uses of %_CallFunction with %_Call.
The semantics of the %_CallFunction intrinsic seem to be very unclear,
lgtm
https://codereview.chromium.org/1322203005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
LGTM, thanks for fixing this.
https://codereview.chromium.org/1309163006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
https://codereview.chromium.org/1325573004/diff/20001/src/arm/interface-descriptors-arm.cc
File src/arm/interface-descriptors-arm.cc (right):
https://codereview.chromium.org/1325573004/diff/20001/src/arm/interface-descriptors-arm.cc#newcode196
src/arm/interface-descriptors-arm.cc:196:
LGTM
https://codereview.chromium.org/1316673008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM!
https://codereview.chromium.org/1332563003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Awesome! LGTM
https://codereview.chromium.org/1331603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Reviewers: Jarin,
Message:
Hey Jaro,
This unifies the handling of "actual number of arguments" for JSFunction
calls.
It basically removes premature optimization (saving one LoadImmediate for
some
calls).
Please take a look.
Thanks,
Benedikt
Description:
[calls] Consistent call protocol
Hey Jaro,
Can you take a look at the x64 port before I start porting that over to
everything else?
Thanks,
Benedikt
https://codereview.chromium.org/1311013008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc#newcode1732
src/x64/builtins-x64.cc:1732: // TODO(bmeurer): This doesn't match the
ES6 spec
Hey MIPS guys,
Please port this CL to mips/mips64.
Thanks,
Benedikt
https://codereview.chromium.org/1311013008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
Hey Michi, Michael,
Please review the x64 or ia32 port (i'm about to port to arm).
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1311013008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
lgtm
https://codereview.chromium.org/1326263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
On 2015/09/07 11:01:19, rmcilroy wrote:
Overall looks good, should be something that can be used by the
Interpreter. I
tried to figure out how to modify my CL to call this instead of the
JSFunction
code object directly, however I couldn't find a way to call a non-JS
builtin
from TF - is
On 2015/09/07 09:16:46, rmcilroy wrote:
On 2015/09/07 05:14:30, Benedikt Meurer wrote:
> Just two very early comments, and one question:
> You mentioned that it should be possible to write certain bytecode
handlers
as
> native builtins. How about doing that for the call opcode? Because that
Amazing. Thanks a lot!
https://codereview.chromium.org/1311003006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
I renamed the builtins to Call and CallFunction to better match the spec
names.
https://codereview.chromium.org/1311013008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
+mstarzinger
+jarin
https://codereview.chromium.org/1323463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1296743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Just two very early comments, and one question:
You mentioned that it should be possible to write certain bytecode handlers
as
native builtins. How about doing that for the call opcode? Because that
seems
like a lot of machinery in TurboFan to support this very special opcode.
Nice, thanks for fixing. LGTM!
https://codereview.chromium.org/1302313013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
LGTM on the AUTHORS file. I'll leave it to Paul to review the patch.
https://codereview.chromium.org/1326173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Reviewers: rmcilroy,
Message:
Hey Ross,
This is the very first version of the CallCallableStub. You said you wanted
to
have an early look. It'll need some more polishing. If you have some spare
time,
you can help porting to arm/arm64 next week.
greets,
Benedikt
Description:
[stubs] Unify
lgtm
https://codereview.chromium.org/1321943004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1301393012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1319123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1314703005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
On 2015/09/03 15:02:09, Michael Achenbach wrote:
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1306303005/ by
mailto:machenb...@chromium.org.
The reason for reverting is: [Sheriff] Changes several layout test
expectations.
Please fix
lgtm
https://codereview.chromium.org/1308703013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Jakob,
Message:
Hey Jakob,
Landing this independently of the ClassOf change. TBR'ed as you already
liked
the change :-)
Benedikt
Description:
Remove obsolete functionality from the MacroAssemblers.
This is uncontroversial the dead code removal part of
FYI, for Benedikt and v8 team, LoadRoot() is preferred over li() where
possible,
since it is one instruction vs two.
MIPS64 ABI (n64) has 8 argument registers rather than the 4 on MIPS32
ABI, and
the "conventional names" for registers 4 thru 15 were therefore changed
from
[a0-a3][t0-t7]
LGTM, but please add a more descriptive CL message.
https://codereview.chromium.org/1310993004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
lgtm
https://codereview.chromium.org/1310323006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Hey Igor,
This is a first step towards faster iterators for ES6 for-of loops.
With this new type we make sure that all iterator results we see
(coming from our internals and generators) have the same map.
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1302173007/
--
--
lgtm
https://codereview.chromium.org/1303183005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
LGTM with nit.
https://codereview.chromium.org/1307203005/diff/1/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/1307203005/diff/1/src/compiler/instruction-selector.cc#newcode1077
src/compiler/instruction-selector.cc:1077:
Hey guys,
This is preliminary cleanup for proper bound functions support (and
also proper ES6 style proxies).
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1307943013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
LGTM
https://codereview.chromium.org/1313023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Hey Jaro,
This is the fix we talked about. Pretty straight forward.
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1325023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js
File src/array-iterator.js (right):
https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js#newcode82
src/array-iterator.js:82: !HAS_DEFINED_PRIVATE(iterator,
arrayIteratorNextIndexSymbol)) {
Yeah, I'll
lgtm
https://codereview.chromium.org/1329493004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1304923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1308113007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
LGTM!
https://codereview.chromium.org/1318863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM from me on code-stubs (although the ia32 dance looks hairy; I bet we
need
to do something about that performance-wise...)
https://codereview.chromium.org/1328603003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Graph creation skeleton looks good to me.
https://codereview.chromium.org/1291693004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this
LGTM!
https://codereview.chromium.org/1327523003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM!
https://codereview.chromium.org/1316333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM.
https://codereview.chromium.org/1329553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
It looks like the layout test failure on
fast/dom/plugin-attributes-enumeration.html was indeed a bug in V8 that is
now
fixed (we returned "object" for typeof applied to an API object with
[[Call]]).
I checked firefox and with this patch we are compatible. So I'll fix the
expectation in
LGTM. Looks better indeed. But we should be careful not to fix too many
issues
with Crankshaft :-)
https://codereview.chromium.org/1315193010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
lgtm
https://codereview.chromium.org/1306823005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1308563010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1329643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Jarin,
Message:
Hey Jaro,
Here's the proof-of-concept implementation of for-of in Crankshaft.
This is not intended for landing now. We'll first have to have some
strategic discussion about this.
Please take a look.
Thanks,
Benedikt
Description:
[crankshaft] Add baseline
Hey Michael,
Here's a trivial one, just removing dead code.
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1304363012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
LGTM.
https://codereview.chromium.org/1322623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM.
https://codereview.chromium.org/1304873011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM! Ship it!
https://codereview.chromium.org/1321223002/diff/1/src/unique.h
File src/unique.h (left):
https://codereview.chromium.org/1321223002/diff/1/src/unique.h#oldcode12
src/unique.h:12: #include "src/objects-inl.h" // TODO(everyone): Fix
our inl.h crap
Appreciated!
Also, I am looking for a "regexp" OWNER that is _not_ on vacation right
now.
:(
Hm, wait I think I mentioned that this "process thing" will cause exactly
these
kinds of problems, yeah I'm pretty sure I did. I guess there is only one
word to
describe the outcome: "Haha!" (Nelson)
But
LGTM from my side.
https://codereview.chromium.org/1320363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
LGTM
https://codereview.chromium.org/1305313008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1325453005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Hey Michi,
The bug we just discovered; it's not even an off-by-N...
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1306423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM
https://codereview.chromium.org/1319383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/31 10:58:32, Benedikt Meurer wrote:
Hey MIPS people,
Please port this fix to MIPS/MIPS64.
Thanks,
Benedikt
I forgot to mention: You can land that separately, as I wasn't able to
construct
a regression test with current ToT.
https://codereview.chromium.org/1306423003/
--
lgtm
https://codereview.chromium.org/1313213007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
PTAL
https://codereview.chromium.org/1324713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Hey MIPS people,
Please port this fix to MIPS/MIPS64.
Thanks,
Benedikt
https://codereview.chromium.org/1306423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
lgtm
https://codereview.chromium.org/1309903005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
LGTM
https://codereview.chromium.org/1311393008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/09/01 04:02:15, Benedikt Meurer wrote:
On 2015/09/01 03:55:02, caitp wrote:
> https://codereview.chromium.org/1272673003/diff/150001/src/parser.cc
> File src/parser.cc (right):
>
>
https://codereview.chromium.org/1272673003/diff/150001/src/parser.cc#newcode4415
> src/parser.cc:4415:
LGTM with question and nit.
https://codereview.chromium.org/1272673003/diff/150001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1272673003/diff/150001/src/parser.cc#newcode4415
src/parser.cc:4415: // for (var $argument_index = $rest_index;
I guess there was some
lgtm
https://codereview.chromium.org/1323813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
On 2015/09/01 03:55:02, caitp wrote:
https://codereview.chromium.org/1272673003/diff/150001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1272673003/diff/150001/src/parser.cc#newcode4415
src/parser.cc:4415: // for (var $argument_index = $rest_index;
On 2015/09/01
LGTM
https://codereview.chromium.org/1319463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM
https://codereview.chromium.org/1310633004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Hey Michi,
Using utils.InstallFunctions as you suggested (verified it works).
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1310163004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Addressed feedback. Thanks.
https://codereview.chromium.org/1324713002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1324713002/diff/1/src/objects.h#newcode176
src/objects.h:176: // Valid hints for the abstract operations
OrdinaryToPrimitive,
On 2015/08/31
lgtm
https://codereview.chromium.org/1307223007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1308403010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1323543002/diff/1/test/mjsunit/compiler/jsnatives.js
File test/mjsunit/compiler/jsnatives.js (left):
https://codereview.chromium.org/1323543002/diff/1/test/mjsunit/compiler/jsnatives.js#oldcode32
test/mjsunit/compiler/jsnatives.js:32: assertEquals(1,
Reviewers: Yang,
Message:
Hey Yang,
Here's first followup cleanup for ToName. Easy peasy.
Please take a look.
Thanks,
Benedikt
Description:
[es6] Implement spec compliant ToName (actually ToPropertyKey).
This adds a %ToName runtime entry that uses the previously introduced
Object::ToName,
Still LGTM!
https://codereview.chromium.org/1316953003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Yang: Please do overall review.
Michi: Please review compiler changes.
Michael: Please look at code stubs.
https://codereview.chromium.org/1306303003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM
https://codereview.chromium.org/1323473003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1306303003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1306303003/diff/1/src/objects.cc#newcode6017
src/objects.cc:6017: HandleObject exoticToPrim;
On 2015/08/28 08:52:13, Michael Starzinger wrote:
nit: not likey camelCase
Hey Yang,
Next step to make builtins object obsolete. More to
come in followup CLs.
Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1319973007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
LGTM (better make sure the deoptimizer never sees those code objects,
otherwise
it'll be very unhappy with the smi zero).
https://codereview.chromium.org/1303953007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
1 - 100 of 3918 matches
Mail list logo
