Committed patchset #1 manually as r15969 (presubmit successful).
https://codereview.chromium.org/21333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r15971 (presubmit successful).
Description:
Revert target arch detection.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=15971
Please review this at https://codereview.chromium.org/21243004/
Reviewers: machenbach, Sven Panne,
Message:
Committed patchset #1 manually as r15972 (presubmit successful).
Description:
Fix NaCl build.
TBR=machenb...@chromium.org,svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=15972
Please review this at https://codereview.c
Reviewers: danno, Sven Panne,
Message:
Committed patchset #1 manually as r15976 (presubmit successful).
Description:
Revert the latest set of platform changes.
Revert "Fix NaCl build."
Revert "Revert target arch detection."
Revert "Fix typo."
Revert "Simplify implementation of Mutex."
Revert "F
Reviewers: titzer,
Message:
Hey Ben,
This is the HConstant with HType::None() change we discussed a few minutes
ago.
-- Benedikt
Description:
Fix HType handling for HConstant with external references.
We cannot use set_type() with HType::None() in the HConstant
constructor, since set_type()
On 2013/07/31 09:32:36, titzer wrote:
LGTM
Note that I just added some more set_type() calls in constructors. We can
use
the constructor that you've added now, but I'll leave it up to you if you
want
to do that in this CL as well.
I'll just land this one because it's required for the HLi
Committed patchset #1 manually as r15980 (presubmit successful).
https://codereview.chromium.org/21317004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: titzer,
Message:
Committed patchset #1 manually as r15981 (presubmit successful).
Description:
Compile fix for older GCCs.
TBR=tit...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=15981
Please review this at https://codereview.chromium.org/21142007/
SVN Base
Reviewers: mvstanton, danno,
Message:
Hey Michael,
Here's the HLinkObjectInList removal CL as promised. :-)
-- Benedikt
Description:
Get rid of HLinkObjectInList.
Please review this at https://codereview.chromium.org/21345002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Aff
Committed patchset #1 manually as r15983 (presubmit successful).
https://codereview.chromium.org/21345002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: titzer,
Message:
The follow-up CL mentioned before.
Description:
Avoid the use of set_type() in instruction constructors.
Please review this at https://codereview.chromium.org/21348002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-
Committed patchset #1 manually as r15984 (presubmit successful).
https://codereview.chromium.org/21348002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/21353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Sven Panne, Jakob, Hannes Payer,
Description:
Add toplevel hydrogen.cfg file to .gitignore.
Please review this at https://codereview.chromium.org/21328004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M .gitignore
Index: .gitignore
diff --git a/
On 2013/07/31 12:34:48, Jakob wrote:
Please keep alphabetical ordering. And while you're at it, you can also
ignore
other common artifacts:
perf.data
perf.data.old
v8.log.ll
Done.
https://codereview.chromium.org/21328004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.googl
Committed patchset #2 manually as r15986 (presubmit successful).
https://codereview.chromium.org/21328004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: mvstanton, Michael Starzinger,
Message:
Hey Michael,
This is the change we discussed offline.
-- Benedikt
Description:
Stores to external references don't need write barriers.
This also applies to stores with an external field representation.
Also cleans up the CreateAllocationSiteS
https://codereview.chromium.org/21357003/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/21357003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode4345
src/ia32/lithium-codegen-ia32.cc:4345:
ASSERT(!instr->hydrogen()->NeedsWrit
Committed patchset #2 manually as r15989 (presubmit successful).
https://codereview.chromium.org/21357003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
https://codereview.chromium.org/21369002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/21369002/diff/1/src/runtime.cc#newcode814
src/runtime.cc:814: int arrayId, ExternalArrayType& array_type, size_t&
element_size) {
Use pointers instead of references.
https
Reviewers: Sven Panne, danno,
Message:
Hey Sven,
Here's the fix for HCheckInstanceType::Canonicalize().
-- Benedikt
Description:
Fix broken HCheckInstanceType::Canonicalize().
Please review this at https://codereview.chromium.org/21488002/
SVN Base: https://v8.googlecode.com/svn/branches/bleed
On 2013/08/01 07:44:47, danno wrote:
If this fixed something that was broken, can you please add a regression
test?
I triggered this bug while replacing HStringLength with HLoadNamedField, so
there's no regression test case for this now.
https://codereview.chromium.org/21488002/
--
--
v8-dev
LGTM
https://codereview.chromium.org/21369002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: mvstanton, Sven Panne, danno,
Message:
PTAL
Description:
Get rid of HStringLength.
Use HLoadNamedField to load the string length field instead.
Depends on: https://codereview.chromium.org/21488002
Please review this at https://codereview.chromium.org/21499002/
SVN Base: https://v8
Committed patchset #1 manually as r15999 (presubmit successful).
https://codereview.chromium.org/21488002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Committed patchset #1 manually as r16002 (presubmit successful).
https://codereview.chromium.org/21499002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Hm, why revert? Why not simply fix the GCC warnings?
https://codereview.chromium.org/21502002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
lgtm
https://codereview.chromium.org/21502002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
LGTM
https://codereview.chromium.org/21918002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://codereview.chromium.org/21705003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://codereview.chromium.org/22146002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://codereview.chromium.org/21830004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://codereview.chromium.org/22164003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Using FPs for time values is never actually a good idea. So, I suggest to
fix
the real issue instead and use integers to represent time offsets.
https://codereview.chromium.org/21848004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received t
lgtm
https://codereview.chromium.org/22172002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
I think OS::TimeCurrentMillis() should be replaced with OS::Ticks().
https://codereview.chromium.org/21848004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
T
Reviewers: machenbach, Sven Panne,
Message:
Committed patchset #1 manually as r16050.
Description:
Revert "Return start/end profiling time in microseconds instead of
milliseconds"
This reverts r16049 for breaking build on windows.
TBR=svenpa...@chromium.org,machenb...@chromium.org
Committe
On 2013/08/05 11:48:31, Yury Semikhatsky wrote:
Committed patchset #1 manually as r16049 (presubmit successful).
Reverted due to windows build breakage.
Note that we're currently trying to stabilize the tree.
https://codereview.chromium.org/22172002/
--
--
v8-dev mailing list
v8-dev@googlegr
Forwarding to danno
https://codereview.chromium.org/22155003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Hm, why not test for __SOFTFP__ or __SOFTFP? I don't like to break builds
that
work right now because we're testing for __SOFTFP.
https://codereview.chromium.org/22210002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message bec
LGTM
https://codereview.chromium.org/22155003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://codereview.chromium.org/22210002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Committed patchset #2 manually as r16070 (presubmit successful).
https://codereview.chromium.org/22210002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Well spotted, LGTM.
https://codereview.chromium.org/22314010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Reviewers: danno, mvstanton,
Description:
Handle external reference values properly in HConstant::ImmortalImmovable().
Please review this at https://codereview.chromium.org/22274017/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
Committed patchset #1 manually as r16087 (presubmit successful).
https://codereview.chromium.org/22274017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Hey Ben,
Can you please sign the CLA? See
https://developers.google.com/open-source/cla/individual for details.
-- Benedikt
https://codereview.chromium.org/21705003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
Reviewers: Sven Panne, danno,
Description:
Fix -Wconversion warnings in external V8 headers.
BUG=v8:2830
Please review this at https://codereview.chromium.org/22549003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8.h
Index: include/v8.h
diff -
On 2013/08/09 08:43:10, ben2 wrote:
On 2013/08/09 07:04:00, Benedikt Meurer wrote:
> Hey Ben,
> Can you please sign the CLA? See
> https://developers.google.com/open-source/cla/individual for details.
> -- Benedikt
Benedikt, I'm already on the list but with another email address:
mailto:i...@b
Committed patchset #1 manually as r16122 (presubmit successful).
https://codereview.chromium.org/21705003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Committed patchset #1 manually as r16127 (presubmit successful).
https://codereview.chromium.org/22549003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: danno, Sven Panne,
Description:
Fix/unify root handling in code generation.
Please review this at https://codereview.chromium.org/22670004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/macro-assembler-arm.cc
M src/heap.h
M src/heap.c
https://codereview.chromium.org/22670004/diff/1/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):
https://codereview.chromium.org/22670004/diff/1/src/ia32/macro-assembler-ia32.cc#newcode68
src/ia32/macro-assembler-ia32.cc:68: roots_array_start));
On 2013/08/09 13:36
On 2013/08/09 13:36:03, danno wrote:
What about x64?
Michi suggested to use the kRootRegister on x64, which generates code that
is
both shorter and faster than the 64-bit immediate movq.
https://codereview.chromium.org/22670004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://grou
Committed patchset #1 manually as r16132 (presubmit successful).
https://codereview.chromium.org/22670004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
I don't think the new implementation actually improves the situation. The
case
for multiple producers is still not handled correctly. We need to cleanup
this
whole thing. See my comments below for suggestions how to proceed. CC'ing
Sven
for additional feedback.
https://codereview.chromium.
BTW I did not carefully check the memory-ordering semantics of my
suggestions
above.
https://codereview.chromium.org/22849002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
On 2013/08/13 10:05:20, Yury Semikhatsky wrote:
https://codereview.chromium.org/22849002/diff/2001/src/circular-queue.cc
File src/circular-queue.cc (right):
https://codereview.chromium.org/22849002/diff/2001/src/circular-queue.cc#newcode81
src/circular-queue.cc:81: MemoryBarrier();
On 2013/08
On 2013/08/13 10:03:43, Yury Semikhatsky wrote:
On 2013/08/13 09:31:32, Benedikt Meurer wrote:
> I don't think the new implementation actually improves the situation.
The
case
> for multiple producers is still not handled correctly. We need to
cleanup
this
> whole thing. See my comments bel
On 2013/08/13 11:59:53, Yury Semikhatsky wrote:
On 2013/08/13 10:28:12, Benedikt Meurer wrote:
> On 2013/08/13 10:05:20, Yury Semikhatsky wrote:
> >
https://codereview.chromium.org/22849002/diff/2001/src/circular-queue.cc
> > File src/circular-queue.cc (right):
> >
> >
>
https://codereview.c
Ok, next round of comments.
https://codereview.chromium.org/22849002/diff/23001/src/allocation.h
File src/allocation.h (right):
https://codereview.chromium.org/22849002/diff/23001/src/allocation.h#newcode39
src/allocation.h:39: // ALIGNAS(16) int array[4];
Typo: ALIGN_AT
https://codereview.c
Reviewers: Sven Panne, Michael Starzinger, ulan,
Message:
PTAL
Description:
Replace OS::Ticks() with Stopwatch utility class.
OS::Ticks() was used to measure elapsed time in microseconds, which
is now properly encapsulated in the Stopwatch class. Stopwatch uses
a monotonic clock if available, f
https://codereview.chromium.org/22849002/diff/32001/src/allocation.h
File src/allocation.h (right):
https://codereview.chromium.org/22849002/diff/32001/src/allocation.h#newcode36
src/allocation.h:36: // Specify memory alignment for structs, classes,
etc.
Please move the ALIGN_AT definition to gl
Reviewers: titzer, danno,
Description:
Drop broken and unnecessary RequiredInputRepresentation() in
HMathFloorOfDiv.
Please review this at https://codereview.chromium.org/23190002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
Committed patchset #1 manually as r16190.
https://codereview.chromium.org/23190002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Reviewers: danno,
Message:
Committed patchset #1 manually as r16191.
Description:
Revert "Drop broken and unnecessary RequiredInputRepresentation() in
HMathFloorOfDiv."
This reverts r16190.
TBR=da...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16191
Please review thi
Ok, almost there. Just one nit with ALIGN_AT(). Please rename to ALIGNAS()
and
use alignas() with C++11.
https://codereview.chromium.org/22849002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
On 2013/08/19 06:30:44, Yury Semikhatsky wrote:
On 2013/08/19 06:12:10, Benedikt Meurer wrote:
> Ok, almost there. Just one nit with ALIGN_AT(). Please rename to
ALIGNAS()
and
> use alignas() with C++11.
Done.
Just noticed, that ALIGNAS() is still in allocation.h. Please move to
global
Committed patchset #1 manually as r16211.
https://codereview.chromium.org/23190002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Reviewers: Sven Panne, Dmitry Lomov (chromium),
Message:
PTAL
Description:
Add FINAL and OVERRIDE macros for C++11 final/override.
We also use new the constant naming scheme for Yield::Kind values to avoid
clash with the FINAL macro.
Please review this at https://codereview.chromium.org/230980
Ok, first round of comments.
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc#newcode683
src/arm/code-stubs-arm.cc:683: // with exponent because Bia
I don't want to introduce any more #ifdef's here. I think we should simply
import the base/time stuff from chromium instead, which already covers what
we
need.
https://codereview.chromium.org/23271003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Danno, here's the FINAL/OVERRIDE CL just mentioned.
https://codereview.chromium.org/23098004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fro
On 2013/08/19 08:32:40, Yury Semikhatsky wrote:
On 2013/08/19 07:58:09, Benedikt Meurer wrote:
> I don't want to introduce any more #ifdef's here. I think we should
simply
> import the base/time stuff from chromium instead, which already covers
what
we
> need.
Ho do you see it? Pulling s
On 2013/08/19 08:50:25, Yury Semikhatsky wrote:
On 2013/08/19 08:35:51, Benedikt Meurer wrote:
> On 2013/08/19 08:32:40, Yury Semikhatsky wrote:
> > On 2013/08/19 07:58:09, Benedikt Meurer wrote:
> > > I don't want to introduce any more #ifdef's here. I think we should
simply
> > > import the ba
On 2013/08/19 08:11:18, Benedikt Meurer wrote:
Danno, here's the FINAL/OVERRIDE CL just mentioned.
The FINAL/OVERRIDE macros expand to empty unless C++11 is enabled
explicitly,
i.e. using CXXFLAGS=-std=c++11 with clang++ or a recent GCC.
https://codereview.chromium.org/23098004/
--
--
v8-d
Reviewers: danno, Sven Panne,
Message:
This is a first baby-step towards platform cleanup, instead of trying to do
everything at once as I did last time. The OS_* defines are mostly
compatible
with what Chromium uses, which will allow for easier sharing/copying w/o
breakage on our side (i.e. t
Reviewers: danno, Sven Panne, rossberg,
Message:
PTAL
Description:
ARM: Fix register misuse bug in Allocate().
The bug is triggered if flags contains DOUBLE_ALIGNMENT and the
object_size is not an ARM immediate value. In this case, the code
for DOUBLE_ALIGNMENT uses the scratch2 register, which
Committed patchset #1 manually as r16221.
https://codereview.chromium.org/23323002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
On 2013/08/19 12:44:47, Sven Panne wrote:
https://codereview.chromium.org/23098004/diff/1/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/23098004/diff/1/src/globals.h#newcode382
src/globals.h:382: #if __cplusplus >= 201103L
Looking at Chrome's base/compiler_specific.
PTAL
https://chromiumcodereview.appspot.com/23098004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails f
Committed patchset #3 manually as r16222.
https://codereview.chromium.org/23098004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Reviewers: Sven Panne, Jakob, danno, Dmitry Lomov (chromium),
Message:
PTAL
Description:
Use FINAL and OVERRIDE in various places, fixing bugs revealed by them.
- Use FINAL and OVERRIDE in objects.
- Use FINAL and OVERRIDE in Ast classes.
- Use FINAL and OVERRIDE in Lithium mips backend.
- Use
On 2013/08/19 16:20:22, Dmitry Lomov (chromium) wrote:
LGTM!
I think we should make the use of FINAL and OVERRIDE mandatory in all new
code
(except additions to public API)
Hm, looking through the code again, we should probably use V8_FINAL and
V8_OVERRIDE to avoid collisions with other peop
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16230.
Description:
Revert "Add FINAL and OVERRIDE macros for C++11 final/override."
This reverts commit r16222 for not using V8_ prefix.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16230
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16231.
Description:
Add V8_FINAL and V8_OVERRIDE macros for C++11 final/override.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16231
Please review this at https://codereview.chromium.org/2
On 2013/08/19 18:20:01, Benedikt Meurer wrote:
On 2013/08/19 16:20:22, Dmitry Lomov (chromium) wrote:
> LGTM!
> I think we should make the use of FINAL and OVERRIDE mandatory in all
new
code
> (except additions to public API)
Hm, looking through the code again, we should probably use V8_FI
Committed patchset #2 manually as r16232.
https://codereview.chromium.org/23064017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16236.
Description:
Fix non-Xcode build on Mac with clang.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16236
Please review this at https://codereview.chromium.org/22793008/
SVN Base: htt
https://codereview.chromium.org/23283010/diff/5001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/23283010/diff/5001/tools/gyp/v8.gyp#newcode791
tools/gyp/v8.gyp:791: 'V8_OS_BSD=1',
On 2013/08/20 08:27:26, Jakob wrote:
really?
Nope, copy&paste, fixed.
https:/
Committed patchset #3 manually as r16238.
https://codereview.chromium.org/23283010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
LGTM after offline discussion, but as said, someone with better knowledge of
these internals should have a look at this
https://chromiumcodereview.appspot.com/22911018/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16241.
Description:
Visual Studio 2012 and later support the C++11 final keyword.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16241
Please review this at https://codereview.chromium.org/2
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16243.
Description:
Revert "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs
revealed by
them."
This reverts commit r16232 for breaking the
tools/gen-postmortem-metadata.py script. Will reland without the
objects.{
Reviewers: Dmitry Lomov (chromium),
Message:
Committed patchset #1 manually as r16244.
Description:
Reland "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs
revealed by
them.".
- Use V8_FINAL and V8_OVERRIDE in Ast classes.
- Use V8_FINAL and V8_OVERRIDE in Lithium mips backend.
-
LGTM
On a side note: The system memcpy() is pretty much optimal nowadays in
nearly
all cases, but we still try to be smarter? :-)
https://chromiumcodereview.appspot.com/23330005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this me
Reviewers: Sven Panne, Dmitry Lomov (chromium),
Message:
PTAL
Description:
Improve detection of C++11 features.
Also improve detection of V8_INFINITY while we're at it.
Please review this at https://chromiumcodereview.appspot.com/23323003/
SVN Base: https://v8.googlecode.com/svn/branches/blee
https://chromiumcodereview.appspot.com/23156006/diff/1/src/globals.h
File src/globals.h (right):
https://chromiumcodereview.appspot.com/23156006/diff/1/src/globals.h#newcode170
src/globals.h:170: #define V8_BETTER_OPERAND_ON_RIGHT
I don't like this #define. Why not switch the order for the
XXXMe
What's the benefit of this change, other than trying to somehow unify the
code
paths?
https://chromiumcodereview.appspot.com/23115005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
lgtm
https://chromiumcodereview.appspot.com/23129003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
1 - 100 of 725 matches
Mail list logo
