Closing.
https://codereview.chromium.org/1217803004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
So I ended up doing roughly what Andreas suggested.
For example Abs is a Number -> Number
But when it's actually encountered, there's a direct check on each of the
parameters making it polymorphic at the specific site.
One thing there isn't as much of as there shoud be, is testing around this.
Adding more tests did turn up an intedirectly related issue.
+fround(x) wasn't begin handled correctly. :-(
https://codereview.chromium.org/1217803004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: dehrenberg,
Description:
Pulling in a gyp fix for wasm.
BUG= https://github.com/WebAssembly/v8-native-prototype/issues/10
TEST=manual check of wasm=on
R=dehrenb...@chromium.org
LOG=N
Please review this at https://codereview.chromium.org/1306753007/
Base URL:
Reviewers: dehrenberg,
Description:
Follow symlinks in test/mjsunit to allow linked test directories.
Wasm mjsunit tests aren't being detected when symlinked into
test/mjsunit/wasm. This causes symlinked directories in that
directory to be included.
BUG=None
TEST=local
Reviewers: titzer,
Description:
Eliminate use of CompilationInfo in several AstVisitor descendants.
We're moving away from using CompilationInfo as a big bag o' stuff.
Passing in just what we need to several AstVisitors to avoid
increasing the problem.
BUG=None
TEST=trybots
https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visitor.h
File src/ast-expression-visitor.h (right):
https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visitor.h#newcode25
src/ast-expression-visitor.h:25: FunctionLiteral* root);
On 2015/09/01
https://codereview.chromium.org/1322773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Will do a similar switch on the other AstVisitors in another CL.
https://codereview.chromium.org/1322773002/diff/110001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/110001/src/typing-asm.cc#newcode44
src/typing-asm.cc:44:
Reviewers: titzer,
Description:
Drop region parameter to Unbounded, as it can be done without.
Unbounded is defined in terms of None any Any,
which don't require an explicit zone.
Switching Unbounded to be the same.
BUG= None
TEST= trybots
R= tit...@chromium.org
LOG=N
Please review this at
PTAL
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode59
src/typing-asm.cc:59: #define RECURSE_EXPR(expr, expected_type, msg)
\
On 2015/08/31
PTAL
https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-type-collector-macros.h
File test/cctest/expression-type-collector-macros.h (right):
https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-type-collector-macros.h#newcode17
PTAL
https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-type-collector-macros.h
File test/cctest/expression-type-collector-macros.h (right):
https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-type-collector-macros.h#newcode17
PTAL
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc#newcode343
src/typing-asm.cc:343: RECURSE(VisitWithExpectation(stmt->cond(),
cache_.kInt32,
On 2015/08/31
Reviewers: rossberg, titzer,
Description:
Refactor type collector testing macros.
Assume a zone is in scope instead of a handles object.
Move INT32_TYPE into test-typing-reset.
Provide a CHECK_SKIP() macro to allow skipping
sections of an ast expression walk.
BUG=
Reviewers: rossberg, titzer,
Description:
Treat the x*1 generated by parsing a unary + as containing a dot.
Since we convert +x to x*1, we loose information about whether
the 1 was intended to be a floating point value for asm.js or not.
Mark the generated 1 as containing a dot (i.e. 1.0).
Reviewers: rossberg, titzer,
Description:
Add asm.js typer + validator.
Walk asm.js module ASTs, attach concrete type information
in preparation for generating a WASM module.
cctest test coverage (mjsunit coming in later CL).
Expressions, function tables, and foreign functions have coverage.
Reviewers: andreas_chromium.org, titzer,
Description:
Spliting out TyperCache into ZoneTypeCache to share with AsmTyper.
The zone type cache would be handy inside the asm.js typer.
Pulling it out into a seperate inlinable header to allow sharing.
Reviewers: rossberg, titzer,
Description:
Visit AST Property nodes as expressions in AstExpressionVisitor.
Left out by mistake, correcting.
BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-ast-expression-visitor, test-typing-reset
R=rossb...@chromium.org,tit...@chromium.org
PTAL
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc#newcode116
src/ast-expression-visitor.cc:116: VisitExpression(label);
On 2015/08/25
ptal
https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc#newcode235
src/ast-expression-visitor.cc:235: void
Back to the macros as discussed.
https://codereview.chromium.org/1288773007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: rossberg, titzer,
Description:
Fix AstExpressionVisitor to correctly handle switch + for.
These were missed by the previous tests,
uncovered in another context.
BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-ast-expression-visitor
PTAL
https://codereview.chromium.org/1288773007/diff/160001/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1288773007/diff/160001/src/ast-expression-visitor.cc#newcode17
src/ast-expression-visitor.cc:17: #define RECURSE(call)
https://codereview.chromium.org/1288773007/diff/220001/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1288773007/diff/220001/src/ast-expression-visitor.cc#newcode63
src/ast-expression-visitor.cc:63: RECURSE(Visit(stmt));
So Visit has
Reviewers: rossberg, titzer,
Description:
Don't allocate AstTyper with the zone allocator.
While the class Type objects the AstTyper generates should be
allocated to zone memory, there's no particular reason
the typer object itself needs to be.
BUG=None
TEST=None
PTAL
That it much niced not needing to plumb in the zone.
I've sent out separate CL to change typing.h similarly.
I also looked at one of the items in hydrogen.h too that uses this pattern,
but
it appears to actually need it, as that object gets handed to an
OptimizedCompileJob, which is
Reviewers: rossberg, titzer,
Description:
Adding visitors to regurgitate expression types or reset them.
Adding an AstExpressionVisitor to touch each expression node in
an AST.
Adding TypingReseter to clear the slate after a failed asm.js
validation that has set partial typing information.
PTAL
This now gathers a list of expression type entries and uses macros to
express
the expected tree structure. Failures will pinpoint the line and reason for
the
failure.
This should allow tests confirming that typing is correct.
The macros could be made less verbose I suppose, at the
Reviewers: Nick Bray (chromium), titzer,
Description:
Add a makefile option for wasm prototype.
BUG=None
TEST=manual
R=tit...@chromium.org,ncb...@chromium.org
LOG=N
Please review this at https://codereview.chromium.org/1293073004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
https://codereview.chromium.org/1294543006/diff/130001/DEPS
File DEPS (right):
https://codereview.chromium.org/1294543006/diff/130001/DEPS#newcode15
DEPS:15: v8/third_party/wasm:
On 2015/08/18 14:20:40, Michael Starzinger wrote:
Can we for now not pull this dependency? People working on
Reviewers: titzer,
Description:
Pulling in wasm v8-native-prototype behind a gyp define.
Allowing optional build of a WASM prototype behind a gyp define.
BUG=None
TEST=None
R=tit...@chromium.org
LOG=N
Please review this at https://codereview.chromium.org/1294543006/
Base URL:
Reviewers: Dan Ehrenberg, Michael Achenbach,
Description:
Adding CHECKED_OUT_VERSION to .gitignore.
Adding CHECKED_OUT_VERSION in test/simdjs so that
the bots don't revert and redownload each time.
LOG=N
BUG=None
TEST=None
R=little...@chromium.org,machenb...@chromium.org
Please review this at
It's doing it due to the version file not being in .gitignore.
So the bots are reverting it on each run.
Sending out a change.
https://codereview.chromium.org/1240453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
lgtm
https://codereview.chromium.org/1244003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Thanks for fixing!
https://codereview.chromium.org/1244003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
https://codereview.chromium.org/1240453003/diff/1/test/simdjs/testcfg.py
File test/simdjs/testcfg.py (right):
https://codereview.chromium.org/1240453003/diff/1/test/simdjs/testcfg.py#newcode88
test/simdjs/testcfg.py:88: checked_out_revision != revision):
On 2015/07/21 06:58:17, Michael
Ping machenbach for OWNERS?
https://codereview.chromium.org/1240453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: bbudge, Michael Achenbach,
Description:
Make simdjs tests redownload on a revision change.
LOG=N
BUG=None
TEST=manual,local
R=bbu...@chromium.org,machenb...@chromium.org
Please review this at https://codereview.chromium.org/1240453003/
Base URL:
Not clear on what you guys are asking for?
You'd rather it not keep around the last version and/or the tar.gz?
https://codereview.chromium.org/1240453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Thank Andreas, that might explain some of the oddnesses I've encountered
applying this!
Since use of properties is carefully constrained in asm.js, doing things in
VisitProperty probably can work. I'll explore more.
Some other type system questions:
* Should Function(R, S, T0, T1...) types be
Reviewers: rossberg, titzer,
Message:
Any thoughts on naming with this?
I'm a little concerned Object is overused generally.
Description:
Add a type for objects with typed properties.
asm.js assumes a standard library object, exposing a subset of window +
window.Math, will be passed to
FWIW, the spec has two main places this comes up (in the positive), near
annotations and later with numeric literals. In the annotations section
only
'.'s are mentioned. Near literals case has the ambiguous phrase: or
validates
as type double.
I doubt in practice actual asm.js code cares,
We clarified with Alon Zakai, it sounds like '.' is the sole marker, as 1e3
for
ints etc. are currently done.
https://codereview.chromium.org/1201783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h#newcode148
src/ast-value-factory.h:148: bool ContainsDot() const { return type_ ==
NUMBER_WITH_DOT; }
ping?
https://codereview.chromium.org/1201783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1201783003/diff/1/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/1201783003/diff/1/src/scanner.cc#newcode1436
src/scanner.cc:1436: bool Scanner::ContainsDot() {
On 2015/06/22 07:53:43, Sven Panne wrote:
Instead of using caveman-style
Reviewers: rossberg, titzer,
Message:
Two questions:
* Should I plumb through the dot detection deeper into StringToDouble. I'm
unsure how much to lean on the compiler to do good things?
* Is there a more compact pattern to test this with?
Description:
Allow numeric literals to be checked for
https://codereview.chromium.org/1144263002/diff/1/test/simdjs/generate.py
File test/simdjs/generate.py (right):
https://codereview.chromium.org/1144263002/diff/1/test/simdjs/generate.py#newcode35
test/simdjs/generate.py:35: 'timeout_android_arm': 120,
On 2015/05/21 10:14:26, Michael Achenbach
PTAL
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json
File test/simdjs/SimdJs.json (right):
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode3
test/simdjs/SimdJs.json:3: run_count: 5,
On 2015/05/20 10:33:16, Michael Achenbach wrote:
Is
Reviewers: bbudge, Michael Achenbach,
Description:
Add perf json for simd.js benchmarks.
Using a script to generate the somewhat redundant json.
BUG=v8:4124
LOG=N
R=machenb...@chromium.org,bbu...@chromium.org
TEST=None
Please review this at https://codereview.chromium.org/1146073002/
Base
On 2015/05/20 12:20:03, Michael Achenbach wrote:
lgtm
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json
File test/simdjs/SimdJs.json (right):
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode27
test/simdjs/SimdJs.json:27: flags:
https://codereview.chromium.org/1146073002/diff/20001/test/simdjs/generate.py
File test/simdjs/generate.py (right):
https://codereview.chromium.org/1146073002/diff/20001/test/simdjs/generate.py#newcode56
test/simdjs/generate.py:56: fh.write(json.dumps(output,
separators=(',',': '), indent=2))
lgtm
https://codereview.chromium.org/1149723002/diff/40001/test/simdjs/generate.py
File test/simdjs/generate.py (right):
https://codereview.chromium.org/1149723002/diff/40001/test/simdjs/generate.py#newcode62
test/simdjs/generate.py:62: with open(os.path.join(SCRIPT_DIR,
'SimdJs.json'), 'w')
Reviewers: Michael Achenbach,
Description:
Dropping iterations and speedup from perf results.
The dashboard displays everything on one scale.
This isn't very useful.
Dropping these two fields as they're not really that
interesting anyway.
BUG=https://code.google.com/p/v8/issues/detail?id=4124
Reviewers: Michael Achenbach,
Description:
Skip presubmits when doing --download-data-only.
BUG=v8:4124
LOG=N
R=machenb...@chromium.org
TEST=None
Please review this at https://codereview.chromium.org/1148093002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2,
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js
File test/simdjs/harness-adapt.js (right):
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js#newcode29
test/simdjs/harness-adapt.js:29:
On 2015/05/19 08:36:01, bbudge (OOO week of 5-11)
Gentle ping.
Ben plans to rebase as jochen refactors.
More feedback would be helpful.
Thanks :-)
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
58 matches
Mail list logo
