[v8-dev] Re: Extend TF test coverage to supported targets. (issue 432313002 by mstarzin...@chromium.org)

2014-08-01 Thread danno via v8-dev
lgtm https://codereview.chromium.org/432313002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Remove accidental duplication in cctest suite. (issue 423313004 by mstarzin...@chromium.org)

2014-07-30 Thread danno via v8-dev
lgtm https://codereview.chromium.org/423313004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Add missing generated tests. (issue 425263002 by mstarzin...@chromium.org)

2014-07-30 Thread danno via v8-dev
lgtm https://codereview.chromium.org/425263002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Add clang-format to presubmit checks (issue 362263002 by joc...@chromium.org)

2014-07-02 Thread danno via v8-dev
lgtm https://codereview.chromium.org/362263002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re-land Clusterfuzz identified overflow check needed in dehoisting. (issue 317963004)

2014-06-06 Thread danno via v8-dev
lgtm https://codereview.chromium.org/317963004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Revert "Make 'name' property on functions configurable." (issue 297163009)

2014-05-27 Thread danno via v8-dev
rubber-stamp lgtm https://codereview.chromium.org/297163009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving e

[v8-dev] Re: If map became unstable, abort compilation and allow re-compilation. (issue 291653006)

2014-05-22 Thread danno via v8-dev
lgtm https://codereview.chromium.org/291653006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Allow microtasks to throw exceptions and handle them gracefully (issue 294943009)

2014-05-22 Thread danno via v8-dev
https://codereview.chromium.org/294943009/diff/50001/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/294943009/diff/50001/src/isolate.cc#newcode2294 src/isolate.cc:2294: goto done; DBC: Please, no goto. Either the explicit return or the simple break is much preferable