Reviewers: yurys, vsevik,
Message:
Yury, please take a look.
Description:
[V8] Send AfterCompile and CompileError messages in debug scope
R=yu...@chromium.org,vse...@chromium.org
BUG=396013
Please review this at https://codereview.chromium.org/642863007/
Base URL:
Reviewers: vsevik,
Description:
Add ScriptID field into ScriptOrigin class.
Please review this at https://codereview.chromium.org/363553005/
SVN Base: git://github.com/v8/v8.git@master
Affected files (+15, -3 lines):
M include/v8.h
M src/api.cc
Index: include/v8.h
diff --git
Yang, please take a look.
https://codereview.chromium.org/363553005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2014/06/26 10:25:39, Yang wrote:
https://codereview.chromium.org/264333007/diff/230001/test/mjsunit/debug-compile-event.js
File test/mjsunit/debug-compile-event.js (right):
https://codereview.chromium.org/264333007/diff/230001/test/mjsunit/debug-compile-event.js#newcode121
Reviewers: vsevik,
Message:
Flags was added with live edit. Now, it isn't used.
There is one function - Debug::OnAfterCompile, where the flags used in the
past:
if (was_in_scope (after_compile_flags SEND_WHEN_DEBUGGING) == 0)
return;
(after_compile_flags SEND_WHEN_DEBUGGING) == 0 is not
On 2014/06/11 11:52:14, yurys wrote:
https://codereview.chromium.org/264333007/diff/150001/src/debug.h
File src/debug.h (left):
https://codereview.chromium.org/264333007/diff/150001/src/debug.h#oldcode368
src/debug.h:368: NO_AFTER_COMPILE_FLAGS,
It might make sense to do this clean-up in a
Yang, please take a look.
https://codereview.chromium.org/353823004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Please, don't commit this patch without next:
1. https://codereview.chromium.org/260513004/ - replaced
GetScriptResourceName
in blink.
2. https://codereview.chromium.org/334203002/ - replaced
GetScriptResourceName
in chrome and extensions.
3. https://codereview.chromium.org/331133004/ -
On 2014/06/16 09:23:18, kozyatinskiy wrote:
Please, don't commit this patch without next:
1. https://codereview.chromium.org/260513004/ - replaced
GetScriptResourceName
in blink.
2. https://codereview.chromium.org/334203002/ - replaced
GetScriptResourceName
in chrome and extensions.
3.
On 2014/06/16 12:40:53, yurys wrote:
lgtm
https://codereview.chromium.org/265593002/diff/180001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/265593002/diff/180001/src/api.cc#newcode1953
src/api.cc:1953: isolate));
style: wrong indentation.
Fixed.
Yang, could you do OWNER review?
https://codereview.chromium.org/264333007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
On 2014/06/11 14:33:37, Yang wrote:
https://codereview.chromium.org/264333007/diff/150001/src/debug.cc
File src/debug.cc (left):
https://codereview.chromium.org/264333007/diff/150001/src/debug.cc#oldcode2705
src/debug.cc:2705: if (was_in_scope (after_compile_flags
SEND_WHEN_DEBUGGING) == 0)
On 2014/06/05 11:52:37, Yang wrote:
On 2014/06/05 11:44:03, vsevik wrote:
Now that I looked closer at this API, I see (if I'm not mistaken) two
ways
to
get the script name of where the exception was thrown:
- Through the script in the Message object, like exposed in this CL.
- Through
On 2014/05/28 10:41:20, Yang wrote:
Committed patchset #1 manually as r21560 (presubmit successful).
Hi, Yang.
I added test to Blink's layout tests:
https://codereview.chromium.org/329533002
This test fails after revision about May 30.
Could you please have a look on test and fix it, if
On 2014/06/10 14:57:45, Yang wrote:
lgtm with comment.
https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc#newcode1732
src/isolate.cc:1732: if (is_finally_on_top) {
can't we
Moved OnSyntaxError call to Parser.
Removed AfterCompile flags.
https://codereview.chromium.org/264333007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Michael Starzinger, vsevik, Yang,
Message:
Yang and Michael, Could you please have a look on last patch set?
Description:
This patch continues https://codereview.chromium.org/306463002/
First patch set is last reviewed patch set from
https://codereview.chromium.org/306463002/
This patch continues https://codereview.chromium.org/306463002/
First patch set is last reviewed patch set from
https://codereview.chromium.org/306463002/
Second patch set have fixed bug with ASSERT(!handler-is_catch()) in
Isolate::IsFinallyOnTop(). It is essentially to not check IsFinallyOnTop
On 2014/06/06 16:12:01, vsevik wrote:
https://chromiumcodereview.appspot.com/264333007/diff/20001/include/v8-debug.h
File include/v8-debug.h (right):
https://chromiumcodereview.appspot.com/264333007/diff/20001/include/v8-debug.h#newcode25
include/v8-debug.h:25: ScriptFailedToParse = 9
https://codereview.chromium.org/306463002/diff/80001/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/306463002/diff/80001/src/isolate.h#newcode1182
src/isolate.h:1182: // Propagate pending exception message to the external
try-catch.
nit: s/external
On 2014/06/02 15:21:16, Yang wrote:
Looking good. I got some comments. And I would like to add mstarzinger@
for a
second opinion.
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc
File src/isolate.cc (right):
On 2014/06/02 09:19:55, vsevik wrote:
https://chromiumcodereview.appspot.com/306463002/diff/20001/src/isolate.cc
File src/isolate.cc (right):
https://chromiumcodereview.appspot.com/306463002/diff/20001/src/isolate.cc#newcode1730
src/isolate.cc:1730: bool has_externaly_caught =
On 2014/05/28 18:00:31, vsevik wrote:
Can we add a test?
Yes, we can. Done.
https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc#newcode1727
src/isolate.cc:1727: // Return
Reviewers: vsevik,
Description:
V8 don't clear exception pending message if we have externally try catch
block,
but there is finally block on top of stack.
Please review this at https://codereview.chromium.org/306463002/
SVN Base: git://github.com/v8/v8.git@master
Affected files (+22, -12
Reviewers: vsevik,
Description:
Add OnSyntaxError handler and v8::ScriptfailedToParse debug event
Work in progress.
BUG=
Please review this at https://codereview.chromium.org/264333007/
SVN Base: git://github.com/v8/v8.git@master
Affected files (+86, -6 lines):
M include/v8-debug.h
M
On 2014/05/05 07:30:40, yurys wrote:
https://chromiumcodereview.appspot.com/265593002/diff/90001/include/v8.h
File include/v8.h (right):
https://chromiumcodereview.appspot.com/265593002/diff/90001/include/v8.h#newcode1137
include/v8.h:1137: HandleValue GetScriptResourceNameOrSourceURL()
Reviewers: vsevik,
https://codereview.chromium.org/265593002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/265593002/diff/40001/test/cctest/test-api.cc#newcode17691
test/cctest/test-api.cc:17691: //# sourceURL=foo2.js\;\n
On 2014/04/30
27 matches
Mail list logo
