[v8-dev] Merged r15914 into trunk branch. (issue 21425002)

Reviewers: Jakob, Description: Merged r15914 into trunk branch. MIPS: Fix debug mode webkit failures. BUG=v8:2808 R=jkumme...@chromium.org Please review this at https://codereview.chromium.org/21425002/ SVN Base: https://v8.googlecode.com/svn/trunk Affected files: M src/mips/assembler-mi

[v8-dev] Re: Merged r15914 into trunk branch. (issue 21425002)

Hi Jakob, This CL solves hundreds of debug mode failures in debug mode on MIPS. PTAL. https://codereview.chromium.org/21425002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups

[v8-dev] Re: Merged r15914 into trunk branch. (issue 21425002)

Committed manually as r15995 (presubmit successful). https://codereview.chromium.org/21425002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fr

[v8-dev] MIPS: Avoid redundant smi check for Math.abs (issue 21903003)

Reviewers: Jakob, danno, kisg, kilvadyb, Paul Lind, Message: PTAL. Description: MIPS: Avoid redundant smi check for Math.abs Port r16021 (d79f4450) BUG= Please review this at https://codereview.chromium.org/21903003/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected f

[v8-dev] Re: MIPS: Avoid redundant smi check for Math.abs (issue 21903003)

Committed manually as r16035 (presubmit successful). https://codereview.chromium.org/21903003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fr

[v8-dev] MIPS: Replace HCheckPrototypeMaps by explicit map checks of constant values. (issue 21639003)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Toon Verwaest, Message: PTAL. Description: MIPS: Replace HCheckPrototypeMaps by explicit map checks of constant values. Port r16055 (7567e57f) BUG= Please review this at https://codereview.chromium.org/21639003/ SVN Base: https://v8.googlecode.co

[v8-dev] Re: MIPS: Replace HCheckPrototypeMaps by explicit map checks of constant values. (issue 21639003)

Committed manually as r16060 (presubmit successful). https://codereview.chromium.org/21639003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fr

[v8-dev] MIPS: Migrate instance of deprecated maps in HCheckMaps. (issue 22254007)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Toon Verwaest, Message: PTAL. Description: MIPS: Migrate instance of deprecated maps in HCheckMaps. Port r16057 (b73ae514) Original commit message: Currently only direct map checks are supported. Otherwise only polymorphic cases with a generic fal

[v8-dev] Re: MIPS: Migrate instance of deprecated maps in HCheckMaps. (issue 22254007)

Committed manually as r16062 (presubmit successful). https://codereview.chromium.org/22254007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fr

[v8-dev] MIPS: Fix Sunspider 1.0/crypto-aes. (issue 22491002)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Jakob, Message: PTAL. Description: MIPS: Fix Sunspider 1.0/crypto-aes. * This makes sure that DoModI calculates correct result even when the left register is the same as the result register. * Microoptmization: it generates smaller code when left a

[v8-dev] Re: MIPS: Fix Sunspider 1.0/crypto-aes. (issue 22491002)

Committed manually as r16085 (presubmit successful). https://codereview.chromium.org/22491002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fr

[v8-dev] Re: Removed wrong ASSERTs on MIPS. (issue 22571003)

LGTM, thanks! https://codereview.chromium.org/22571003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] MIPS: First implementation of allocation elimination in Hydrogen. (issue 22580003)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Michael Starzinger, Message: PTAL. Description: MIPS: First implementation of allocation elimination in Hydrogen. Port r16098 (328ff5f7) Original commit message: This change implements a simple data-flow analysis pass over captured objects to the ex

[v8-dev] Re: MIPS: First implementation of allocation elimination in Hydrogen. (issue 22580003)

Committed manually as r16107 (presubmit successful). https://codereview.chromium.org/22580003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fr

[v8-dev] Re: MIPS: Optimize DoCheckMaps. (issue 22391008)

It looks good to me, thanks for optimizing this! https://codereview.chromium.org/22391008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from t

[v8-dev] MIPS: Patch to enhance the source code line information for profiler. (issue 22502006)

Reviewers: Paul Lind, kisg, kilvadyb, danno, chunyang.dai, Message: PTAL. Description: MIPS: Patch to enhance the source code line information for profiler. Port r16114 (2d1bf399) Original commit message: This patch is to enhance the source code line information for profiler. For the Hydrogen

[v8-dev] Re: MIPS: Patch to enhance the source code line information for profiler. (issue 22502006)

Committed manually as r16118 (presubmit successful). https://codereview.chromium.org/22502006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fr

[v8-dev] MIPS: Replace LoadNamedFieldPolymorphic with explicit branches. (issue 22255005)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Toon Verwaest, Message: PTAL. Description: MIPS: Replace LoadNamedFieldPolymorphic with explicit branches. Port r16133 (dce32514) BUG= Please review this at https://codereview.chromium.org/22255005/ SVN Base: https://v8.googlecode.com/svn/branche

[v8-dev] Re: MIPS: Replace LoadNamedFieldPolymorphic with explicit branches. (issue 22255005)

Committed manually as r16151. https://codereview.chromium.org/22255005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] MIPS: Make assert more accurate (issue 22956002)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Toon Verwaest, Message: PTAL. Description: MIPS: Make assert more accurate Port r16147 (1ced433a) BUG= Please review this at https://codereview.chromium.org/22956002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files:

[v8-dev] Re: MIPS: Make assert more accurate (issue 22956002)

Committed manually as r16164. https://codereview.chromium.org/22956002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] MIPS: Store doubles before calling into the elements transition stub (issue 23110002)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Toon Verwaest, Message: PTAL. Description: MIPS: Store doubles before calling into the elements transition stub Port r16172 (cc2b6204) BUG= Please review this at https://codereview.chromium.org/23110002/ SVN Base: https://v8.googlecode.com/svn/br

[v8-dev] Re: MIPS: Store doubles before calling into the elements transition stub (issue 23110002)

Committed manually as r16182. https://codereview.chromium.org/23110002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all us… (issue 23130006)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Toon Verwaest, Message: PTAL. Description: MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all uses allow undefined as nan. Port r16183 (1858bc57) BUG= Please review this at https://codereview.chromi

[v8-dev] Re: MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all us… (issue 23130006)

Fixed nits. https://codereview.chromium.org/23130006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails f

[v8-dev] Re: MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all us… (issue 23130006)

Thanks for the review, I've fixed the nits. https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips.cc#newcode2325 src/mips/lithium-codegen-mips.

[v8-dev] Re: MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all us… (issue 23130006)

Committed manually as r16200. https://codereview.chromium.org/23130006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Merged r16200 into trunk branch. (issue 23026005)

Reviewers: Jakob, Description: Merged r16200 into trunk branch. MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all uses allow undefined as nan. R=jkumme...@chromium.org BUG= Please review this at https://codereview.chromium.org/23026005/ SVN B

[v8-dev] Re: Merged r16200 into trunk branch. (issue 23026005)

PTAL. https://codereview.chromium.org/23026005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Re: Merged r16200 into trunk branch. (issue 23026005)

Committed manually as r16201. https://codereview.chromium.org/23026005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] MIPS: Remove wrong restriction in GenerateDeoptJumpTable. (issue 23020018)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Message: PTAL. Description: MIPS: Remove wrong restriction in GenerateDeoptJumpTable. * This Abort condition does not applies to MIPS, since the assembler can also emit long Branches automatically, when it is needed. TEST=mjsunit/math-floor-of-d

[v8-dev] Re: MIPS: Remove wrong restriction in GenerateDeoptJumpTable. (issue 23020018)

Committed manually as r16223. https://codereview.chromium.org/23020018/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] MIPS: Remove platform-specific dead code for KeyedStores (issue 22815014)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Message: PTAL. Description: MIPS: Remove platform-specific dead code for KeyedStores Port r16227 (02df4098) BUG= Please review this at https://codereview.chromium.org/22815014/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affec

[v8-dev] Re: MIPS: Remove platform-specific dead code for KeyedStores (issue 22815014)

Committed manually as r16251. https://codereview.chromium.org/22815014/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: MIPS: Add a trap_on_abort flag. (issue 22877043)

Committed as r16342. https://codereview.chromium.org/22877043/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] MIPS: remove old style callbacks (issue 23479007)

Reviewers: Paul Lind, kisg, kilvadyb, danno, dcarney, Message: PTAL. Description: MIPS: remove old style callbacks Port r16354 (559bc02d) BUG= Please review this at https://codereview.chromium.org/23479007/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M

[v8-dev] MIPS: Convert FastNewClosureStub into hydrogen. (issue 23618007)

Reviewers: Paul Lind, kisg, kilvadyb, danno, mvstanton, Message: PTAL. Description: MIPS: Convert FastNewClosureStub into hydrogen. Port r16356 (0a0ea300) BUG= Please review this at https://codereview.chromium.org/23618007/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Aff

[v8-dev] MIPS: Fix Cluster Fuzz stack frame corruption bug. (issue 23583004)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Hannes Payer, Message: PTAL. Description: MIPS: Fix Cluster Fuzz stack frame corruption bug. Port r16358 (a8a679b9) BUG= Please review this at https://codereview.chromium.org/23583004/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edg

[v8-dev] MIPS: cleanup api callbacks now that handles are never returned directly (issue 23604004)

Reviewers: Paul Lind, kisg, kilvadyb, danno, dcarney, Message: PTAL. Description: MIPS: cleanup api callbacks now that handles are never returned directly Port r16360 (72401868) BUG= Please review this at https://codereview.chromium.org/23604004/ SVN Base: https://v8.googlecode.com/svn/bran

[v8-dev] Re: MIPS: cleanup api callbacks now that handles are never returned directly (issue 23604004)

This CL depends on: https://codereview.chromium.org/23479007/ https://codereview.chromium.org/23604004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsub

[v8-dev] MIPS: Eliminate intentional conversion from Smi to Int32 in HMul (issue 23644002)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Toon Verwaest, weiliang.lin2, Message: PTAL. Description: MIPS: Eliminate intentional conversion from Smi to Int32 in HMul Port r16361 (b41ab14c) Original commit message: If not all uses of arithmetic binary operation can be truncated to Smi, chec

[v8-dev] MIPS: Eliminate Smi check when changing from Smi to Integer32 (issue 23462004)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Toon Verwaest, weiliang.lin2, Message: PTAL. Description: MIPS: Eliminate Smi check when changing from Smi to Integer32 Port r16362 (6dd68a5c) BUG= Please review this at https://codereview.chromium.org/23462004/ SVN Base: https://v8.googlecode.co

[v8-dev] Re: MIPS: remove old style callbacks (issue 23479007)

Committed manually as r16370. https://codereview.chromium.org/23479007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: MIPS: Convert FastNewClosureStub into hydrogen. (issue 23618007)

Committed manually as r16371. https://codereview.chromium.org/23618007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: MIPS: Fix Cluster Fuzz stack frame corruption bug. (issue 23583004)

Committed manually as r16372. https://codereview.chromium.org/23583004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: MIPS: cleanup api callbacks now that handles are never returned directly (issue 23604004)

Committed manually as r16373. https://codereview.chromium.org/23604004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: MIPS: Eliminate intentional conversion from Smi to Int32 in HMul (issue 23644002)

Committed manually as r16374. https://codereview.chromium.org/23644002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: MIPS: Eliminate Smi check when changing from Smi to Integer32 (issue 23462004)

Committed manually as r16375. https://codereview.chromium.org/23462004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: MIPS: thread isolate for files starting with 'b' and 'c'. (issue 23814003)

Committed as r16498. https://codereview.chromium.org/23814003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: MIPS: Improve TruncateNumberToI implementation after DoubleToIStub usage (r16461). (issue 23444033)

Committed as r16505. https://codereview.chromium.org/23444033/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: MIPS: store ics for js api accessors. (issue 23780003)

Committed as r16580. https://codereview.chromium.org/23780003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] MIPS/ARM: Fix benchmarks failures on simulator. (issue 24067002)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Jakob, Yang, Message: PTAL. Description: MIPS/ARM: Fix benchmarks failures on simulator. The default x87 FPU precision is usually 80-bit extended precision, which can lead to precision failures on several tests. This patch fixes the precision failure

[v8-dev] Re: MIPS: thread isolate for HConstant::handle. (issue 23444041)

Committed as r16596. https://codereview.chromium.org/23444041/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Merged r16596 into trunk branch. (issue 23766017)

Reviewers: Jakob, Description: Merged r16596 into trunk branch. MIPS: thread isolate for HConstant::handle. R=jkumme...@chromium.org BUG= Please review this at https://codereview.chromium.org/23766017/ SVN Base: https://v8.googlecode.com/svn/trunk Affected files (+10, -8 lines): M src/mips

[v8-dev] Re: Merged r16596 into trunk branch. (issue 23766017)

PTAL. https://codereview.chromium.org/23766017/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Re: Merged r16596 into trunk branch. (issue 23766017)

Committed patchset #1 manually as r16625. https://codereview.chromium.org/23766017/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro

[v8-dev] Re: MIPS: thread isolate for EntryHookTrampoline. (issue 23503050)

Committed as r16656. https://codereview.chromium.org/23503050/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: MIPS: remove most uses of Isolate::Current in arch specific files. (issue 24108002)

Committed as r16657. https://codereview.chromium.org/24108002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Merged r16656 into trunk branch. (issue 23981007)

Reviewers: Yang, Description: Merged r16656 into trunk branch. MIPS: thread isolate for EntryHookTrampoline. R=yang...@chromium.org BUG= Please review this at https://codereview.chromium.org/23981007/ SVN Base: https://v8.googlecode.com/svn/trunk Affected files (+4, -1 lines): M src/mips/c

[v8-dev] Re: Merged r16656 into trunk branch. (issue 23981007)

PTAL. https://codereview.chromium.org/23981007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Re: MIPS: Improve code generation for the HRandom instruction. (issue 23851028)

Committed as r16695. https://codereview.chromium.org/23851028/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] MIPS: Bugfix: array constructors that expect a type feedback cell that points to an AllocationSite … (issue 23604056)

Reviewers: Paul Lind, kisg, kilvadyb, danno, mvstanton, Description: MIPS: Bugfix: array constructors that expect a type feedback cell that points to an AllocationSite were being passed the undefined object in some cases. Clearly separate the cases where we have an AllocationSite and where w

[v8-dev] MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. (issue 24132002)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Michael Starzinger, Description: MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. Port r16688 (fcae0bcf) Original commit message: The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they contain the sam

[v8-dev] MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. (issue 23513045)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Michael Starzinger, Description: MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. Port r16688 (fcae0bcf) Original commit message: The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they contain the sam

[v8-dev] MIPS: Bugfix: array constructors that expect a type feedback cell that points to an AllocationSite … (issue 23451057)

Reviewers: Paul Lind, kisg, kilvadyb, danno, mvstanton, Description: MIPS: Bugfix: array constructors that expect a type feedback cell that points to an AllocationSite were being passed the undefined object in some cases. Clearly separate the cases where we have an AllocationSite and where w

[v8-dev] Re: MIPS: Bugfix: array constructors that expect a type feedback cell that points to an AllocationSite … (issue 23451057)

Committed patchset #1 manually as r16698 (presubmit successful). https://codereview.chromium.org/23451057/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. (issue 23513045)

Committed patchset #1 manually as r16697 (presubmit successful). https://codereview.chromium.org/23513045/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: MIPS: Fix of r16681 (issue 23437032)

Committed as r16694. https://codereview.chromium.org/23437032/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Merged r16656 into trunk branch. (issue 23981007)

Closing issue, this change is merged by r16670. https://codereview.chromium.org/23981007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from th

[v8-dev] Re: MIPS: Orthogonalize Lithium binary op instructions. (issue 23494054)

Committed patchset #1 manually as r16743 (presubmit successful). https://codereview.chromium.org/23494054/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] MIPS: Orthogonalize Lithium binary op instructions. (issue 23494054)

Reviewers: Paul Lind, kisg, kilvadyb, danno, oliv, Message: PTAL. Description: MIPS: Orthogonalize Lithium binary op instructions. Port r16739 (cd8e4a21) BUG= Please review this at https://codereview.chromium.org/23494054/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affec

[v8-dev] Re: MIPS: Save one branch for normal heap number un-tagging. (issue 24307005)

Committed as r16871. https://codereview.chromium.org/24307005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: MIPS: Fixed a bug in CopyBytes() and new test cases for MIPS macro assembler. (issue 24266007)

Committed as r16904. https://codereview.chromium.org/24266007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] MIPS: Turn the NumberToStringStub into a hydrogen stub. (issue 24436004)

Reviewers: Paul Lind, kisg, kilvadyb, Benedikt Meurer, danno, Message: PTAL. Description: MIPS: Turn the NumberToStringStub into a hydrogen stub. Port r16910 (5a0dd952) Original commit message: This adds a BuildLookupNumberStringCache() in Hydrogen, which will be used by the hydrogen version o

[v8-dev] Re: MIPS: Turn the NumberToStringStub into a hydrogen stub. (issue 24436004)

Committed patchset #1 manually as r16926 (presubmit successful). https://codereview.chromium.org/24436004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] MIPS: Tweak Math.exp. (issue 24654002)

Reviewers: Paul Lind, kisg, kilvadyb, danno, ulan, Rodolph Perfetta, Message: PTAL. Description: MIPS: Tweak Math.exp. Port r16913 (a1b66fea) Original commit message: Avoid corrupting the input and small assembly tuning. BUG= Please review this at https://codereview.chromium.org/24654002/ S

[v8-dev] Re: MIPS: Tweak Math.exp. (issue 24654002)

Committed patchset #1 manually as r16951 (presubmit successful). https://codereview.chromium.org/24654002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 2. (issue 24857002)

Reviewers: Paul Lind, kilvadyb, kisg, danno, marja, Message: PTAL. Description: MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 2. Port r16961 (ce471468) Original commit message: This step reorders the FunctionCallbackInfo fields. BUG= Please review this at https://codere

[v8-dev] Re: MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 2. (issue 24857002)

Committed patchset #1 manually as r16971 (presubmit successful). https://codereview.chromium.org/24857002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: MIPS: Fix simulator divide for overflow case. (issue 24956002)

Committed as r16982. https://codereview.chromium.org/24956002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] MIPS: Let the register allocator handle the context register. (issue 25420002)

Reviewers: Paul Lind, kisg, kilvadyb, danno, Rodolph Perfetta, Message: PTAL. Description: MIPS: Let the register allocator handle the context register. Port r16993 (afba553d) BUG= Please review this at https://codereview.chromium.org/25420002/ SVN Base: https://v8.googlecode.com/svn/branche

[v8-dev] Re: MIPS: Let the register allocator handle the context register. (issue 25420002)

Committed patchset #2 manually as r17059. https://codereview.chromium.org/25420002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro

[v8-dev] MIPS: Allow function inlining with context change. (issue 25622003)

Reviewers: Paul Lind, kisg, kilvadyb, danno, ulan, Rodolph Perfetta, Message: PTAL. Description: MIPS: Allow function inlining with context change. Port r17019 (cd4b69cd) BUG= Please review this at https://codereview.chromium.org/25622003/ SVN Base: https://v8.googlecode.com/svn/branches/ble

[v8-dev] Re: MIPS: Allow function inlining with context change. (issue 25622003)

Committed as r17070. https://codereview.chromium.org/25622003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] MIPS: Refactoring of code generation for declarations, in preparation for modules. (issue 10091013)

Reviewers: danno, rossberg, Paul Lind, kisg, kalmard, Message: Building and testing on mips also requires the following patches to be landed: http://codereview.chromium.org/10106007/ http://codereview.chromium.org/10103008/ Description: MIPS: Refactoring of code generation for declarations, i

[v8-dev] MIPS: Refactor code generation for global declarations. (issue 10106007)

Reviewers: danno, rossberg, Paul Lind, kisg, kalmard, Message: This patch can be applied on top of: http://codereview.chromium.org/10091013/ Building and testing on mips also requires the following patches to be landed: http://codereview.chromium.org/10103008/ Description: MIPS: Refactor cod

[v8-dev] MIPS: Implement rudimentary module linking. (issue 10103008)

Reviewers: danno, rossberg, Paul Lind, kisg, kalmard, Message: This patch can be applied on top of: http://codereview.chromium.org/10106007/ Building and testing on mips also requires the following patches to be landed: http://codereview.chromium.org/10091013/ Description: MIPS: Implement ru

[v8-dev] MIPS: Port function call type-feedback cells to x64 and ARM. (issue 10124013)

Reviewers: Michael Starzinger, danno, Paul Lind, kisg, kalmard, Description: MIPS: Port function call type-feedback cells to x64 and ARM. Port r11391 (789b1078) BUG= TEST= Please review this at https://chromiumcodereview.appspot.com/10124013/ SVN Base: https://v8.googlecode.com/svn/branches/

[v8-dev] MIPS: Reduce size of LIR instruction by one word and remove dead code. (issue 10233019)

Reviewers: fschneider, danno, Paul Lind, kisg, kalmard, Description: MIPS: Reduce size of LIR instruction by one word and remove dead code. Port r11454 (72c662fc) Original commit message: Reduce size of LIR instruction by one word and remove dead code. Until now we always recorded two deoptimi

[v8-dev] MIPS: Fix LFastLiteral to check boilerplate elements kind. (issue 10271018)

Reviewers: Michael Starzinger, danno, Paul Lind, kisg, kalmard, Description: MIPS: Fix LFastLiteral to check boilerplate elements kind. Port r11470 (621f96c0) Original commit message: Fix LFastLiteral to check boilerplate elements kind. Adds a missing check that the elements kind of the boiler

[v8-dev] Clean up Makefile, enable MIPS cross-compilation (issue 10268010)

It works fine for mips target with CodeSourcery toolchain, but it failed to build V8 with ubuntu's default gcc (4.4.3-4ubuntu5.1) for mips simulator, because gcc returns misleading return value (please look at my in-line comments). https://chromiumcodereview.appspot.com/10268010/diff/1/build/com

[v8-dev] Re: Added cross-build option in Makefile wrapper for gyp. (issue 10257030)

On 2012/04/30 15:16:15, Jakob wrote: Have a look at https://chromiumcodereview.appspot.com/10268010. The compiler seems happy both for cross-compilation and simulator builds; however lithium-codegen-mips.cc currently doesn't compile at all, so I couldn't inspect the resulting binaries. Adde

[v8-dev] Re: Clean up Makefile, enable MIPS cross-compilation (issue 10268010)

s" || echo -n "no")', On 2012/05/02 18:39:21, palfia wrote: This command: echo | $(echo ${CXX:-$(which g++)}) -EL -E - always returns 0 on my system, even if gcc doesn't support mips target. My suggestion is to use -march=mips32r3 instead of -EL . So the actual command wo

[v8-dev] Re: MIPS: Reduce size of LIR instruction by one word and remove dead code. (issue 10233019)

Rebased on r11482 https://chromiumcodereview.appspot.com/10233019/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] MIPS: ARM: Ensure reload of elements pointer in StoreFastDoubleElement stub (issue 10348016)

Reviewers: danno, Paul Lind, kisg, Message: Please apply this patch to the 3.10 branch as well. Description: MIPS: ARM: Ensure reload of elements pointer in StoreFastDoubleElement stub Port r11483 (c291e80e) BUG= TEST= Please review this at https://chromiumcodereview.appspot.com/10348016/ S

[v8-dev] MIPS: Implement clearing of CompareICs. (issue 10342024)

Reviewers: Michael Starzinger, danno, Paul Lind, kisg, Description: MIPS: Implement clearing of CompareICs. Port r11491 (705d40cc) Original commit message: Implement clearing of CompareICs. This allows CompareICs to be cleared during garbage collection to avoid cross-context garbage retention

[v8-dev] MIPS: Fix register clobbering in LoadIC for interceptors. (issue 10315016)

Reviewers: Michael Starzinger, danno, Paul Lind, kisg, Description: MIPS: Fix register clobbering in LoadIC for interceptors. Port r11492 (d14ada19) Original commit message: Fix register clobbering in LoadIC for interceptors. This fixes a corner-case where the receiver register was clobbered b

[v8-dev] Re: Added cross-build option in Makefile wrapper for gyp. (issue 10257030)

On 2012/05/03 09:20:20, Jakob wrote: I've landed https://chromiumcodereview.appspot.com/10268010. With the fix from https://chromiumcodereview.appspot.com/10233019/ applied in addition, it compiles fine both for a simulator build (on Ubuntu Precise, but Lucid should work too) and a cross-c

[v8-dev] [MIPS] Fixed illegal instrucion use on Loongson in code for Math.random(). (issue 10383044)

Reviewers: danno, Paul Lind, kisg, Message: This patch fixes issue: http://code.google.com/p/v8/issues/detail?id=2115 Description: [MIPS] Fixed illegal instrucion use on Loongson in code for Math.random(). BUG= TEST= Please review this at https://chromiumcodereview.appspot.com/10383044/ SVN

[v8-dev] Re: MIPS: Fixed illegal instruction use on Loongson in code for Math.random(). (issue 10383044)

On 2012/05/07 15:58:00, Paul Lind wrote: On 2012/05/07 15:50:50, palfia wrote: > This patch fixes issue: http://code.google.com/p/v8/issues/detail?id=2115 The code change LGTM. There are some style issues with the submission, please update: 1. Word 'instruction' in issue

  1   2   3   4   5   6   7   >