[v8-dev] Re: MIPS: Fix cctest/NaNs after r23767 "Replace our home-grown BitCast with bit_cast from Chrome/Google... (issue 548283002 by balazs.kilv...@imgtec.com)

2014-09-08 Thread plind44
LGTM. (from my gmail account to match outdated owners file in this dir) https://codereview.chromium.org/548283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" grou

[v8-dev] Re: MIPS: update owners. (issue 389463002 by akos.pa...@imgtec.com)

2014-07-10 Thread plind44
LGTM (as my old self). I don't know if my approval is enough for owners files though. https://codereview.chromium.org/389463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Group

[v8-dev] Re: Add mips64 port. (issue 371923006 by dusan.milosavlje...@rt-rk.com)

2014-07-07 Thread plind44
The MIPS64 part LGTM. https://codereview.chromium.org/371923006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivi

[v8-dev] Re: MIPS: Fix comment in r21905: "Support LiveEdit." (issue 345243005 by kilva...@homejinni.com)

2014-06-23 Thread plind44
lgtm https://codereview.chromium.org/345243005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Introduce intrinsic to expose debug state to generated code. (issue 343193005 by kilva...@homejinni.com)

2014-06-23 Thread plind44
lgtm https://codereview.chromium.org/343193005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Fix big-endian after r21774/r21803. (issue 334403003 by plin...@gmail.com)

2014-06-20 Thread plind44
Committed patchset #2 manually as r21906 (presubmit successful). https://codereview.chromium.org/334403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: MIPS: Fix big-endian after r21774/r21803. (issue 334403003 by plin...@gmail.com)

2014-06-19 Thread plind44
PTAL, got rid of the conditional compilation stuff from patch set 1. https://codereview.chromium.org/334403003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/334403003/diff/1/include/v8.h#newcode5520 include/v8.h:5520: #if defined (__BYTE_ORDER__) && (__BYTE_ORDE

[v8-dev] Re: MIPS: Interrupts must not mask stack overflow. (issue 338283005 by kilva...@homejinni.com)

2014-06-17 Thread plind44
lgtm https://codereview.chromium.org/338283005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Revert "Revert "Reland 21774: Generate KeyedLoadGeneric with Hydrogen"" (issue 331633002 by da...@chromium.org)

2014-06-17 Thread plind44
On 2014/06/17 13:45:40, mtbrandy wrote: This change introduces issues on big endian platforms. See inline comments. I have a fix for this in https://codereview.chromium.org/334403003/ PTAL, and add any comments, suggestions. https://codereview.chromium.org/331633002/ -- -- v8-dev mailing

[v8-dev] MIPS: Fix big-endian after r21774/r21803. (issue 334403003 by plin...@gmail.com)

2014-06-16 Thread plind44
Reviewers: danno, palfia, kilvadyb, dusmil, Message: PTAL. I'm not thrilled with using the compiler big/little endian definitions in v8.h, but the usual v8 definitions are not valid there. And since we play with the offset of the instance type, and it is exposed thru the API, I don't see muc

[v8-dev] Re: MIPS: Unbreak big-endian build after r21774. (issue 338513002 by pal...@homejinni.com)

2014-06-15 Thread plind44
patchset 2 NOT lgtm. It fails to build little endian arch's. https://codereview.chromium.org/338513002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsub

[v8-dev] Re: MIPS: Fix register usage after r21822. (issue 335753003 by pal...@homejinni.com)

2014-06-12 Thread plind44
lgtm https://codereview.chromium.org/335753003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Unbreak big-endian build after r21774. (issue 338513002 by pal...@homejinni.com)

2014-06-12 Thread plind44
Looks good to me. Danno, can you PTAL? https://codereview.chromium.org/338513002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group

[v8-dev] Re: MIPS: Fix r21780 - "Fixed flooring division by a power of 2, once again..." (issue 333713002)

2014-06-12 Thread plind44
Committed as r21822. https://codereview.chromium.org/333713002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Fix r21780 - "Fixed flooring division by a power of 2, once again..." (issue 333713002)

2014-06-12 Thread plind44
lgtm https://codereview.chromium.org/333713002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Fix unsigned comparison. (issue 329223006)

2014-06-12 Thread plind44
Committed as r21815. https://codereview.chromium.org/329223006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Fix unsigned comparison. (issue 329223006)

2014-06-12 Thread plind44
lgtm https://codereview.chromium.org/329223006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Revert "MIPS: Reland 21774: Generate KeyedLoadGeneric with Hydrogen" (issue 329973002)

2014-06-12 Thread plind44
lgtm https://codereview.chromium.org/329973002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Version 3.27.26.1 (merged r21784) (issue 333563002)

2014-06-12 Thread plind44
On 2014/06/12 08:30:53, Michael Achenbach wrote: I'll revert 21784 and then push again. Thanks Michael! Very kind of you... https://codereview.chromium.org/333563002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because

[v8-dev] Re: MIPS: Reland 21774: Generate KeyedLoadGeneric with Hydrogen (issue 327373002)

2014-06-11 Thread plind44
lgtm https://codereview.chromium.org/327373002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Fixed flooring division by a power of 2, once again... (issue 322403006)

2014-06-11 Thread plind44
Committed as r21780. https://codereview.chromium.org/322403006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Fixed flooring division by a power of 2, once again... (issue 322403006)

2014-06-11 Thread plind44
lgtm https://codereview.chromium.org/322403006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Revert 21774: "Generate KeyedLoadGeneric with Hydrogen" (issue 329723007)

2014-06-11 Thread plind44
Committed as r21777. https://codereview.chromium.org/329723007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Revert 21774: "Generate KeyedLoadGeneric with Hydrogen" (issue 329723007)

2014-06-11 Thread plind44
lgtm https://codereview.chromium.org/329723007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Generate KeyedLoadGeneric with Hydrogen. (issue 328173002)

2014-06-11 Thread plind44
Committed as r21775. https://codereview.chromium.org/328173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Generate KeyedLoadGeneric with Hydrogen. (issue 328173002)

2014-06-11 Thread plind44
lgtm https://codereview.chromium.org/328173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Simplify string copy in SubStringStub. (issue 326413002)

2014-06-11 Thread plind44
Committed as r21773. https://codereview.chromium.org/326413002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Simplify string copy in SubStringStub. (issue 326413002)

2014-06-11 Thread plind44
lgtm https://codereview.chromium.org/326413002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Introduce FieldIndex to unify and abstract property/field offset. (issue 314333003)

2014-06-06 Thread plind44
Committed as r21722. https://codereview.chromium.org/314333003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Introduce FieldIndex to unify and abstract property/field offset. (issue 314333003)

2014-06-06 Thread plind44
lgtm https://codereview.chromium.org/314333003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Preliminary support for block contexts in hydrogen. (issue 313183007)

2014-06-05 Thread plind44
Committed as r21701. https://codereview.chromium.org/313183007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Preliminary support for block contexts in hydrogen. (issue 313183007)

2014-06-05 Thread plind44
lgtm https://codereview.chromium.org/313183007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Improve write barriers in optimized code. (issue 315653002)

2014-06-03 Thread plind44
Committed as r21657. https://codereview.chromium.org/315653002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Improve write barriers in optimized code. (issue 315653002)

2014-06-03 Thread plind44
lgtm https://codereview.chromium.org/315653002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Simplify known successor block lowering. (issue 306053011)

2014-06-02 Thread plind44
Committed as r21610. https://codereview.chromium.org/306053011/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Refactor HType to get rid of various hacks. (issue 301023004)

2014-05-29 Thread plind44
Thanks for the review, Benedikt. Committed as r21580. https://codereview.chromium.org/301023004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe

[v8-dev] Re: MIPS: Fix improper register use in DoMinMax. (issue 300853002)

2014-05-27 Thread plind44
Committed as r21540. https://codereview.chromium.org/300853002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Fix improper register use in DoMinMax. (issue 300853002)

2014-05-27 Thread plind44
lgtm https://codereview.chromium.org/300853002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Convert String array index/length hash to BitField. (issue 297233007)

2014-05-27 Thread plind44
Committed as r21539. https://codereview.chromium.org/297233007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Convert String array index/length hash to BitField. (issue 297233007)

2014-05-27 Thread plind44
lgtm https://codereview.chromium.org/297233007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Use TempDoubleRegister. (issue 305563002)

2014-05-27 Thread plind44
Committed as r21537. https://codereview.chromium.org/305563002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Use TempDoubleRegister. (issue 305563002)

2014-05-27 Thread plind44
lgtm https://codereview.chromium.org/305563002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Use TempDoubleRegister. (issue 305563002)

2014-05-27 Thread plind44
https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc File src/mips/lithium-mips.cc (right): https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc#newcode1159 src/mips/lithium-mips.cc:1159: LOperand* temp = FixedTemp(f6); please remove this one, also. htt

[v8-dev] Re: MIPS: Avoid HeapObject check in HStoreNamedField. (issue 297143007)

2014-05-27 Thread plind44
Committed as r21525. https://codereview.chromium.org/297143007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Avoid HeapObject check in HStoreNamedField. (issue 297143007)

2014-05-27 Thread plind44
lgtm https://codereview.chromium.org/297143007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Skip write barriers in the fast case when setting up local context. (issue 302633002)

2014-05-26 Thread plind44
Committed as r21500. https://codereview.chromium.org/302633002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Skip write barriers in the fast case when setting up local context. (issue 302633002)

2014-05-26 Thread plind44
lgtm https://codereview.chromium.org/302633002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Fix r21470 "Reland r21442 Inobject slack tracking is done on a per-closure basis instead of p... (issue 297093002)

2014-05-23 Thread plind44
Committed as r21471. https://codereview.chromium.org/297093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Fix r21470 "Reland r21442 Inobject slack tracking is done on a per-closure basis instead of p... (issue 297093002)

2014-05-23 Thread plind44
lgtm https://codereview.chromium.org/297093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Fix r21470 "Reland r21442 Inobject slack tracking is done on a per-closure basis instead of p... (issue 297093002)

2014-05-23 Thread plind44
https://codereview.chromium.org/297093002/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/297093002/diff/1/src/mips/builtins-mips.cc#newcode400 src/mips/builtins-mips.cc:400: __ mov(t2, zero_reg); Can we add a comment here: // Slack tracki

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

2014-05-23 Thread plind44
Of course t2 is just clobbered, and knowing runtime call sets count to 0 lets us avoid reloading it. https://codereview.chromium.org/294973013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to t

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

2014-05-23 Thread plind44
On 2014/05/23 18:10:19, Igor Sheludko wrote: t2 must be set to zero here (which is JSFunction::kNoSlackTracking) since the slack tracking is actually over after the runtime call. Not sure if t7 survives after the runtime call above. Yep, t7 would get clobbered, and I not understand Runtime

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

2014-05-23 Thread plind44
Committed as r21470. https://codereview.chromium.org/294973013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

2014-05-23 Thread plind44
lgtm https://codereview.chromium.org/294973013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

2014-05-23 Thread plind44
Thanks for detailed review Igor! https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode390 src/mips/builtins-mips.cc:390: __ DecodeField(a3, t0); On 201

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

2014-05-23 Thread plind44
One comment, PTAL https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode440 src/mips/builtins-mips.cc:440: Label no_inobject_slack_tracking; The deleted

[v8-dev] Re: MIPS: Customized support for feedback on calls to Array. (issue 293063012)

2014-05-22 Thread plind44
Committed as r21445. https://codereview.chromium.org/293063012/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Allow specifying base offset when constructing Keyed hydrogen instructions. (issue 296983003)

2014-05-22 Thread plind44
Committed as r21443. https://codereview.chromium.org/296983003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Customized support for feedback on calls to Array. (issue 293063012)

2014-05-22 Thread plind44
lgtm https://codereview.chromium.org/293063012/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Allow specifying base offset when constructing Keyed hydrogen instructions. (issue 296983003)

2014-05-22 Thread plind44
lgtm https://codereview.chromium.org/296983003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Avoid flushing the icache unnecessarily when updating target addresses in code. (issue 296723003)

2014-05-20 Thread plind44
Committed as r21390. https://codereview.chromium.org/296723003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Avoid flushing the icache unnecessarily when updating target addresses in code. (issue 296723003)

2014-05-20 Thread plind44
lgtm https://codereview.chromium.org/296723003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Allow comparison in UINT32 mode. (issue 296453003)

2014-05-19 Thread plind44
Committed as r21369. https://codereview.chromium.org/296453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Allow comparison in UINT32 mode. (issue 296453003)

2014-05-19 Thread plind44
lgtm https://codereview.chromium.org/296453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Fix FlooringDivByPowerOf2I. (issue 277893003)

2014-05-14 Thread plind44
lgtm https://codereview.chromium.org/277893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Fix FlooringDivByPowerOf2I. (issue 277893003)

2014-05-14 Thread plind44
Committed as r21317. https://codereview.chromium.org/277893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Fix FlooringDivByPowerOf2I. (issue 277893003)

2014-05-14 Thread plind44
Committed as r21317. https://codereview.chromium.org/277893003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: Revert "MIPS: Reland r20974: Unify and simplify the FastCloneShallowArrayStub." (issue 271233003)

2014-05-09 Thread plind44
lgtm https://codereview.chromium.org/271233003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: MIPS: Reland and fix r21225 and r21226. (issue 275973002)

2014-05-09 Thread plind44
Committed as r21240. https://codereview.chromium.org/275973002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Reland and fix r21225 and r21226. (issue 275973002)

2014-05-09 Thread plind44
lgtm https://codereview.chromium.org/275973002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Reland r20974: Unify and simplify the FastCloneShallowArrayStub. (issue 273103002)

2014-05-09 Thread plind44
Committed as r21239. https://codereview.chromium.org/273103002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Reland r20974: Unify and simplify the FastCloneShallowArrayStub. (issue 273103002)

2014-05-09 Thread plind44
lgtm https://codereview.chromium.org/273103002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Improve Array.shift() performance for small arrays. (issue 275883002)

2014-05-09 Thread plind44
Committed as r21229. https://codereview.chromium.org/275883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Improve Array.shift() performance for small arrays. (issue 275883002)

2014-05-09 Thread plind44
lgtm https://codereview.chromium.org/275883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Fix for 3303 MultithreadedParallelIsolates has a race condition. (issue 264823004)

2014-05-06 Thread plind44
LGTM! https://codereview.chromium.org/264823004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: MIPS: CallICStub with a "never patch" approach by default. (issue 260753004)

2014-04-30 Thread plind44
Committed as r21105. https://codereview.chromium.org/260753004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: CallICStub with a "never patch" approach by default. (issue 260753004)

2014-04-30 Thread plind44
LGTM! https://codereview.chromium.org/260753004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: MIPS: Simplify feedback vector creation and store in SharedFunctionInfo. (issue 267433003)

2014-04-30 Thread plind44
Committed as r21098. https://codereview.chromium.org/267433003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Simplify feedback vector creation and store in SharedFunctionInfo. (issue 267433003)

2014-04-30 Thread plind44
lgtm https://codereview.chromium.org/267433003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Revert r20974, r20991: Unify and simplify the FastCloneShallowArrayStub. (issue 252023002)

2014-04-28 Thread plind44
Committed as r21024. https://codereview.chromium.org/252023002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Revert r20974, r20991: Unify and simplify the FastCloneShallowArrayStub. (issue 252023002)

2014-04-28 Thread plind44
lgtm https://codereview.chromium.org/252023002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Unify and simplify the FastCloneShallowArrayStub. (issue 258813002)

2014-04-25 Thread plind44
Committed as r20991. https://codereview.chromium.org/258813002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Unify and simplify the FastCloneShallowArrayStub. (issue 258813002)

2014-04-25 Thread plind44
lgtm https://codereview.chromium.org/258813002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: CodeStubs contain their corresponding Isolate* now. (part 2) (issue 251473004)

2014-04-24 Thread plind44
Committed as r20945. https://codereview.chromium.org/251473004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: CodeStubs contain their corresponding Isolate* now. (part 2) (issue 251473004)

2014-04-24 Thread plind44
lgtm https://codereview.chromium.org/251473004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: CodeStubs contain their corresponding Isolate* now. (part 1) (issue 252383005)

2014-04-24 Thread plind44
Committed as r20944. https://codereview.chromium.org/252383005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: CodeStubs contain their corresponding Isolate* now. (part 1) (issue 252383005)

2014-04-24 Thread plind44
lgtm https://codereview.chromium.org/252383005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Return Object* instead of MaybeObject* from runtime calls. (issue 246893010)

2014-04-22 Thread plind44
lgtm https://codereview.chromium.org/246893010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Improve code generation for bounds checks. (issue 246253007)

2014-04-22 Thread plind44
Committed as r20892. https://codereview.chromium.org/246253007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Improve code generation for bounds checks. (issue 246253007)

2014-04-22 Thread plind44
lgtm https://codereview.chromium.org/246253007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Serializer enable/disable flags need thread safety. (issue 239173004)

2014-04-17 Thread plind44
lgtm https://codereview.chromium.org/239173004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Track up to 5 stable maps as field type. (issue 240503008)

2014-04-17 Thread plind44
Committed as r20847. https://codereview.chromium.org/240503008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Track up to 5 stable maps as field type. (issue 240503008)

2014-04-17 Thread plind44
lgtm https://codereview.chromium.org/240503008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Implement structural function and array types (issue 240463004)

2014-04-16 Thread plind44
Committed as r20822. https://codereview.chromium.org/240463004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Implement structural function and array types (issue 240463004)

2014-04-16 Thread plind44
lgtm https://codereview.chromium.org/240463004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Reland r20692 "Check stack limit in ArgumentAdaptorTrampoline." (issue 239803004)

2014-04-15 Thread plind44
lgtm https://codereview.chromium.org/239803004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Add big-endian support for MIPS. (issue 228943009)

2014-04-15 Thread plind44
Committed as r20778. https://codereview.chromium.org/228943009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Reland "Track field types.". (issue 238943002)

2014-04-15 Thread plind44
Committed as r20774. https://codereview.chromium.org/238943002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Add big-endian support for MIPS. (issue 228943009)

2014-04-14 Thread plind44
The mips parts LGTM. PTAL at the rest... https://codereview.chromium.org/228943009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro

[v8-dev] Re: MIPS: Adjust memory limits. (issue 234153002)

2014-04-10 Thread plind44
LGTM, but we need review from v8 team. Please note Ákos question above. https://codereview.chromium.org/234153002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group

  1   2   3   4   5   6   7   8   >