[v8-dev] Re: Isolate::PrintStack: restore default verbose object printing (issue 1311123005 by jkumme...@chromium.org)

2015-09-04 Thread ulan via v8-dev
lgtm https://codereview.chromium.org/1311123005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread ulan via v8-dev
Thanks! https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h#newcode843 src/heap/heap.h:843: void FinalizeIncrementalMarkingIfComplete(const char* comment); On 2015/09/03 15:01:4

[v8-dev] Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread ulan via v8-dev
PTAL. The patch set 1 contains the original CL + DCHECK in incremenal-marking + regression test. The patch set 2 contains the actual fix. https://codereview.chromium.org/1311993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Remove GC metadata of code object before serializing. (issue 1313953008 by o...@chromium.org)

2015-09-03 Thread ulan via v8-dev
lgtm https://codereview.chromium.org/1313953008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from