Reviewers: Benedikt Meurer,
Message:
Hi Benedikt. Here is an in-progress CL which adds support for JS calls to
the
interpreter as well as adding support for a CallVarArgs instruction in TF as
discussed offline today. Currently it assumes the callable is a JSFunction
and
calls it directly, but I'll try patching in your CallCallableStub CL on
Monday
and see if that works. Very happy for any suggestions on how this could be
improved, particularly the TurboFan CallVarArgs bits. PTAL, thanks.
Description:
[Interpreter] Add support for JS calls.
Adds support for JS calls to the interpreter. Requires the addition of
CallVarArg instruction in TurboFan to enable calling with a variable
number of arguments.
Adds the CallJS bytecode.
BUG=v8:4280
LOG=N
Please review this at https://codereview.chromium.org/1323463005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+380, -12 lines):
M src/compiler/common-operator.h
M src/compiler/common-operator.cc
M src/compiler/instruction-selector.h
M src/compiler/instruction-selector.cc
M src/compiler/instruction-selector-impl.h
M src/compiler/interpreter-assembler.h
M src/compiler/interpreter-assembler.cc
M src/compiler/linkage.h
M src/compiler/opcodes.h
M src/compiler/raw-machine-assembler.h
M src/compiler/raw-machine-assembler.cc
M src/compiler/typer.cc
M src/compiler/verifier.cc
M src/compiler/x64/code-generator-x64.cc
M src/compiler/x64/instruction-codes-x64.h
M src/compiler/x64/instruction-selector-x64.cc
M src/interpreter/bytecode-array-builder.h
M src/interpreter/bytecode-array-builder.cc
M src/interpreter/bytecodes.h
M src/interpreter/bytecodes.cc
M src/interpreter/interpreter.cc
M test/cctest/interpreter/test-interpreter.cc
M test/unittests/compiler/interpreter-assembler-unittest.cc
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
