Reviewers: tandrii(chromium), Jakob,
Message:
PTAL
Description:
[test] More debugging output in test runner.
Also use again the taskkill method, recently removed in
https://codereview.chromium.org/1156133006/
BUG=chromium:485932
LOG=n
Please review this at https://codereview.chromium.org/1177903005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+19, -2 lines):
M tools/testrunner/local/commands.py
Index: tools/testrunner/local/commands.py
diff --git a/tools/testrunner/local/commands.py
b/tools/testrunner/local/commands.py
index
4d74165edbb5f63b54819178b37c30dc1e9f5ff1..6aac3ffad588e561bfc5c6f196664d490bfdd4c8
100644
--- a/tools/testrunner/local/commands.py
+++ b/tools/testrunner/local/commands.py
@@ -26,8 +26,8 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
import subprocess
+import sys
from threading import Timer
from ..local import utils
@@ -73,7 +73,24 @@ def RunProcess(verbose, timeout, args, **rest):
def kill_process(process, timeout_result):
timeout_result[0] = True
try:
- process.kill()
+ if utils.IsWindows():
+ if verbose:
+ print "Attempting to kill process %d" % process.pid
+ sys.stdout.flush()
+ tk = subprocess.Popen(
+ 'taskkill /T /F /PID %d' % process.pid,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE,
+ )
+ stdout, stderr = tk.communicate()
+ if verbose:
+ print "Taskkill results for %d" % process.pid
+ print stdout
+ print stderr
+ print "Return code: %d" % tk.returncode
+ sys.stdout.flush()
+ else:
+ process.kill()
except OSError:
sys.stderr.write('Error: Process %s already ended.\n' % process.pid)
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
