Reviewers: Michael Starzinger,
Message:
I should add tests, but it's unclear if they will be anything other than a
trivial copy of the logic that is in the reducer itself.
https://codereview.chromium.org/1220823004/diff/1/src/compiler/context-relaxation.cc
File src/compiler/context-relaxation.cc (right):
https://codereview.chromium.org/1220823004/diff/1/src/compiler/context-relaxation.cc#newcode28
src/compiler/context-relaxation.cc:28: if (!context_is_wired_) {
This is a bit weird, any better ideas?
Description:
[turbofan]: Add a context relaxation Reducer
Ensures that operations that only need to access the native context use the
outer-most context rather than the specific context given by the AST graph
builder. The makes it possible to use they operations with context
specialization (e.g. for generating stubs) without embedding forcing inner
contexts to be embedded in generated code thus causing leaks.
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/1220823004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+111, -2 lines):
M BUILD.gn
M src/compiler/ast-graph-builder.h
M src/compiler/ast-graph-builder.cc
A src/compiler/context-relaxation.h
A src/compiler/context-relaxation.cc
M src/compiler/pipeline.cc
M tools/gyp/v8.gyp
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
