Revision: 10786
Author:   yang...@chromium.org
Date:     Wed Feb 22 02:31:32 2012
Log:      Prevent segfault when preparser fails due to lack of argument.

BUG=v8:1963
TEST=run preparser with no command line arguments

Review URL: https://chromiumcodereview.appspot.com/9431028
http://code.google.com/p/v8/source/detail?r=10786

Modified:
 /branches/bleeding_edge/preparser/preparser-process.cc

=======================================
--- /branches/bleeding_edge/preparser/preparser-process.cc Fri Oct 14 00:34:45 2011 +++ /branches/bleeding_edge/preparser/preparser-process.cc Wed Feb 22 02:31:32 2012
@@ -200,12 +200,14 @@
   vfprintf(stderr, message, args);
   va_end(args);
   fflush(stderr);
-  // Print preparser data to stdout.
-  uint32_t size = data->size();
-  fprintf(stderr, "LOG: data size: %u\n", size);
-  if (!WriteBuffer(stdout, data->data(), size)) {
-    perror("ERROR: Writing data");
-    fflush(stderr);
+  if (data != NULL) {
+    // Print preparser data to stdout.
+    uint32_t size = data->size();
+    fprintf(stderr, "LOG: data size: %u\n", size);
+    if (!WriteBuffer(stdout, data->data(), size)) {
+      perror("ERROR: Writing data");
+      fflush(stderr);
+    }
   }
   exit(EXIT_FAILURE);
 }

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to