Revision: 13368
Author:   mstarzin...@chromium.org
Date:     Mon Jan 14 02:59:00 2013
Log:      Fix problem with NULL handle in r13367.

R=svenpa...@chromium.org
BUG=chromium:169723

Review URL: https://codereview.chromium.org/11881020
http://code.google.com/p/v8/source/detail?r=13368

Modified:
 /branches/bleeding_edge/src/runtime.cc

=======================================
--- /branches/bleeding_edge/src/runtime.cc      Mon Jan 14 02:21:22 2013
+++ /branches/bleeding_edge/src/runtime.cc      Mon Jan 14 02:59:00 2013
@@ -1098,14 +1098,15 @@

   PropertyAttributes attrs = obj->GetLocalPropertyAttribute(*name);
   if (attrs == ABSENT) return heap->undefined_value();
-  Handle<AccessorPair> accessors(obj->GetLocalPropertyAccessorPair(*name));
+  AccessorPair* raw_accessors = obj->GetLocalPropertyAccessorPair(*name);
+  Handle<AccessorPair> accessors(raw_accessors, isolate);

Handle<FixedArray> elms = isolate->factory()->NewFixedArray(DESCRIPTOR_SIZE);
   elms->set(ENUMERABLE_INDEX, heap->ToBoolean((attrs & DONT_ENUM) == 0));
elms->set(CONFIGURABLE_INDEX, heap->ToBoolean((attrs & DONT_DELETE) == 0));
-  elms->set(IS_ACCESSOR_INDEX, heap->ToBoolean(!accessors.is_null()));
+  elms->set(IS_ACCESSOR_INDEX, heap->ToBoolean(raw_accessors != NULL));

-  if (accessors.is_null()) {
+  if (raw_accessors == NULL) {
     elms->set(WRITABLE_INDEX, heap->ToBoolean((attrs & READ_ONLY) == 0));
     // GetProperty does access check.
     Handle<Object> value = GetProperty(obj, name);

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to