Revision: 15470
Author: yu...@chromium.org
Date: Wed Jul 3 07:23:34 2013
Log: Relax test expectations for test-cpu-profiler/FunctionApplySample
The profile may look a bit different on the bots (see below). We expected
this only under GC stress testing, the change makes regular expectations
the same.
[Top down]:
68 0 (root) [-1] #0 1
1 1 (program) [-1] #0 2
67 65 start [-1] #16 3
2 0 (unresolved function) [-1] #0 4
2 2 apply [-1] #0 5
BUG=None
TBR=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/18331012
http://code.google.com/p/v8/source/detail?r=15470
Modified:
/branches/bleeding_edge/test/cctest/test-cpu-profiler.cc
=======================================
--- /branches/bleeding_edge/test/cctest/test-cpu-profiler.cc Wed Jul 3
07:04:37 2013
+++ /branches/bleeding_edge/test/cctest/test-cpu-profiler.cc Wed Jul 3
07:23:34 2013
@@ -1168,14 +1168,8 @@
// Don't allow |test|, |bar| and |apply| nodes to be at the top level.
CheckChildrenNames(root, names);
}
-
- // In case of GC stress tests all samples may be in GC phase and there
- // won't be |start| node in the profile.
- bool is_gc_stress_testing =
- (i::FLAG_gc_interval != -1) || i::FLAG_stress_compaction;
const v8::CpuProfileNode* startNode = FindChild(root, "start");
- CHECK(is_gc_stress_testing || startNode);
if (startNode) {
{
ScopedVector<v8::Handle<v8::String> > names(2);
@@ -1185,7 +1179,6 @@
}
const v8::CpuProfileNode* testNode = FindChild(startNode, "test");
- CHECK(is_gc_stress_testing || testNode);
if (testNode) {
ScopedVector<v8::Handle<v8::String> > names(2);
names[0] = v8::String::New("bar");
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
