Revision: 16546
Author: mstarzin...@chromium.org
Date: Thu Sep 5 09:01:28 2013 UTC
Log: Prevent representation inference from double-visiting.
This prevents representation inference from pushing the current value
into the worklist while it is still being worked on. This might lead
to having a value in the worklist that isn't flexible anymore.
R=verwa...@chromium.org
TEST=mjsunit/compiler/escape-analysis (+GC-Stress)
Review URL: https://codereview.chromium.org/23452020
http://code.google.com/p/v8/source/detail?r=16546
Modified:
/branches/bleeding_edge/src/hydrogen-infer-representation.cc
=======================================
--- /branches/bleeding_edge/src/hydrogen-infer-representation.cc Tue Aug 27
13:55:00 2013 UTC
+++ /branches/bleeding_edge/src/hydrogen-infer-representation.cc Thu Sep 5
09:01:28 2013 UTC
@@ -152,8 +152,8 @@
// Do a fixed point iteration, trying to improve representations
while (!worklist_.is_empty()) {
HValue* current = worklist_.RemoveLast();
- in_worklist_.Remove(current->id());
current->InferRepresentation(this);
+ in_worklist_.Remove(current->id());
}
// Lastly: any instruction that we don't have representation information
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
