Revision: 20529
Author: ja...@chromium.org
Date: Mon Apr 7 08:42:34 2014 UTC
Log: Dead code elimination of inlined arguments objects causes wrong
deopt info to be generated - instead of materializing the arguments, we
get 'undefined'.
Golem says the change is perf-neutral.
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/208683006
http://code.google.com/p/v8/source/detail?r=20529
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-355486.js
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.h
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-355486.js Mon Apr
7 08:42:34 2014 UTC
@@ -0,0 +1,13 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function f() { var v = arguments[0]; }
+function g() { f(); }
+
+g();
+g();
+%OptimizeFunctionOnNextCall(g);
+g();
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.h Tue Apr 1 10:32:25
2014 UTC
+++ /branches/bleeding_edge/src/hydrogen-instructions.h Mon Apr 7 08:42:34
2014 UTC
@@ -3378,8 +3378,6 @@
set_representation(Representation::Tagged());
SetFlag(kIsArguments);
}
-
- virtual bool IsDeletable() const V8_FINAL V8_OVERRIDE { return true; }
};
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
