Revision: 21535
Author: da...@chromium.org
Date: Tue May 27 15:15:49 2014 UTC
Log: Small changes in preparation for Hydrogen-generated
KeyedLoadGeneric
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/303583002
http://code.google.com/p/v8/source/detail?r=21535
Modified:
/branches/bleeding_edge/src/arm/lithium-arm.h
/branches/bleeding_edge/src/arm64/lithium-arm64.h
/branches/bleeding_edge/src/hydrogen-instructions.cc
/branches/bleeding_edge/src/hydrogen-instructions.h
/branches/bleeding_edge/src/ia32/lithium-ia32.h
/branches/bleeding_edge/src/mips/lithium-mips.h
/branches/bleeding_edge/src/x64/lithium-x64.h
=======================================
--- /branches/bleeding_edge/src/arm/lithium-arm.h Tue May 27 10:22:53 2014
UTC
+++ /branches/bleeding_edge/src/arm/lithium-arm.h Tue May 27 15:15:49 2014
UTC
@@ -424,6 +424,7 @@
class LDeoptimize V8_FINAL : public LTemplateInstruction<0, 0, 0> {
public:
+ virtual bool IsControl() const V8_OVERRIDE { return true; }
DECLARE_CONCRETE_INSTRUCTION(Deoptimize, "deoptimize")
DECLARE_HYDROGEN_ACCESSOR(Deoptimize)
};
=======================================
--- /branches/bleeding_edge/src/arm64/lithium-arm64.h Fri May 23 14:06:42
2014 UTC
+++ /branches/bleeding_edge/src/arm64/lithium-arm64.h Tue May 27 15:15:49
2014 UTC
@@ -1288,6 +1288,7 @@
class LDeoptimize V8_FINAL : public LTemplateInstruction<0, 0, 0> {
public:
+ virtual bool IsControl() const V8_OVERRIDE { return true; }
DECLARE_CONCRETE_INSTRUCTION(Deoptimize, "deoptimize")
DECLARE_HYDROGEN_ACCESSOR(Deoptimize)
};
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Tue May 27
07:17:08 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Tue May 27
15:15:49 2014 UTC
@@ -2904,6 +2904,7 @@
if (UseCount() == 0) return true;
if (IsCell()) return false;
if (representation().IsDouble()) return false;
+ if (representation().IsExternal()) return false;
return true;
}
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.h Tue May 27 09:40:04
2014 UTC
+++ /branches/bleeding_edge/src/hydrogen-instructions.h Tue May 27 15:15:49
2014 UTC
@@ -7777,6 +7777,8 @@
class HLoadFieldByIndex V8_FINAL : public HTemplateInstruction<2> {
public:
+ DECLARE_INSTRUCTION_FACTORY_P2(HLoadFieldByIndex, HValue*, HValue*);
+
HLoadFieldByIndex(HValue* object,
HValue* index) {
SetOperandAt(0, object);
@@ -7786,7 +7788,11 @@
}
virtual Representation RequiredInputRepresentation(int index)
V8_OVERRIDE {
- return Representation::Tagged();
+ if (index == 1) {
+ return Representation::Smi();
+ } else {
+ return Representation::Tagged();
+ }
}
HValue* object() { return OperandAt(0); }
=======================================
--- /branches/bleeding_edge/src/ia32/lithium-ia32.h Mon May 26 06:41:21
2014 UTC
+++ /branches/bleeding_edge/src/ia32/lithium-ia32.h Tue May 27 15:15:49
2014 UTC
@@ -415,6 +415,7 @@
class LDeoptimize V8_FINAL : public LTemplateInstruction<0, 0, 0> {
public:
+ virtual bool IsControl() const V8_OVERRIDE { return true; }
DECLARE_CONCRETE_INSTRUCTION(Deoptimize, "deoptimize")
DECLARE_HYDROGEN_ACCESSOR(Deoptimize)
};
=======================================
--- /branches/bleeding_edge/src/mips/lithium-mips.h Fri May 23 13:15:07
2014 UTC
+++ /branches/bleeding_edge/src/mips/lithium-mips.h Tue May 27 15:15:49
2014 UTC
@@ -421,6 +421,7 @@
class LDeoptimize V8_FINAL : public LTemplateInstruction<0, 0, 0> {
public:
+ virtual bool IsControl() const V8_OVERRIDE { return true; }
DECLARE_CONCRETE_INSTRUCTION(Deoptimize, "deoptimize")
DECLARE_HYDROGEN_ACCESSOR(Deoptimize)
};
=======================================
--- /branches/bleeding_edge/src/x64/lithium-x64.h Mon May 26 06:41:21 2014
UTC
+++ /branches/bleeding_edge/src/x64/lithium-x64.h Tue May 27 15:15:49 2014
UTC
@@ -429,6 +429,7 @@
class LDeoptimize V8_FINAL : public LTemplateInstruction<0, 0, 0> {
public:
+ virtual bool IsControl() const V8_OVERRIDE { return true; }
DECLARE_CONCRETE_INSTRUCTION(Deoptimize, "deoptimize")
DECLARE_HYDROGEN_ACCESSOR(Deoptimize)
};
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
