Revision: 21542
Author: yang...@chromium.org
Date: Wed May 28 06:42:01 2014 UTC
Log: Fix path tracer test.
Path tracer is not compatible with --enable-slow-assert.
R=mstarzin...@chromium.org
BUG=v8:3350
LOG=N
Review URL: https://codereview.chromium.org/297193005
http://code.google.com/p/v8/source/detail?r=21542
Modified:
/branches/bleeding_edge/test/cctest/cctest.status
/branches/bleeding_edge/test/cctest/test-heap.cc
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.status Tue May 27 13:40:40
2014 UTC
+++ /branches/bleeding_edge/test/cctest/cctest.status Wed May 28 06:42:01
2014 UTC
@@ -74,9 +74,6 @@
# BUG(3287).
'test-cpu-profiler/SampleWhenFrameIsNotSetup': [PASS, FLAKY],
- # BUG(3350). Crashes.
- 'test-heap/PathTracer': [SKIP],
-
############################################################################
# Slow tests.
'test-api/Threading1': [PASS, ['mode == debug', SLOW]],
=======================================
--- /branches/bleeding_edge/test/cctest/test-heap.cc Tue May 27 13:05:11
2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-heap.cc Wed May 28 06:42:01
2014 UTC
@@ -4266,6 +4266,8 @@
#ifdef DEBUG
TEST(PathTracer) {
+ // Type cast checks fail because the path tracer abuses the map for
marking.
+ if (i::FLAG_enable_slow_asserts) return;
CcTest::InitializeVM();
v8::HandleScope scope(CcTest::isolate());
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
