Author: kasp...@chromium.org
Date: Wed Mar 25 03:29:22 2009
New Revision: 1606
Modified:
branches/bleeding_edge/src/assembler-ia32.cc
branches/bleeding_edge/tools/splaytree.py
Log:
Make sure to generate a CodeCreateEvent for the CPU features
probe code object, and really raise an exception if SplayTree.Remove
is called with a key that cannot be found.
Review URL: http://codereview.chromium.org/42597
Modified: branches/bleeding_edge/src/assembler-ia32.cc
==============================================================================
--- branches/bleeding_edge/src/assembler-ia32.cc (original)
+++ branches/bleeding_edge/src/assembler-ia32.cc Wed Mar 25 03:29:22 2009
@@ -139,6 +139,7 @@
Object* code =
Heap::CreateCode(desc, NULL, Code::ComputeFlags(Code::STUB), NULL);
if (!code->IsCode()) return;
+ LOG(CodeCreateEvent("Builtin", Code::cast(code), "CpuFeatures::Probe"));
typedef uint64_t (*F0)();
F0 probe = FUNCTION_CAST<F0>(Code::cast(code)->entry());
supported_ = probe();
Modified: branches/bleeding_edge/tools/splaytree.py
==============================================================================
--- branches/bleeding_edge/tools/splaytree.py (original)
+++ branches/bleeding_edge/tools/splaytree.py Wed Mar 25 03:29:22 2009
@@ -75,12 +75,12 @@
"""Remove the node with the given key from the SplayTree."""
# Raise exception for key that is not found if the tree is empty.
if self.IsEmpty():
- raise 'KeyNotFound'
+ raise Exception('KeyNotFound')
# Splay on the key to move the node with the given key to the top.
self.Splay(key)
# Raise exception for key that is not found.
if self.root.key != key:
- raise 'KeyNotFound'
+ raise Exception('KeyNotFound')
removed = self.root
# Link out the root node.
if not self.root.left:
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
