Reviewers: Jakob,

Message:
PTAL Jakob, thanks.

Description:
Add CXX cross-compile detection into Makefile after it was removed from gyp.

Please review this at https://codereview.chromium.org/405113002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+6, -1 lines):
  M Makefile


Index: Makefile
diff --git a/Makefile b/Makefile
index 4a4786e4a590104f5d2f243c5d3040d8e4506ce0..1ec36999ac7817415f3c23c53d50fba8d3141960 100644
--- a/Makefile
+++ b/Makefile
@@ -399,11 +399,16 @@ clean: $(addsuffix .clean, $(ARCHES) $(ANDROID_ARCHES) $(NACL_ARCHES)) native.cl
 # GYP file generation targets.
 OUT_MAKEFILES = $(addprefix $(OUTDIR)/Makefile.,$(BUILDS))
 $(OUT_MAKEFILES): $(GYPFILES) $(ENVFILE)
+       $(eval CXX_TARGET_ARCH:=$(shell $(CXX) -v 2>&1 | grep ^Target: | \
+               cut -f 2 -d " " | cut -f 1 -d "-" ))
+       $(eval V8_TARGET_ARCH:=$(subst .,,$(suffix $(basename $@))))
PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell pwd)/build:$(PYTHONPATH):$(shell pwd)/build/gyp/pylib:$(PYTHONPATH)" \
        GYP_GENERATORS=make \
        build/gyp/gyp --generator-output="$(OUTDIR)" build/all.gyp \
                      -Ibuild/standalone.gypi --depth=. \
-                     -Dv8_target_arch=$(subst .,,$(suffix $(basename $@))) \
+                     -Dv8_target_arch=$(V8_TARGET_ARCH) \
+                     $(if $(filter $(CXX_TARGET_ARCH),$(V8_TARGET_ARCH)), \
+                     -Dtarget_arch=$(CXX_TARGET_ARCH),) \
                      $(if $(findstring optdebug,$@),-Dv8_optimized_debug=2,) \
                      -S$(suffix $(basename $@))$(suffix $@) $(GYPFLAGS)



--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to