https://codereview.chromium.org/265823006/diff/1/include/v8-util.h
File include/v8-util.h (right):

https://codereview.chromium.org/265823006/diff/1/include/v8-util.h#newcode288
include/v8-util.h:288: RELEASE_ASSERT(!persistent->IsEmpty());
the v8 equivalent to RELEASE_ASSERT() is CHECK(), however, it's not
available in the header :-/

I'd add the CHECK in GlobalHandles::MakeWeak()

https://codereview.chromium.org/265823006/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to