Reviewers: Kasper Lund, Message: Small addition to last commit, including a regression test.
Description: Add regression test for the code flushing in issue 474 (which was fixed in revision 4921). This also enables codeflushing by default. Please review this at http://codereview.chromium.org/2829020/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/flag-definitions.h A test/mjsunit/regress/regress-747.js Index: src/flag-definitions.h =================================================================== --- src/flag-definitions.h (revision 4921) +++ src/flag-definitions.h (working copy) @@ -193,7 +193,7 @@ "print more details following each garbage collection") DEFINE_bool(collect_maps, true, "garbage collect maps from which no objects can be reached") -DEFINE_bool(flush_code, false, +DEFINE_bool(flush_code, true, "flush code that we expect not to use again before full gc") // v8.cc Index: test/mjsunit/regress/regress-747.js =================================================================== --- test/mjsunit/regress/regress-747.js (revision 0) +++ test/mjsunit/regress/regress-747.js (revision 0) @@ -0,0 +1,56 @@ +// Copyright 2010 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Flags: --expose_gc + +// This test makes sure that we do flush code with heap allocated locals. +// This can be a problem if eval is used within the scope. +// See: http://code.google.com/p/v8/issues/detail?id=747 + +(function() { + var x = 42; + this.callEval = function() {eval('x');}; +})(); + +try{ + callEval(); +} catch (e) { + assertUnreachable(); +} + +gc(); +gc(); +gc(); +gc(); +gc(); +gc(); + +try{ + callEval(); +} catch (e) { + assertUnreachable(); +} -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
