Re: [v8-dev] Adding missing SetCC before conditional branch. (issue 9950015)

2012-04-02 Thread Alexandre Rames
No sorry. I can try to create one if you want. Alexandre On Mon, Apr 2, 2012 at 4:26 PM, wrote: > Do you have a unit test that demonstrates a problem with the old code? > > > https://chromiumcodereview.appspot.com/9950015/ > > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.g

Re: [v8-dev] Adding missing SetCC before conditional branch. (issue 9950015)

2012-04-02 Thread danno
Do you have a unit test that demonstrates a problem with the old code? https://chromiumcodereview.appspot.com/9950015/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

Re: [v8-dev] Adding missing SetCC before conditional branch. (issue 9950015)

2012-04-02 Thread danno
Thanks for the catch, I'll land this and merge it back to previous branches appropriately. https://chromiumcodereview.appspot.com/9950015/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

Re: [v8-dev] Adding missing SetCC before conditional branch. (issue 9950015)

2012-04-02 Thread danno
lgtm https://chromiumcodereview.appspot.com/9950015/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Adding missing SetCC before conditional branch. (issue 9950015)

2012-03-30 Thread rodolph . perfetta
Reviewers: danno, Message: minor bugfix Description: Adding missing SetCC before conditional branch. BUG=none TEST=none Please review this at http://codereview.chromium.org/9950015/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/full-codegen-a