On Thu, Feb 16, 2023 at 2:30 AM Jakob Gruber wrote:
> On Thu, Feb 16, 2023 at 7:22 AM Kwasi Mensah
> wrote:
>
>> So there's three sites that needed to be updated to get this to work
>> properly:
>> * Strong reference on the feedback vector
>> https://github.com/kwasimensah/node/blob/c5ff019a
On Thu, Feb 16, 2023 at 7:22 AM Kwasi Mensah wrote:
> So there's three sites that needed to be updated to get this to work
> properly:
> * Strong reference on the feedback vector
> https://github.com/kwasimensah/node/blob/c5ff019a4e93891106859cb272ded1197a92c7e5/deps/v8/src/objects/feedback-v
So there's three sites that needed to be updated to get this to work
properly:
* Strong reference on the feedback vector
https://github.com/kwasimensah/node/blob/c5ff019a4e93891106859cb272ded1197a92c7e5/deps/v8/src/objects/feedback-vector.cc#L397
* Strong reference to the code's dependencie
On Wed, Feb 15, 2023 at 1:44 AM Kwasi Mensah wrote:
> Hi v8-dev,
>
> I was debugging something that was causing me to place extra GCs and saw
> that it was causing a ton of spurious turbofan recompilation of functions
> and deopts referencing weak objects. After digging a bit it looks like v8
> o
Hi v8-dev,
I was debugging something that was causing me to place extra GCs and saw
that it was causing a ton of spurious turbofan recompilation of functions
and deopts referencing weak objects. After digging a bit it looks like v8
only keeps a weak reference to optimized code in
https://githu
