Reviewers: jochen, paul.l...,

Message:
This change is to avoid the following warning in a WebView build using clang:

  external/chromium_org/v8/src/arm64/constants-arm64.h:18:9: warning:
'__STDC_FORMAT_MACROS' macro redefined [-Wmacro-redefined]
  #define __STDC_FORMAT_MACROS
          ^
  <command line>:3:9: note: previous definition is here
  #define __STDC_FORMAT_MACROS 1
          ^

PTAL, thanks.

Description:
Avoid redundent redefinition of __STDC_FORMAT_MACROS when building with clang

Please review this at https://codereview.chromium.org/404333003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+4, -0 lines):
  M src/arm64/constants-arm64.h
  M src/mips64/constants-mips64.h


Index: src/arm64/constants-arm64.h
diff --git a/src/arm64/constants-arm64.h b/src/arm64/constants-arm64.h
index f459b4b757625e6c6dae3fc39ae946e3beb30061..d06dd08b834398e92d7f7897dfa2ab3cdb91511a 100644
--- a/src/arm64/constants-arm64.h
+++ b/src/arm64/constants-arm64.h
@@ -15,7 +15,9 @@ STATIC_ASSERT(sizeof(1L) == sizeof(int64_t)); // NOLINT(runtime/sizeof)


 // Get the standard printf format macros for C99 stdint types.
+#ifndef __STDC_FORMAT_MACROS
 #define __STDC_FORMAT_MACROS
+#endif
 #include <inttypes.h>


Index: src/mips64/constants-mips64.h
diff --git a/src/mips64/constants-mips64.h b/src/mips64/constants-mips64.h
index 942c49750875434bd5e935a32fd161018ed1fd75..38e5aa3dd176d5d978844ec3326d2886ebfc82f6 100644
--- a/src/mips64/constants-mips64.h
+++ b/src/mips64/constants-mips64.h
@@ -72,7 +72,9 @@ const bool IsMipsSoftFloatABI = true;
 #endif


+#ifndef __STDC_FORMAT_MACROS
 #define __STDC_FORMAT_MACROS
+#endif
 #include <inttypes.h>




--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to