Reviewers: Mads Ager, Kevin Millikin,
Message:
Guys,
may you have a look?
Search algorithm is quite simple. If it'll prove to be a problem we can
easily
improve it emitting a separate list of emitted SFIs.
Description:
Do not create a SharedFunctionInfo for closures on each recompilation.
Unoptimized code should already keep a reference to the SharedFunctionInfo,
let's use it instead of allocating a new object and prohibiting
SharedFunctionInfo
specific optimizations.
Please review this at http://codereview.chromium.org/6706016/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
23831925f3738c8b6abedf6e0a391a9097ff1ad3..8573ba1eb3090fc3eab8d7b01019fd9d9295517e
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -2767,9 +2767,33 @@ void
HGraphBuilder::VisitDebuggerStatement(DebuggerStatement* stmt) {
}
+static Handle<SharedFunctionInfo> SearchSharedFunctionInfo(
+ Code* unoptimized_code, FunctionLiteral* expr) {
+ int start_position = expr->start_position();
+ RelocIterator it(unoptimized_code);
+ for (;!it.done(); it.next()) {
+ RelocInfo* rinfo = it.rinfo();
+ if (rinfo->rmode() != RelocInfo::EMBEDDED_OBJECT) continue;
+ Object* obj = rinfo->target_object();
+ if (obj->IsSharedFunctionInfo()) {
+ SharedFunctionInfo* shared = SharedFunctionInfo::cast(obj);
+ if (shared->start_position() == start_position) {
+ return Handle<SharedFunctionInfo>(shared);
+ }
+ }
+ }
+
+ return Handle<SharedFunctionInfo>();
+}
+
+
void HGraphBuilder::VisitFunctionLiteral(FunctionLiteral* expr) {
Handle<SharedFunctionInfo> shared_info =
- Compiler::BuildFunctionInfo(expr, info()->script());
+ SearchSharedFunctionInfo(info()->shared_info()->code(),
+ expr);
+ if (shared_info.is_null()) {
+ shared_info = Compiler::BuildFunctionInfo(expr, info()->script());
+ }
CHECK_BAILOUT;
HFunctionLiteral* instr =
new HFunctionLiteral(shared_info, expr->pretenure());
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
