Reviewers: vogelheim,
Description:
External snapshot: allow empty snapshot for external snapshot.
R=vogelh...@chromium.org
Please review this at https://codereview.chromium.org/1180043003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M src/snapshot/snapshot.h
Index: src/snapshot/snapshot.h
diff --git a/src/snapshot/snapshot.h b/src/snapshot/snapshot.h
index
371afef4fcd5c349f1cbf4f2b280eee692ef78cf..7f89213f16c41c56d881cac7d7ba14ee15a59b2c
100644
--- a/src/snapshot/snapshot.h
+++ b/src/snapshot/snapshot.h
@@ -38,7 +38,8 @@ class Snapshot : public AllStatic {
static bool HaveASnapshotToStartFrom(Isolate* isolate) {
// Do not use snapshots if the isolate is used to create snapshots.
- return isolate->snapshot_blob() != NULL;
+ return isolate->snapshot_blob() != NULL &&
+ isolate->snapshot_blob()->data != NULL;
}
static bool EmbedsScript(Isolate* isolate);
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.