Reviewers: machenbach,
Message:
Committed patchset #1 manually as r16474.
Description:
Fix Mac llvm-gcc42 build after commit r16473.
TBR=machenb...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16474
Please review this at https://codereview.chromium.org/23437020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-semaphore.cc
Index: test/cctest/test-semaphore.cc
diff --git a/test/cctest/test-semaphore.cc b/test/cctest/test-semaphore.cc
index
a0439116915a0fdde24615b06b3d318ce358bc08..895303f4f877188c8b06a249c94e0480e74bcde0
100644
--- a/test/cctest/test-semaphore.cc
+++ b/test/cctest/test-semaphore.cc
@@ -36,27 +36,28 @@
using namespace ::v8::internal;
-TEST(WaitAndSignal) {
- class WaitAndSignalThread V8_FINAL : public Thread {
- public:
- explicit WaitAndSignalThread(Semaphore* semaphore)
- : Thread("WaitAndSignalThread"), semaphore_(semaphore) {}
- virtual ~WaitAndSignalThread() {}
-
- virtual void Run() V8_OVERRIDE {
- for (int n = 0; n < 1000; ++n) {
- semaphore_->Wait();
- bool result = semaphore_->WaitFor(TimeDelta::FromMicroseconds(1));
- ASSERT(!result);
- USE(result);
- semaphore_->Signal();
- }
+class WaitAndSignalThread V8_FINAL : public Thread {
+ public:
+ explicit WaitAndSignalThread(Semaphore* semaphore)
+ : Thread("WaitAndSignalThread"), semaphore_(semaphore) {}
+ virtual ~WaitAndSignalThread() {}
+
+ virtual void Run() V8_OVERRIDE {
+ for (int n = 0; n < 1000; ++n) {
+ semaphore_->Wait();
+ bool result = semaphore_->WaitFor(TimeDelta::FromMicroseconds(1));
+ ASSERT(!result);
+ USE(result);
+ semaphore_->Signal();
}
+ }
+
+ private:
+ Semaphore* semaphore_;
+};
- private:
- Semaphore* semaphore_;
- };
+TEST(WaitAndSignal) {
Semaphore semaphore(0);
WaitAndSignalThread t1(&semaphore);
WaitAndSignalThread t2(&semaphore);
@@ -93,8 +94,10 @@ TEST(WaitFor) {
// Semaphore signalled - no timeout.
semaphore.Signal();
ok = semaphore.WaitFor(TimeDelta::FromMicroseconds(0));
+ CHECK(ok);
semaphore.Signal();
ok = semaphore.WaitFor(TimeDelta::FromMicroseconds(100));
+ CHECK(ok);
semaphore.Signal();
ok = semaphore.WaitFor(TimeDelta::FromMicroseconds(1000));
CHECK(ok);
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
