[v8-dev] Fix ProfileNodeFindOrAddChildForSameFunction test on Win32 debug. (issue3381013)

[mnaganov]

Reviewers: Søren Gjesse,

Description:
Fix ProfileNodeFindOrAddChildForSameFunction test on Win32 debug.
Test was failing is due to a fact that MSVC in debug mode uses
separate instances for identical string literals.

tbr=sgje...@chromium.org

Please review this at http://codereview.chromium.org/3381013/show

Affected files:
  M test/cctest/test-profile-generator.cc


Index: test/cctest/test-profile-generator.cc
diff --git a/test/cctest/test-profile-generator.cc  
b/test/cctest/test-profile-generator.cc
index  
d8f1c10917fd965bf38fa41734050b20fe6e8cf6..f46191a22a039c472ab6e2b65252af87192e80fa  
100644
--- a/test/cctest/test-profile-generator.cc
+++ b/test/cctest/test-profile-generator.cc
@@ -90,18 +90,20 @@ TEST(ProfileNodeFindOrAddChild) {


 TEST(ProfileNodeFindOrAddChildForSameFunction) {
+  const char* empty = "";
+  const char* aaa = "aaa";
   ProfileNode node(NULL, NULL);
-  CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", "", 0,
+  CodeEntry entry1(i::Logger::FUNCTION_TAG, empty, aaa, empty, 0,
                      TokenEnumerator::kNoSecurityToken);
   ProfileNode* childNode1 = node.FindOrAddChild(&entry1);
   CHECK_NE(NULL, childNode1);
   CHECK_EQ(childNode1, node.FindOrAddChild(&entry1));
   // The same function again.
-  CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "aaa", "", 0,
+  CodeEntry entry2(i::Logger::FUNCTION_TAG, empty, aaa, empty, 0,
                    TokenEnumerator::kNoSecurityToken);
   CHECK_EQ(childNode1, node.FindOrAddChild(&entry2));
   // Now with a different security token.
-  CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "aaa", "", 0,
+  CodeEntry entry3(i::Logger::FUNCTION_TAG, empty, aaa, empty, 0,
                    TokenEnumerator::kNoSecurityToken + 1);
   CHECK_EQ(childNode1, node.FindOrAddChild(&entry3));
 }


--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev