Reviewers: Mads Ager,
Description:
Fix issue 683: change the order of CPU profiler setup actions.
BUG=683
Please review this at http://codereview.chromium.org/1756003/show
Affected files:
M src/cpu-profiler.cc
Index: src/cpu-profiler.cc
diff --git a/src/cpu-profiler.cc b/src/cpu-profiler.cc
index
234114908cedb3cdb7698365e7fcac070fa3b64e..283ce9096fa3e592232066bba2f0fa691ac57e00
100644
--- a/src/cpu-profiler.cc
+++ b/src/cpu-profiler.cc
@@ -420,6 +420,9 @@ void CpuProfiler::StartProcessorIfNotStarted() {
generator_ = new ProfileGenerator(profiles_);
processor_ = new ProfilerEventsProcessor(generator_);
processor_->Start();
+ // Enable stack sampling.
+ // It is important to have it started prior to logging, see issue 683.
+ reinterpret_cast<Sampler*>(Logger::ticker_)->Start();
// Enumerate stuff we already have in the heap.
if (Heap::HasBeenSetup()) {
Logger::LogCodeObjects();
@@ -427,8 +430,6 @@ void CpuProfiler::StartProcessorIfNotStarted() {
Logger::LogFunctionObjects();
Logger::LogAccessorCallbacks();
}
- // Enable stack sampling.
- reinterpret_cast<Sampler*>(Logger::ticker_)->Start();
}
}
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
