Reviewers: Michael Starzinger,
Description:
Fix null handle deref in InternalDateFormat
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/22927014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/runtime.cc
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
dc648b2fd0cd55434c7f9ce172499f46f4e0d4d0..4355c863fd56dca92c51053b551ee4865ab1da38
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -13649,7 +13649,7 @@ RUNTIME_FUNCTION(MaybeObject*,
Runtime_InternalDateFormat) {
CONVERT_ARG_HANDLE_CHECKED(JSDate, date, 1);
bool has_pending_exception = false;
- double millis = Execution::ToNumber(date,
&has_pending_exception)->Number();
+ Handle<Object> value = Execution::ToNumber(date, &has_pending_exception);
if (has_pending_exception) {
ASSERT(isolate->has_pending_exception());
return Failure::Exception();
@@ -13660,7 +13660,7 @@ RUNTIME_FUNCTION(MaybeObject*,
Runtime_InternalDateFormat) {
if (!date_format) return isolate->ThrowIllegalOperation();
icu::UnicodeString result;
- date_format->format(millis, result);
+ date_format->format(value->Number(), result);
return *isolate->factory()->NewStringFromTwoByte(
Vector<const uint16_t>(
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
