Reviewers: Sven Panne,
Message:
Easy one, PTAL.
Description:
HIsStringAndBranch does an implicit SMI check if necessary.
No need to test for SMI first using HIsSmiAndBranch.
Please review this at https://codereview.chromium.org/27160002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -4 lines):
M src/code-stubs-hydrogen.cc
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index
c6fcac7a016ff6c65fe0a1d0143faa07c2256241..c9529a8de869d5e622d87a1c555e2512d5fcbe71
100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -885,8 +885,7 @@ HValue*
CodeStubGraphBuilder<BinaryOpStub>::BuildCodeInitializedStub() {
// critical.
if (left_type->Maybe(Type::String())) {
IfBuilder left_string(this);
- left_string.IfNot<HIsSmiAndBranch>(left);
- left_string.AndIf<HIsStringAndBranch>(left);
+ left_string.If<HIsStringAndBranch>(left);
left_string.Then();
Push(Add<HStringAdd>(left, right, STRING_ADD_CHECK_RIGHT));
left_string.Else();
@@ -897,8 +896,7 @@ HValue*
CodeStubGraphBuilder<BinaryOpStub>::BuildCodeInitializedStub() {
result = Pop();
} else {
IfBuilder right_string(this);
- right_string.IfNot<HIsSmiAndBranch>(right);
- right_string.AndIf<HIsStringAndBranch>(right);
+ right_string.If<HIsStringAndBranch>(right);
right_string.Then();
Push(Add<HStringAdd>(left, right, STRING_ADD_CHECK_LEFT));
right_string.Else();
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
