[v8-dev] MIPS: Fix [turbofan] Factor out common switch-related code in instruction selectors. (issue 1019923004 by balazs.kilvady@imgtec.com)

Thu, 26 Mar 2015 07:05:15 -0700

Reviewers: danno, titzer, paul.l..., akos.palfi.imgtec, gergely.kis.imgtec, dusmil.imgtec, 

Description:
MIPS: Fix [turbofan] Factor out common switch-related code in instruction
selectors.

BUG=

Please review this at https://codereview.chromium.org/1019923004/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+1, -1 lines):
  M src/compiler/mips/instruction-selector-mips.cc


Index: src/compiler/mips/instruction-selector-mips.cc
diff --git a/src/compiler/mips/instruction-selector-mips.cc b/src/compiler/mips/instruction-selector-mips.cc index cc952f9a35ec27e8cf9d5fd60c965b9af1c05e43..0e8df3e4481eb86fd5453454375d61377aceefbe 100644 
--- a/src/compiler/mips/instruction-selector-mips.cc
+++ b/src/compiler/mips/instruction-selector-mips.cc
@@ -785,7 +785,7 @@ void InstructionSelector::VisitSwitch(Node* node, const SwitchInfo& sw) { 
           lookup_space_cost + 3 * lookup_time_cost &&
       sw.min_value > std::numeric_limits<int32_t>::min()) {
     InstructionOperand index_operand = value_operand;
-    if (min_value) {
+    if (sw.min_value) {
       index_operand = g.TempRegister();
       Emit(kMipsSub, index_operand, value_operand,
            g.TempImmediate(sw.min_value));


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to