Reviewers: danno, Michael Starzinger, paul.l..., akos.palfi.imgtec,
gergely.kis.imgtec, dusmil.imgtec,
Description:
MIPS: Simplify pending message object handling.
Port d4696c484142c601cbd691ae80164043785a3af7
Original commit message:
This moves the decision whether to report a message or not to when
the pending exception is propagated instead of trying to preserve the
decision in a ThreadLocalTop field.
BUG=
Please review this at https://codereview.chromium.org/1004623002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -28 lines):
M src/mips/full-codegen-mips.cc
M src/mips64/full-codegen-mips64.cc
Index: src/mips/full-codegen-mips.cc
diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc
index
41fd718a5dcc501fc69296032192d7725328cdda..4b6091c0a1b8f58e08c33ef87b5848474ebd2256
100644
--- a/src/mips/full-codegen-mips.cc
+++ b/src/mips/full-codegen-mips.cc
@@ -5329,13 +5329,6 @@ void FullCodeGenerator::EnterFinallyBlock() {
__ li(at, Operand(pending_message_obj));
__ lw(a1, MemOperand(at));
__ push(a1);
-
- ExternalReference has_pending_message =
- ExternalReference::address_of_has_pending_message(isolate());
- __ li(at, Operand(has_pending_message));
- __ lw(a1, MemOperand(at));
- __ SmiTag(a1);
- __ push(a1);
}
@@ -5343,13 +5336,6 @@ void FullCodeGenerator::ExitFinallyBlock() {
DCHECK(!result_register().is(a1));
// Restore pending message from stack.
__ pop(a1);
- __ SmiUntag(a1);
- ExternalReference has_pending_message =
- ExternalReference::address_of_has_pending_message(isolate());
- __ li(at, Operand(has_pending_message));
- __ sw(a1, MemOperand(at));
-
- __ pop(a1);
ExternalReference pending_message_obj =
ExternalReference::address_of_pending_message_obj(isolate());
__ li(at, Operand(pending_message_obj));
Index: src/mips64/full-codegen-mips64.cc
diff --git a/src/mips64/full-codegen-mips64.cc
b/src/mips64/full-codegen-mips64.cc
index
f128a400ba8f00338c56f1ba949e6cdb76806457..cad5020dcb994d1e297fa4e04c3936e1bcc55794
100644
--- a/src/mips64/full-codegen-mips64.cc
+++ b/src/mips64/full-codegen-mips64.cc
@@ -5331,13 +5331,6 @@ void FullCodeGenerator::EnterFinallyBlock() {
__ li(at, Operand(pending_message_obj));
__ ld(a1, MemOperand(at));
__ push(a1);
-
- ExternalReference has_pending_message =
- ExternalReference::address_of_has_pending_message(isolate());
- __ li(at, Operand(has_pending_message));
- __ ld(a1, MemOperand(at));
- __ SmiTag(a1);
- __ push(a1);
}
@@ -5345,13 +5338,6 @@ void FullCodeGenerator::ExitFinallyBlock() {
DCHECK(!result_register().is(a1));
// Restore pending message from stack.
__ pop(a1);
- __ SmiUntag(a1);
- ExternalReference has_pending_message =
- ExternalReference::address_of_has_pending_message(isolate());
- __ li(at, Operand(has_pending_message));
- __ sd(a1, MemOperand(at));
-
- __ pop(a1);
ExternalReference pending_message_obj =
ExternalReference::address_of_pending_message_obj(isolate());
__ li(at, Operand(pending_message_obj));
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
