[v8-dev] Re: * Better factoring of ARM/IA32 code in irregexp.

No extra include file any more. A few more "#if defined(ARM)" fixed. http://codereview.chromium.org/12469/diff/22/202 File src/execution.cc (right): http://codereview.chromium.org/12469/diff/22/202#newcode35 Line 35: #if defined(ARM) On 2008/11/26 10:05:59, Kevin Millikin wrote: > #ifdef ARM G

[v8-dev] Re: * Better factoring of ARM/IA32 code in irregexp.

I'm afraid I don't like parts of this change. The new RegExpMacroAssemblerImpl typedef is only used in one place and that's inside an ifdef. It only adds confusion. The new include file does something very simple and is used twice where it could be inlined. Modulo this and the other comments i

[v8-dev] Re: * Better factoring of ARM/IA32 code in irregexp.

http://codereview.chromium.org/12469/diff/22/202 File src/execution.cc (right): http://codereview.chromium.org/12469/diff/22/202#newcode35 Line 35: #if defined(ARM) #ifdef ARM http://codereview.chromium.org/12469 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@