https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
https://codereview.chromium.org/1294793002/diff/20001/src/compiler/interpreter-assembler.cc
File src/compiler/interpreter-assembler.cc (right):
https://codereview.chromium.org/1294793002/diff/20001/src/compiler/interpreter-assembler.cc#newcode137
src/compiler/interpreter-assembler.cc:137: Node*
Failed to apply patch for src/interpreter/bytecode-array-builder.cc:
While running git apply --index -3 -p1;
error: patch failed: src/interpreter/bytecode-array-builder.cc:50
Falling back to three-way merge...
Applied patch to 'src/interpreter/bytecode-array-builder.cc' with
conflicts.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1294793002/11
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1294793002/11
https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1294793002/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1294793002/60001
https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 3 (id:??) landed as
https://crrev.com/f36cc258ffc89b15cd5f145e230bb2e36b45edf7
Cr-Commit-Position: refs/heads/master@{#30226}
https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:11)
https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
A couple of minor comments and modulo Michael's comment looks good here.
https://codereview.chromium.org/1294793002/diff/20001/src/compiler/interpreter-assembler.cc
File src/compiler/interpreter-assembler.cc (right):
LGTM modulo one comment about evaluation order.
https://codereview.chromium.org/1294793002/diff/20001/src/compiler/interpreter-assembler.h
File src/compiler/interpreter-assembler.h (right):
https://codereview.chromium.org/1294793002/diff/20001/src/compiler/interpreter-assembler.h#newcode39
To clarify my comment: I think we should put sequence points between all
invocations of the bytecode assembler, not just the ones with more than one
argument. This feels like asking for trouble.
https://codereview.chromium.org/1294793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
10 matches
Mail list logo
