[v8-dev] Re: [Interpreter] Add support for parameter variables. (issue 1303403004 by rmcil...@chromium.org)

2015-08-27 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:180001) https://codereview.chromium.org/1303403004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [Interpreter] Add support for parameter variables. (issue 1303403004 by rmcil...@chromium.org)

2015-08-27 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/5d975694e4d3ecf66716cc5395d4d10c9730f9dd Cr-Commit-Position: refs/heads/master@{#30403} https://codereview.chromium.org/1303403004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [Interpreter] Add support for parameter variables. (issue 1303403004 by rmcil...@chromium.org)

2015-08-27 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/180001 https://codereview.chromium.org/1303403004/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [Interpreter] Add support for parameter variables. (issue 1303403004 by rmcil...@chromium.org)

2015-08-27 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/160001 https://codereview.chromium.org/1303403004/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [Interpreter] Add support for parameter variables. (issue 1303403004 by rmcil...@chromium.org)

2015-08-27 Thread rmcilroy
https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc File src/arm64/builtins-arm64.cc (right): https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc#newcode1032 src/arm64/builtins-arm64.cc:1032: __ Drop(x1); On 2015/08/26 13:44:36, Micha

[v8-dev] Re: [Interpreter] Add support for parameter variables. (issue 1303403004 by rmcil...@chromium.org)

2015-08-26 Thread mstarzinger
LGTM. https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc File src/arm64/builtins-arm64.cc (right): https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc#newcode1032 src/arm64/builtins-arm64.cc:1032: __ Drop(x1); Not sure but isn't the

[v8-dev] Re: [Interpreter] Add support for parameter variables. (issue 1303403004 by rmcil...@chromium.org)

2015-08-25 Thread rmcilroy
Reviewers: Michael Starzinger, Message: Michael, could you take a look please, thanks. Description: [Interpreter] Add support for parameter variables. Adds support for parameters to the BytecodeArrayBuilder and BytecodeGenerator. Parameters are accessed as negative interpreter registers. BU

[v8-dev] Re: [Interpreter] Add support for parameter variables. (issue 1303403004 by rmcil...@chromium.org)

2015-08-25 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/80001 https://codereview.chromium.org/1303403004/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [Interpreter] Add support for parameter variables. (issue 1303403004 by rmcil...@chromium.org)

2015-08-25 Thread commit-...@chromium.org via codereview.chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files. h