Patchset 2 (id:??) landed as
https://crrev.com/23f7d34d4283b470f82c7ef485cc95e7e84106fe
Cr-Commit-Position: refs/heads/master@{#30660}
https://codereview.chromium.org/1319833004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1319833004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1319833004/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1319833004/20001
https://codereview.chromium.org/1319833004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
https://codereview.chromium.org/1319833004/diff/1/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):
https://codereview.chromium.org/1319833004/diff/1/src/interpreter/bytecodes.h#newcode101
src/interpreter/bytecodes.h:101: int index() const { return index_; }
On 2015/09/09 14:
lgtm. minor comment, but great.
https://codereview.chromium.org/1319833004/diff/1/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):
https://codereview.chromium.org/1319833004/diff/1/src/interpreter/bytecodes.h#newcode101
src/interpreter/bytecodes.h:101: int index() const { r
Ah, you can ignore my comment about SLOPPY/STRICT because I see elsewhere
that
you are only handling SLOPPY for now.
Yes, we only handle SLOPPY mode for now. As discussed offline we will
probably
have to have Strict/Strong versions of these bytecodes, but I'll do that in
a
future CL. Than
LGTM.
https://codereview.chromium.org/1319833004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Ah, you can ignore my comment about SLOPPY/STRICT because I see elsewhere
that
you are only handling SLOPPY for now.
Nice tests, again!
LGTM.
https://codereview.chromium.org/1319833004/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chr
Reviewers: oth, Michael Starzinger, mvstanton,
Message:
Michi / Orion, please review interpreter parts
Michael for vector stuff.
Thanks!
Description:
[Interpreter] Add support for property store operations.
Adds support for property store operations via Store/KeyedStore ICs. Adds
the
followi
