Committed patchset #8 manually as r22591 (presubmit successful).
https://codereview.chromium.org/393283007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/07/24 10:27:29, Alexandra Mikhaylova wrote:
On 2014/07/24 09:18:37, Alexandra Mikhaylova wrote:
>
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js
> File src/debug-debugger.js (right):
>
>
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugg
On 2014/07/24 09:18:37, Alexandra Mikhaylova wrote:
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js#newcode1211
src/debug-debugger.js:1211: event = new
Up
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js#newcode1211
src/debug-debugger.js:1211: event = new
UpdatePromiseParentEvent(event_data);
On 2014/07/24 08:43:
LGTM with comments.
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js#newcode1211
src/debug-debugger.js:1211: event = new
UpdatePromiseParentEvent(event_data);
looks good, deferring to @yangguo and @rossberg
https://codereview.chromium.org/393283007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
https://codereview.chromium.org/393283007/diff/70001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/393283007/diff/70001/src/promise.js#newcode226
src/promise.js:226: %DebugPromiseEvent({ type: "update",
On 2014/07/22 11:58:49, aandrey wrote:
now 3 update event call
https://codereview.chromium.org/393283007/diff/70001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/393283007/diff/70001/src/promise.js#newcode226
src/promise.js:226: %DebugPromiseEvent({ type: "update",
now 3 update event calls instead of one doesn't look good. just
https://codereview.chromium.org/393283007/diff/50001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/393283007/diff/50001/src/promise.js#newcode41
src/promise.js:41: var promise = PromiseInit(this);
On 2014/07/18 12:10:44, aandrey wrote:
this will fire "update" event
https://codereview.chromium.org/393283007/diff/50001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/393283007/diff/50001/src/promise.js#newcode41
src/promise.js:41: var promise = PromiseInit(this);
this will fire "update" event before "new". please create a test.
al
https://codereview.chromium.org/393283007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
11 matches
Mail list logo