[v8-dev] Re: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (issue 1111733002 by bmeu...@chromium.org)

2015-04-28 Thread rodolph . perfetta
On 2015/04/28 06:06:44, Benedikt Meurer wrote: Rodolph: Maybe you can look into enabling this warning for arm64 as well. It gives a bunch of warnings in the arm64/ directory that are related to mixing int and int64_t. We are looking into it. https://codereview.chromium.org/733002/ --

[v8-dev] Re: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (issue 1111733002 by bmeu...@chromium.org)

2015-04-27 Thread commit-bot
Patchset 5 (id:??) landed as https://crrev.com/4486c47d9b207e95f15598135262bb43f0c5dc00 Cr-Commit-Position: refs/heads/master@{#28093} https://codereview.chromium.org/733002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (issue 1111733002 by bmeu...@chromium.org)

2015-04-27 Thread commit-bot
Committed patchset #5 (id:80001) https://codereview.chromium.org/733002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (issue 1111733002 by bmeu...@chromium.org)

2015-04-27 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733002/80001 https://codereview.chromium.org/733002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (issue 1111733002 by bmeu...@chromium.org)

2015-04-27 Thread svenpanne
lgtm https://codereview.chromium.org/733002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (issue 1111733002 by bmeu...@chromium.org)

2015-04-27 Thread bmeurer
Rodolph: Maybe you can look into enabling this warning for arm64 as well. It gives a bunch of warnings in the arm64/ directory that are related to mixing int and int64_t. https://codereview.chromium.org/733002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/gro

[v8-dev] Re: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (issue 1111733002 by bmeu...@chromium.org)

2015-04-27 Thread bmeurer
Sven: This adds the compiler flag and fixes all invalid 64bit to 32bit truncations detected by clang (mostly in non-Windows code, since the Win64 compiler already complained about the ones in shared code). Also removed the MemoryMappedFile duplication on POSIX platforms. Please take a look. Ben: